Do reset email when deleting user again, but also disallow email

Author: Toastbrot236

Refresh.Database/GameDatabaseContext.Registration.cs

@@ -100,6 +100,7 @@ public bool IsUsernameTaken(string username, GameUser? userToName = null)
     {
         if (this.GameUsers.Any(u => u.Username == username)) return true;
         if (this.QueuedRegistrations.Any(r => r.Username == username)) return true;
+        if (this.IsUserDisallowed(username)) return true;
 
         PreviousUsername? previous = this.PreviousUsernames.FirstOrDefault(p => p.Username == username);
         // no one has ever had this name before
@@ -113,7 +114,8 @@ public bool IsUsernameTaken(string username, GameUser? userToName = null)
     public bool IsEmailTaken(string emailAddress)
     {
         return this.GameUsers.Any(u => u.EmailAddress == emailAddress) ||
-               this.QueuedRegistrations.Any(r => r.EmailAddress == emailAddress);
+               this.QueuedRegistrations.Any(r => r.EmailAddress == emailAddress) ||
+               this.IsEmailDisallowed(emailAddress);
     }
 
     public void AddRegistrationToQueue(string username, string emailAddress, string passwordBcrypt)
@@ -250,4 +252,35 @@ public bool IsUserDisallowed(string username)
     {
         return this.DisallowedUsers.FirstOrDefault(u => u.Username == username) != null;
     }
+
+    public bool DisallowEmail(string email)
+    {
+        if (this.IsEmailDisallowed(email)) 
+            return false;
+        
+        this.DisallowedEmails.Add(new()
+        {
+            Email = email,
+        });
+        this.SaveChanges();
+        
+        return true;
+    }
+    
+    public bool ReallowEmail(string email)
+    {
+        DisallowedEmail? disallowedEmail = this.DisallowedEmails.FirstOrDefault(u => u.Email == email);
+        if (disallowedEmail == null) 
+            return false;
+        
+        this.DisallowedEmails.Remove(disallowedEmail);
+        this.SaveChanges();
+        
+        return true;
+    }
+    
+    public bool IsEmailDisallowed(string email)
+    {
+        return this.DisallowedEmails.Any(u => u.Email == email);
+    }
 }

Refresh.Database/GameDatabaseContext.Users.cs

@@ -389,13 +389,15 @@ public void DeleteUser(GameUser user)
         this.BanUser(user, deletedReason, DateTimeOffset.MaxValue);
         this.RevokeAllTokensForUser(user);
         this.DeleteNotificationsByUser(user);
+        if (user.EmailAddress != null)
+            this.DisallowEmail(user.EmailAddress);
 
         this.Write(() =>
         {
             user.LocationX = 0;
             user.LocationY = 0;
             user.Description = deletedReason;
-            //user.EmailAddress = null; // should not be reset for now, to prevent them from just registering with it again
+            user.EmailAddress = null;
             user.PasswordBcrypt = "deleted";
             user.JoinDate = DateTimeOffset.MinValue;
             user.LastLoginDate = DateTimeOffset.MinValue;

Refresh.Database/GameDatabaseContext.cs

@@ -64,6 +64,7 @@ public partial class GameDatabaseContext : DbContext, IDatabaseContext
     internal DbSet<AssetDependencyRelation> AssetDependencyRelations { get; set; }
     internal DbSet<GameReview> GameReviews { get; set; }
     internal DbSet<DisallowedUser> DisallowedUsers { get; set; }
+    internal DbSet<DisallowedEmail> DisallowedEmails { get; set; }
     internal DbSet<RateReviewRelation> RateReviewRelations { get; set; }
     internal DbSet<TagLevelRelation> TagLevelRelations { get; set; }
     internal DbSet<GamePlaylist> GamePlaylists { get; set; }

Refresh.Database/Migrations/20260312203825_AddAbilityToDisallowEmails.cs

@@ -0,0 +1,35 @@
+using Microsoft.EntityFrameworkCore.Infrastructure;
+using Microsoft.EntityFrameworkCore.Migrations;
+
+#nullable disable
+
+namespace Refresh.Database.Migrations
+{
+    /// <inheritdoc />
+    [DbContext(typeof(GameDatabaseContext))]
+    [Migration("20260312203825_AddAbilityToDisallowEmails")]
+    public partial class AddAbilityToDisallowEmails : Migration
+    {
+        /// <inheritdoc />
+        protected override void Up(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.CreateTable(
+                name: "DisallowedEmails",
+                columns: table => new
+                {
+                    Email = table.Column<string>(type: "text", nullable: false)
+                },
+                constraints: table =>
+                {
+                    table.PrimaryKey("PK_DisallowedEmails", x => x.Email);
+                });
+        }
+
+        /// <inheritdoc />
+        protected override void Down(MigrationBuilder migrationBuilder)
+        {
+            migrationBuilder.DropTable(
+                name: "DisallowedEmails");
+        }
+    }
+}

Refresh.Database/Migrations/GameDatabaseContextModelSnapshot.cs

@@ -1510,6 +1510,16 @@ protected override void BuildModel(ModelBuilder modelBuilder)
                     b.ToTable("RequestStatistics");
                 });
 
+            modelBuilder.Entity("Refresh.Database.Models.Users.DisallowedEmail", b =>
+                {
+                    b.Property<string>("Email")
+                        .HasColumnType("text");
+
+                    b.HasKey("Email");
+
+                    b.ToTable("DisallowedEmails");
+                });
+
             modelBuilder.Entity("Refresh.Database.Models.Users.DisallowedUser", b =>
                 {
                     b.Property<string>("Username")

Refresh.Database/Models/Users/DisallowedEmail.cs

@@ -0,0 +1,9 @@
+namespace Refresh.Database.Models.Users;
+
+#nullable disable
+
+public partial class DisallowedEmail
+{
+    [Key]
+    public string Email { get; set; }
+}

Refresh.GameServer/CommandLineManager.cs

@@ -59,6 +59,12 @@ private class Options
 
         [Option("reallow-user", HelpText = "Re-allow a user to register. Username option is required if this is set.")]
         public bool ReallowUser { get; set; }
+
+        [Option("disallow-email", HelpText = "Disallow the email from being used by anyone in the future. Email option is required if this is set.")]
+        public bool DisallowEmail { get; set; }
+        
+        [Option("reallow-email", HelpText = "Re-allow the email to be used by anyone. Email option is required if this is set")]
+        public bool ReallowEmail { get; set; }
 
         [Option("rename-user", HelpText = "Changes a user's username. (old) username or Email option is required if this is set.")]
         public string? RenameUser { get; set; }
@@ -188,10 +194,28 @@ private void StartWithOptions(Options options)
             }
             else Fail("No username was provided");
         }
+        else if (options.DisallowEmail)
+        {
+            if (options.EmailAddress != null)
+            {
+                if (!this._server.DisallowEmail(options.EmailAddress))
+                    Fail("Email address is already disallowed");
+            }
+            else Fail("No email address was provided");
+        }
+        else if (options.ReallowEmail)
+        {
+            if (options.EmailAddress != null)
+            {
+                if (!this._server.ReallowEmail(options.EmailAddress))
+                    Fail("Email address is already allowed");
+            }
+            else Fail("No email address was provided");
+        }
         else if (options.RenameUser != null)
         {
             if(string.IsNullOrWhiteSpace(options.RenameUser))
-                Fail("Username must contain content");
+                Fail("Email address must contain content");
 
             GameUser user = this.GetUserOrFail(options);
             this._server.RenameUser(user, options.RenameUser, options.Force);

Refresh.GameServer/RefreshGameServer.cs

@@ -285,6 +285,20 @@ public bool ReallowUser(string username)
         return context.ReallowUser(username);
     }
 
+    public bool DisallowEmail(string email)
+    {
+        using GameDatabaseContext context = this.GetContext();
+        
+        return context.DisallowEmail(email);
+    }
+    
+    public bool ReallowEmail(string email)
+    {
+        using GameDatabaseContext context = this.GetContext();
+        
+        return context.ReallowEmail(email);
+    }
+
     public void RenameUser(GameUser user, string newUsername, bool force = false)
     {
         using GameDatabaseContext context = this.GetContext();

Refresh.Interfaces.APIv3/Endpoints/AuthenticationApiEndpoints.cs

@@ -324,7 +324,7 @@ public ApiResponse<IApiAuthenticationResponse> Register(RequestContext context,
         if (!smtpService.CheckEmailDomainValidity(body.EmailAddress))
             return ApiValidationError.EmailDoesNotActuallyExistError;
 
-        if (database.IsUserDisallowed(body.Username))
+        if (database.IsUserDisallowed(body.Username) || database.IsEmailDisallowed(body.EmailAddress))
             return new ApiAuthenticationError("You aren't allowed to play on this instance.");
 
         if (!database.IsUsernameValid(body.Username))

RefreshTests.GameServer/Tests/ApiV3/UserApiTests.cs

@@ -45,6 +45,28 @@ public void RegisterAccount()
         context.Database.Refresh();
         Assert.That(context.Database.GetUserByUsername(username), Is.Not.EqualTo(null));
     }
+
+    [Test]
+    public void CannotRegisterAccountWithDisallowedEmail()
+    {
+        using TestContext context = this.GetServer();
+
+        const string email = "guy@lil.com";
+        context.Database.DisallowEmail(email);
+        
+        ApiResponse<ApiAuthenticationResponse>? response = context.Http.PostData<ApiAuthenticationResponse>("/api/v3/register", new ApiRegisterRequest
+        {
+            Username = "a_lil_guy",
+            EmailAddress = email,
+            PasswordSha512 = "ee26b0dd4af7e749aa1a8ee3c10ae9923f618980772e473f8819a5d4940e0db27ac185f8a0e1d5f84f88bc887fd67b143732c304cc5fa9ad8e6f57f50028a8ff",
+        }, false, true);
+        Assert.That(response, Is.Not.Null);
+        Assert.That(response!.Error, Is.Not.Null);
+        Assert.That(response.Error!.Name, Is.EqualTo("ApiAuthenticationError"));
+        
+        context.Database.Refresh();
+        Assert.That(context.Database.GetUserByEmailAddress(email), Is.Null);
+    }
 
     [Test]
     public void CannotRegisterAccountWithDisallowedUsername()