Remove Refresh job states if their job doesn't exist

Author: Toastbrot236

Refresh.Database/GameDatabaseContext.Workers.cs

@@ -50,6 +50,13 @@ public bool MarkWorkerContacted(int id)
         return JsonConvert.DeserializeObject(state.State, type);
     }
 
+    public IQueryable<string> GetAllJobIds(WorkerClass? workerClass)
+    {
+        IQueryable<PersistentJobState> states = this.JobStates;
+        if (workerClass != null) states = states.Where(s => s.Class == workerClass);
+        return states.Select(s => s.JobId);
+    }
+
     public void UpdateOrCreateJobState(string jobId, object state, WorkerClass workerClass)
     {
         PersistentJobState? jobState = this.JobStates.FirstOrDefault(s => s.JobId == jobId && s.Class == workerClass);
@@ -66,4 +73,10 @@ public void UpdateOrCreateJobState(string jobId, object state, WorkerClass worke
         jobState.State = JsonConvert.SerializeObject(state, Formatting.None);
         this.SaveChanges();
     }
+
+    public void RemoveJobState(string jobId, bool save = true)
+    {
+        this.JobStates.RemoveRange(s => s.JobId == jobId);
+        if (save) this.SaveChanges();
+    }
 }

Refresh.Workers/WorkerManager.cs

@@ -105,6 +105,20 @@ public void Start()
         this._threadShouldRun = true;
         Thread thread = new(() =>
         {
+            GameDatabaseContext database = this._databaseProvider.GetContext();
+            string[] jobsFromWorkerManager = this._jobs.Select(j => j.GetType().Name).ToArray();
+            string[] jobsFromDatabase = database.GetAllJobIds(WorkerClass.Refresh).ToArray();
+            
+            foreach (string jobId in jobsFromDatabase)
+            {
+                if (!jobsFromWorkerManager.Any(j => j == jobId))
+                {
+                    this._logger.LogInfo(RefreshContext.Worker, $"Removing job state for {jobId} because it doesn't exist in RefreshWorkerManager (likely from a newer/different Refresh build).");
+                    database.RemoveJobState(jobId, false);
+                }
+            }
+            database.SaveChanges();
+
             while (this._threadShouldRun)
             {
                 try