Fix level creation in unit tests

Author: Toastbrot236

Refresh.Database/GameDatabaseContext.Levels.cs

@@ -52,7 +52,7 @@ public GameLevel AddLevel(ISerializedPublishLevel createInfo, TokenGame game, Ga
             EnforceMinMaxPlayers = createInfo.EnforceMinMaxPlayers,
             SameScreenGame = createInfo.SameScreenGame,
             BackgroundGuid = createInfo.BackgroundGuid,
-            Publisher = publisher,
+            PublisherUserId = publisher.UserId,
             GameVersion = game,
             PublishDate = timestamp,
             UpdateDate = timestamp,
@@ -71,14 +71,21 @@ public GameLevel AddLevel(ISerializedPublishLevel createInfo, TokenGame game, Ga
 
         this.SaveChanges();
 
-        if (level.Publisher != null)
+        if (publisher != null)
         {
-            this.WriteEnsuringStatistics(level.Publisher, () =>
+            this.WriteEnsuringStatistics(publisher, () =>
             {
-                level.Publisher.Statistics!.LevelCount++;
+                // even if the level count does get updated, ChangeTracker.HasChanges() will return false anyways
+                // (in unit tests atleast), failing the assert
+                this.GameUsers.Update(publisher);
+                publisher.Statistics!.LevelCount++;
             });
         }
 
+        // setting Publisher on an untracked object prevents EF from unconditionally trying to INSERT the publisher into the 
+        // GameUsers table on the next SaveChanges() call in unit tests, causing a duplicate key exception
+        level = level.Clone();
+        level.Publisher = publisher;
         return level;
     }
 

RefreshTests.GameServer/Tests/Levels/UploadTests.cs

@@ -24,6 +24,18 @@ public void CanCreateLevelDirectly()
         Assert.That(context.Database.GetLevelById(1), Is.Not.Null);
     }
 
+    [Test]
+    public void CanCreateTwoLevelsWhileRefreshing()
+    {
+        using TestContext context = this.GetServer(false);
+        GameUser user = context.CreateUser();
+        context.Database.Refresh();
+        GameLevel level1 = context.CreateLevel(user);
+        context.Database.Refresh();
+        GameLevel level2 = context.CreateLevel(user);
+        context.Database.Refresh();
+    }
+
     [Test]
     public void CanUpdateLevel()
     {