Move photo bound parsing to separate helper class

Author: Toastbrot236

Refresh.Database/Helpers/PhotoHelper.cs

@@ -0,0 +1,33 @@
+using System.Globalization;
+
+namespace Refresh.Database.Helpers;
+
+public abstract class PhotoHelper
+{
+    public const byte SubjectBoundCount = 4;
+    
+    public static void ParseBoundsList(ReadOnlySpan<char> input, float[] floats)
+    {
+        byte start = 0;
+        byte floatIndex = 0;
+
+        for (byte i = 0; i < input.Length; i++)
+        {
+            if(floatIndex == SubjectBoundCount - 1) break; // won't catch the last float - not worth reading
+            if (input[i] != ',') continue;
+            
+            if (!float.TryParse(input.Slice(start, i - start), NumberFormatInfo.InvariantInfo, out float f))
+                throw new FormatException("Invalid format");
+                
+            floats[floatIndex] = f;
+            floatIndex++;
+            start = (byte)(i + 1);
+        }
+        
+        // parse the last float value - bounds does not end with comma
+        if (!float.TryParse(input[start..], NumberFormatInfo.InvariantInfo, out float lastFloat))
+            throw new FormatException("Invalid format");
+
+        floats[SubjectBoundCount - 1] = lastFloat;
+    }
+}

Refresh.Database/Models/Photos/SerializedPhotoSubject.cs

@@ -1,4 +1,3 @@
-using System.Globalization;
 using System.Xml.Serialization;
 
 namespace Refresh.Database.Models.Photos;
@@ -17,31 +16,4 @@ public class SerializedPhotoSubject
 
     [XmlElement("bounds")]
     public string BoundsList { get; set; }
-    
-    public const byte FloatCount = 4;
-    
-    public static void ParseBoundsList(ReadOnlySpan<char> input, float[] floats)
-    {
-        byte start = 0;
-        byte floatIndex = 0;
-
-        for (byte i = 0; i < input.Length; i++)
-        {
-            if(floatIndex == FloatCount - 1) break; // won't catch the last float - not worth reading
-            if (input[i] != ',') continue;
-            
-            if (!float.TryParse(input.Slice(start, i - start), NumberFormatInfo.InvariantInfo, out float f))
-                throw new FormatException("Invalid format");
-                
-            floats[floatIndex] = f;
-            floatIndex++;
-            start = (byte)(i + 1);
-        }
-        
-        // parse the last float value - bounds does not end with comma
-        if (!float.TryParse(input[start..], NumberFormatInfo.InvariantInfo, out float lastFloat))
-            throw new FormatException("Invalid format");
-
-        floats[FloatCount - 1] = lastFloat;
-    }
 }

RefreshTests.GameServer/Tests/Parsing/PhotoBoundsTests.cs

@@ -1,4 +1,4 @@
-using Refresh.Database.Models.Photos;
+using Refresh.Database.Helpers;
 
 namespace RefreshTests.GameServer.Tests.Parsing;
 
@@ -8,9 +8,9 @@ public class PhotoBoundsTests
     public void ParsesBounds()
     {
         ReadOnlySpan<char> bounds = "0.652369,0.710704,0.838377,0.997791";
-        float[] floats = new float[SerializedPhotoSubject.FloatCount];
+        float[] floats = new float[PhotoHelper.SubjectBoundCount];
 
-        SerializedPhotoSubject.ParseBoundsList(bounds, floats);
+        PhotoHelper.ParseBoundsList(bounds, floats);
 
 #pragma warning disable NUnit2045
         Assert.That(floats[0], Is.EqualTo(0.652369f));
@@ -23,14 +23,14 @@ public void ParsesBounds()
     [Test]
     public void CatchesInvalidFormat()
     {
-        float[] floats = new float[SerializedPhotoSubject.FloatCount];
+        float[] floats = new float[PhotoHelper.SubjectBoundCount];
         const string bounds1 = "0.652369,0.71a0704,0.838377,0.997791";
         const string bounds2 = "0.652369,0.710704,0.838377,0.9977a91";
 
         Assert.Multiple(() =>
         {
-            Assert.That(() => SerializedPhotoSubject.ParseBoundsList(bounds1, floats), Throws.TypeOf<FormatException>());
-            Assert.That(() => SerializedPhotoSubject.ParseBoundsList(bounds2, floats), Throws.TypeOf<FormatException>());
+            Assert.That(() => PhotoHelper.ParseBoundsList(bounds1, floats), Throws.TypeOf<FormatException>());
+            Assert.That(() => PhotoHelper.ParseBoundsList(bounds2, floats), Throws.TypeOf<FormatException>());
         });
     }
 }