Fix tests, move tests to appropriate class

Author: Toastbrot236

Refresh.Database/Models/Levels/GameLevel.cs

@@ -26,11 +26,11 @@ public partial class GameLevel : ISequentialId
     public string RootResource { get; set; } = string.Empty;
 
     /// <summary>
-    /// When the level was first published in unix milliseconds
+    /// When the level was first published
     /// </summary>
     public DateTimeOffset PublishDate { get; set; }
     /// <summary>
-    /// When the level was last updated in unix milliseconds
+    /// When the level's root resource was last updated
     /// </summary>
     public DateTimeOffset UpdateDate { get; set; }
 

RefreshTests.GameServer/Tests/ApiV3/EditApiTests.cs

@@ -34,8 +34,7 @@ public void CanUpdateLevel()
         Assert.Multiple(() =>
         {
             Assert.That(level.Title, Is.EqualTo("Updated"));
-            Assert.That(level.UpdateDate, Is.Not.EqualTo(oldUpdate));
-            Assert.That(level.UpdateDate, Is.EqualTo(context.Time.Now));
+            Assert.That(level.UpdateDate, Is.EqualTo(oldUpdate));
         });
     }
 
@@ -93,8 +92,7 @@ public void RoleCanUpdateLevel(GameUserRole role)
         {
             Assert.That(level.Title, Is.EqualTo("Updated"));
             Assert.That(level.GameVersion, Is.EqualTo(TokenGame.LittleBigPlanetPSP));
-            Assert.That(level.UpdateDate, Is.Not.EqualTo(oldUpdate));
-            Assert.That(level.UpdateDate, Is.EqualTo(context.Time.Now));
+            Assert.That(level.UpdateDate, Is.EqualTo(oldUpdate));
         });
     }
 
@@ -120,65 +118,4 @@ public void CantUpdateMissingLevel()
             Assert.That(level.Title, Is.EqualTo("Not updated"));
         });
     }
-
-    [Test]
-    public void LevelUpdateChangesUpdateDate()
-    {
-        using TestContext context = this.GetServer(false);
-        GameUser author = context.CreateUser();
-
-        context.Time.TimestampMilliseconds = 1;
-        GameLevel level = context.CreateLevel(author);
-        Assert.Multiple(() =>
-        {
-            Assert.That(level.PublishDate.ToUnixTimeMilliseconds(), Is.EqualTo(1));
-            Assert.That(level.UpdateDate.ToUnixTimeMilliseconds(), Is.EqualTo(1));
-        });
-        
-        // When originating from a request, it wouldn't pass down the original PublishDate.
-        // Replicate this here.
-        GameLevelRequest newLevel = new()
-        {
-            RootResource = "g12345",
-        };
-
-        context.Time.TimestampMilliseconds = 2;
-        context.Database.UpdateLevel(newLevel, level);
-        Assert.Multiple(() =>
-        {
-            Assert.That(level.PublishDate.ToUnixTimeMilliseconds(), Is.EqualTo(1));
-            Assert.That(level.UpdateDate.ToUnixTimeMilliseconds(), Is.EqualTo(2));
-        });
-    }
-    
-    [Test]
-    public void LevelUpdateDoesNotChangeUpdateDateWhenRootUnchanged()
-    {
-        using TestContext context = this.GetServer(false);
-        GameUser author = context.CreateUser();
-
-        context.Time.TimestampMilliseconds = 1;
-        GameLevel level = context.CreateLevel(author);
-        Assert.Multiple(() =>
-        {
-            Assert.That(level.PublishDate.ToUnixTimeMilliseconds(), Is.EqualTo(1));
-            Assert.That(level.UpdateDate.ToUnixTimeMilliseconds(), Is.EqualTo(1));
-        });
-        
-        // When originating from a request, it wouldn't pass down the original PublishDate.
-        // Replicate this here.
-        GameLevelRequest newLevel = new()
-        {
-            Description = "description update",
-            RootResource = level.RootResource,
-        };
-
-        context.Time.TimestampMilliseconds = 2;
-        context.Database.UpdateLevel(newLevel, level);
-        Assert.Multiple(() =>
-        {
-            Assert.That(level.PublishDate.ToUnixTimeMilliseconds(), Is.EqualTo(1));
-            Assert.That(level.UpdateDate.ToUnixTimeMilliseconds(), Is.EqualTo(1));
-        });
-    }
 }

RefreshTests.GameServer/Tests/Levels/UploadTests.cs

@@ -68,4 +68,61 @@ public void CanDeleteLevel()
         context.Database.DeleteLevel(level);
         Assert.That(context.Database.GetLevelById(id), Is.Null);
     }
+
+    [Test]
+    public void LevelRootUpdateChangesUpdateDate()
+    {
+        using TestContext context = this.GetServer(false);
+        GameUser author = context.CreateUser();
+
+        context.Time.TimestampMilliseconds = 1;
+        GameLevel level = context.CreateLevel(author);
+        Assert.Multiple(() =>
+        {
+            Assert.That(level.PublishDate.ToUnixTimeMilliseconds(), Is.EqualTo(1));
+            Assert.That(level.UpdateDate.ToUnixTimeMilliseconds(), Is.EqualTo(1));
+        });
+        
+        GameLevelRequest newLevel = new()
+        {
+            RootResource = "g12345",
+        };
+
+        context.Time.TimestampMilliseconds = 2;
+        context.Database.UpdateLevel(newLevel, level);
+        Assert.Multiple(() =>
+        {
+            Assert.That(level.PublishDate.ToUnixTimeMilliseconds(), Is.EqualTo(1));
+            Assert.That(level.UpdateDate.ToUnixTimeMilliseconds(), Is.EqualTo(2));
+        });
+    }
+    
+    [Test]
+    public void LevelUpdateDoesNotChangeUpdateDateWhenRootUnchanged()
+    {
+        using TestContext context = this.GetServer(false);
+        GameUser author = context.CreateUser();
+
+        context.Time.TimestampMilliseconds = 1;
+        GameLevel level = context.CreateLevel(author);
+        Assert.Multiple(() =>
+        {
+            Assert.That(level.PublishDate.ToUnixTimeMilliseconds(), Is.EqualTo(1));
+            Assert.That(level.UpdateDate.ToUnixTimeMilliseconds(), Is.EqualTo(1));
+        });
+        
+        GameLevelRequest newLevel = new()
+        {
+            Description = "description update",
+            RootResource = level.RootResource,
+        };
+
+        context.Time.TimestampMilliseconds = 2;
+        context.Database.UpdateLevel(newLevel, level);
+        Assert.Multiple(() =>
+        {
+            Assert.That(level.PublishDate.ToUnixTimeMilliseconds(), Is.EqualTo(1));
+            Assert.That(level.UpdateDate.ToUnixTimeMilliseconds(), Is.EqualTo(1));
+        });
+    }
 }