✨ Refactor Forms Module: Enhance navigation and permissions 🎉

- Remove deprecated index page and related code 🗑️
- Update form menu to include access checks for current user 🔒
- Improve path handling in collected forms and embed code 🛠️
- Clean up unused variables and streamline module permissions 🧹
- Add new links for form management and embed code generation 🔗

Author: remdex

lhc_web/design/defaulttheme/tpl/lhform/index.tpl.php

@@ -8,6 +8,7 @@
             <?php include(erLhcoreClassDesign::designtpl('lhsystem/configuration_links/blocking.tpl.php'));?>
             <?php include(erLhcoreClassDesign::designtpl('lhsystem/configuration_links/look_and_feel.tpl.php'));?>
             <?php include(erLhcoreClassDesign::designtpl('lhsystem/configuration_links/integration.tpl.php'));?>
+            <?php include(erLhcoreClassDesign::designtpl('pagelayouts/parts/modules_menu/form.tpl.php'));?>
         </div>
         <div class="col-md-6">
             <?php include(erLhcoreClassDesign::designtpl('lhsystem/configuration_links/automation.tpl.php'));?>

lhc_web/design/defaulttheme/tpl/lhsystem/configuration_tabs_content/chat.tpl.php

@@ -1,4 +1,10 @@
 <?php include(erLhcoreClassDesign::designtpl('pagelayouts/parts/modules_menu/form_pre.tpl.php'));?>
-<?php if ($pagelayouts_parts_modules_menu_form_enabled == true && $useFm) : ?>
-<li class="nav-item"><a class="nav-link" href="<?php echo erLhcoreClassDesign::baseurl('form/index')?>"><i class="material-icons">attachment</i><?php echo erTranslationClassLhTranslation::getInstance()->getTranslation('browseoffer/index','Forms');?></a></li>
-<?php endif;?>
+<?php if ($pagelayouts_parts_modules_menu_form_enabled == true && $currentUser->hasAccessTo('lhform','manage_fm')) : ?>
+<h5><?php echo erTranslationClassLhTranslation::getInstance()->getTranslation('system/configuration','Forms');?></h5>
+<ul>
+    <li><a href="<?php echo erLhcoreClassDesign::baseurl('abstract/list')?>/Form"><?php echo erTranslationClassLhTranslation::getInstance()->getTranslation('system/configuration','List of forms');?></a></li>
+    <?php if ($currentUser->hasAccessTo('lhform','generate_js')) : ?>
+    <li><a href="<?php echo erLhcoreClassDesign::baseurl('form/embedcode')?>"><?php echo erTranslationClassLhTranslation::getInstance()->getTranslation('system/configuration','Page embed code');?></a></li>
+    <?php endif; ?>
+</ul>
+<?php endif; ?>

lhc_web/design/defaulttheme/tpl/pagelayouts/parts/modules_menu/form.tpl.php

@@ -3,5 +3,4 @@
 	$useFaq = $currentUser->hasAccessTo('lhfaq','manage_faq');
 	$useChatbox = $currentUser->hasAccessTo('lhchatbox','manage_chatbox');
 	$useBo = $currentUser->hasAccessTo('lhbrowseoffer','manage_bo');
-	$useFm = $currentUser->hasAccessTo('lhform','manage_fm');
 ?>

lhc_web/design/defaulttheme/tpl/pagelayouts/parts/modules_menu/modules_permissions.tpl.php

@@ -1,4 +1,4 @@
-<?php if ($useFm || $useBo || $useChatbox || $useFaq || $useQuestionary || $hasExtensionModule) : ?>
+<?php if ($useBo || $useChatbox || $useFaq || $useQuestionary || $hasExtensionModule) : ?>
      <li class="nav-item">
            <a href="#" class="nav-link"><i class="material-icons">info_outline</i><?php include(erLhcoreClassDesign::designtpl('pagelayouts/parts/extra_modules_title.tpl.php'));?><i class="material-icons arrow md-18">chevron_right</i></a>
            <ul class="nav nav-second-level collapse">
@@ -10,8 +10,6 @@
 
 			    <?php include(erLhcoreClassDesign::designtpl('pagelayouts/parts/modules_menu/browseoffer.tpl.php'));?>
 
-                <?php include(erLhcoreClassDesign::designtpl('pagelayouts/parts/modules_menu/form.tpl.php'));?>
-              
                 <?php include(erLhcoreClassDesign::designtpl('pagelayouts/parts/modules_menu/extension_module_multiinclude.tpl.php'));?>
           </ul>
     </li>

lhc_web/design/defaulttheme/tpl/pagelayouts/parts/top_menu_modules_extra.tpl.php

@@ -78,8 +78,7 @@ public function dependJs()
 	public function getModuleTranslations()
 	{
 	    $metaData = array(
-			'path' => array(
-				'url' => erLhcoreClassDesign::baseurl('form/index'),'title' => erTranslationClassLhTranslation::getInstance()->getTranslation('browseoffer/index','Form')),
+			'path' => array(),
 				'permission_delete' => array('module' => 'lhform','function' => 'delete_fm'), 'permission' => array('module' => 'lhform','function' => 'manage_fm'),
 				'name' => erTranslationClassLhTranslation::getInstance()->getTranslation('abstract/browserofferinvitation','Forms list')
 			);

lhc_web/lib/models/lhabstract/erlhabstractmodelform.php

@@ -68,7 +68,6 @@
 $Result['content'] = $tpl->fetch();
 
 $object_trans = $form->getModuleTranslations();
-$Result['path'][] =  $object_trans['path'];
 $Result['path'][] = array('url' => erLhcoreClassDesign::baseurl('abstract/list').'/Form','title' => $object_trans['name']);
 $Result['path'][] = array('title' => (string)$form);
 

lhc_web/modules/lhform/collected.php

@@ -9,7 +9,7 @@
 
 $Result['content'] = $tpl->fetch();
 $Result['path'] = array(
-		array('url' => erLhcoreClassDesign::baseurl('form/index'),'title' => erTranslationClassLhTranslation::getInstance()->getTranslation('form/index','Form')),
+		array('url' => erLhcoreClassDesign::baseurl('abstract/list').'/Form','title' => erTranslationClassLhTranslation::getInstance()->getTranslation('form/index','Form')),
 		array('title' => erTranslationClassLhTranslation::getInstance()->getTranslation('system/htmlcode','Page embed code')))
 
 ?>

lhc_web/modules/lhform/embedcode.php

@@ -4,11 +4,6 @@
 
 $ViewList = array();
 
-$ViewList['index'] = array(
-		'params' => array(),
-		'functions' => array( 'manage_fm' )
-);
-
 $ViewList['fill'] = array(
 		'params' => array('form_id'),
 		'functions' => array(  )