fix: correct typo in code-mirror-utils.js - I would be glad to become your contributor#420
Open
MatrixNeoKozak wants to merge 1 commit into
Open
Conversation
… your contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Corrected a typo in the
hasCleanRightutility function withinsrc/client/utils/code-mirror-utils.js, where the propertycowas incorrectly used instead ofchto define the column index for a CodeMirror range calculation.Rationale behind the implementation
The property
cois not a valid CodeMirror range position attribute, which would cause thehasCleanRightfunction to fail when calculating the range. The correct attribute isch.Technical impact analysis
This fix ensures that
hasCleanRightcorrectly identifies the range to the right of the given position, restoring the intended functionality of checking for blank space in CodeMirror editors within the Lively4 environment.