Skip to content

Render ACS pages at their native viewport instead of auto zooming in #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Render ACS pages at their native viewport instead of auto zooming in #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions 3DSView/src/main/java/eu/livotov/labs/android/d3s/D3SView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ public D3SView(final Context context) {
private void initUI() {
getSettings().setJavaScriptEnabled(true);
getSettings().setBuiltInZoomControls(true);
// Render bank pages at their native scale so they are not auto zoomed in.

Copilot AI Apr 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment says “native scale”, but setLoadWithOverviewMode(true) typically scales the page to fit the WebView (after honoring the page viewport) rather than preserving a true 1:1 “native” scale. Consider rewording to something like “Respect the page viewport and fit the content to the WebView to avoid starting zoomed in” to avoid misleading future readers.

Suggested change
// Render bank pages at their native scale so they are not auto zoomed in.
// Respect the page viewport and fit the content to the WebView to avoid starting zoomed in.

Copilot uses AI. Check for mistakes.
getSettings().setUseWideViewPort(true);
getSettings().setLoadWithOverviewMode(true);
addJavascriptInterface(new D3SJSInterface(), JavaScriptNS);

setWebViewClient(new WebViewClient() {
Expand Down
Loading