feat(lint): add linelint

Author: ReenigneArcher

.github/matchers/linelint.json

@@ -0,0 +1,17 @@
+{
+  "problemMatcher": [
+    {
+      "owner": "linelint",
+      "severity": "error",
+      "line": 1,
+      "pattern": [
+        {
+          "regexp": "^(\\[EOF Rule\\]) (File \"([^\"]+)\" has lint errors)$",
+          "code": 1,
+          "file": 3,
+          "message": 2
+        }
+      ]
+    }
+  ]
+}

.github/workflows/__call-common-lint.yml

@@ -25,6 +25,19 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v5
+        with:
+          fetch-depth: 2  # need to fetch 2 to get list of changed files
+
+      - name: Get changed files
+        id: changed_files
+        shell: bash
+        run: |
+          firstCommit='${{ github.event.pull_request.base.sha }}'
+          lastCommit='${{ github.event.pull_request.head.sha }}'
+          changedFiles=$(git diff --name-only --diff-filter=d "${firstCommit}" "${lastCommit}" | tr '\n' ' ')
+
+          echo "Changed files: ${changedFiles}"
+          echo "CHANGED_FILES=${changedFiles}" >> "${GITHUB_OUTPUT}"
 
       - name: Download problem matchers
         shell: bash
@@ -48,6 +61,7 @@ jobs:
             [cmake-lint]="${gh_path}/cmake-lint.json"
             [gcc]="${gh_path}/gcc.json"
             [hadolint]="${gh_path}/hadolint.json"
+            [linelint]="${gh_path}/linelint.json"
             [shellcheck-gcc]="${gh_path}/shellcheck-gcc.json"
             [yamllint]="${gh_path}/yamllint.json"
           )
@@ -73,6 +87,7 @@ jobs:
           python-version: '3.12'
 
       - name: Install Python dependencies
+        shell: bash
         run: |
           # shellcheck disable=SC2102  # this is triggered by the [toolchain] extra
           python -m pip install --upgrade \
@@ -101,7 +116,14 @@ jobs:
               "https://raw.githubusercontent.com/LizardByte/.github/master/.github/actionlint.yml"
           fi
 
+      - name: Install linelint
+        shell: bash
+        run: |
+          go install github.com/fernandrone/linelint@latest
+          echo "${HOME}/go/bin" >> "${GITHUB_PATH}"
+
       - name: Replace shell
+        # for actionlint
         shell: bash
         run: |
           # Replace in workflow files
@@ -130,6 +152,7 @@ jobs:
       - name: C++ - find files
         id: cpp_files
         if: always()
+        shell: bash
         run: |
           # find files
           found_files=$(find . -type f \
@@ -176,6 +199,7 @@ jobs:
 
       - name: C++ - Clang format (simple)
         if: always() && steps.clang_format_diff.outcome == 'failure'
+        shell: bash
         run: |
           echo "::add-matcher::.github/matchers/clang-format.json"
           set +e
@@ -193,6 +217,7 @@ jobs:
       - name: CMake - find files
         id: cmake_files
         if: always()
+        shell: bash
         run: |
           # find files
           found_files=$(find . -type f -iname "CMakeLists.txt" -o -iname "*.cmake")
@@ -221,6 +246,7 @@ jobs:
 
       - name: CMake - cmake-lint
         if: always() && steps.cmake_files.outputs.found_files
+        shell: bash
         run: |
           echo "::add-matcher::.github/matchers/cmake-lint.json"
           set +e
@@ -234,6 +260,7 @@ jobs:
       - name: Docker - find files
         id: docker_files
         if: always()
+        shell: bash
         run: |
           found_files=$(find . -type f -iname "Dockerfile" -o -iname "*.dockerfile")
 
@@ -244,6 +271,7 @@ jobs:
 
       - name: Docker - hadolint
         if: always() && steps.docker_files.outputs.found_files
+        shell: bash
         run: |
           docker pull hadolint/hadolint
 
@@ -286,6 +314,38 @@ jobs:
 
           exit ${error}
 
+      - name: eol-lint
+        if: always()
+        shell: bash
+        run: |
+          # Only print one error per file, with correct line number
+          error=0
+          for file in ${{ steps.changed_files.outputs.CHANGED_FILES }}; do
+            # Get last two lines
+            last_two=$(tail -n 2 "$file")
+            last_line=$(echo "$last_two" | tail -n 1)
+            second_last_line=$(echo "$last_two" | head -n 1)
+
+            # Check for exactly one blank line at end
+            if [[ "$last_line" != "" || "$second_last_line" == "" ]]; then
+              error=1
+              error_title="EOL linting error"
+              error_message="File '$file' does not end with a single empty blank line."
+              error_line_number=$(wc -l < "$file")
+              echo "::error file=$file,line=$error_line_number,title=$error_title::$error_message"
+            fi
+          done
+
+          exit ${error}
+
+      - name: linelint
+        if: always()
+        shell: bash
+        run: |
+          echo "::add-matcher::.github/matchers/linelint.json"
+          linelint ${{ steps.changed_files.outputs.CHANGED_FILES }}
+          echo "::remove-matcher owner=linelint::"
+
       - name: PowerShell - PSScriptAnalyzer
         if: always()
         shell: pwsh
@@ -339,6 +399,7 @@ jobs:
 
       - name: Python - flake8
         if: always()
+        shell: bash
         run: |
           echo "::group::problem matcher"
           set +e
@@ -359,6 +420,7 @@ jobs:
 
       - name: Python - nbqa flake8
         if: always()
+        shell: bash
         run: |
           echo "::group::problem matcher"
           set +e
@@ -381,6 +443,7 @@ jobs:
 
       - name: Python - nb-clean
         if: always()
+        shell: bash
         run: |
           output=$(find . -name '*.ipynb' -exec nb-clean check {} \;)
 
@@ -393,6 +456,7 @@ jobs:
       - name: Rust - find Cargo.toml
         id: run_cargo
         if: always()
+        shell: bash
         run: |
           # check if Cargo.toml exists
           if [ -f "Cargo.toml" ]; then
@@ -412,6 +476,7 @@ jobs:
 
       - name: Rust - cargo fmt
         if: always() && steps.run_cargo.outputs.found_cargo == 'true'
+        shell: bash
         run: |
           set +e
           error=0
@@ -449,6 +514,7 @@ jobs:
       - name: shellcheck - find files
         id: shellcheck_files
         if: always()
+        shell: bash
         run: |
           found_files=$(find . -type f -iname "*.bash" -o -iname "*.sh")
 
@@ -459,6 +525,7 @@ jobs:
 
       - name: shellcheck
         if: always() && steps.shellcheck_files.outputs.found_files
+        shell: bash
         run: |
           echo "::add-matcher::.github/matchers/shellcheck-gcc.json"
           set +e
@@ -472,6 +539,7 @@ jobs:
       - name: YAML - find files
         id: yaml_files
         if: always()
+        shell: bash
         run: |
           # space separated list of files
           FILES=.clang-format
@@ -491,6 +559,7 @@ jobs:
       - name: YAML - yamllint
         id: yamllint
         if: always()
+        shell: bash
         run: |
           if [ ! -f .yamllint.yml ]; then
             curl -sSL https://raw.githubusercontent.com/LizardByte/.github/master/.yamllint.yml -o .yamllint.yml

test/sample.txt

@@ -0,0 +1 @@
+test

test/sample2.txt

@@ -0,0 +1 @@
+test

test/sample3.txt

@@ -0,0 +1,2 @@
+test
+