fix(docker): simplify artifact extraction

Author: ReenigneArcher

.github/workflows/ci-windows.yml

@@ -25,7 +25,7 @@ jobs:
       matrix:
         include:
           - name: Windows-AMD64
-            os: windows-2019
+            os: windows-2022
             arch: x86_64
             msystem: ucrt64
             toolchain: ucrt-x86_64

docker/archlinux.dockerfile

@@ -114,14 +114,13 @@ rm -f /build/sunshine/pkg/sunshine-debug*.pkg.tar.zst
 ls -a
 _PKGBUILD
 
-FROM scratch AS artifacts
+FROM sunshine-base AS sunshine
 
 COPY --link --from=sunshine-build /build/sunshine/pkg/sunshine*.pkg.tar.zst /sunshine.pkg.tar.zst
-COPY --link --from=sunshine-build /build/sunshine/sunshine.pkg.tar.gz /sunshine.pkg.tar.gz
-
-FROM sunshine-base AS sunshine
 
-COPY --link --from=artifacts /sunshine.pkg.tar.zst /
+# artifacts to be extracted in CI
+COPY --link --from=sunshine-build /build/sunshine/pkg/sunshine*.pkg.tar.zst /artifacts/sunshine.pkg.tar.zst
+COPY --link --from=sunshine-build /build/sunshine/sunshine.pkg.tar.gz /artifacts/sunshine.pkg.tar.gz
 
 # install sunshine
 RUN <<_INSTALL_SUNSHINE

docker/debian-bookworm.dockerfile

@@ -51,16 +51,17 @@ Xvfb ${DISPLAY} -screen 0 1024x768x24 &
 ./test_sunshine --gtest_color=yes
 _TEST
 
-FROM scratch AS artifacts
+FROM sunshine-base AS sunshine
+
 ARG BASE
 ARG TAG
 ARG TARGETARCH
-COPY --link --from=sunshine-build /build/sunshine/build/cpack_artifacts/Sunshine.deb /sunshine-${BASE}-${TAG}-${TARGETARCH}.deb
 
-FROM sunshine-base AS sunshine
+# artifacts to be extracted in CI
+COPY --link --from=sunshine-build /build/sunshine/build/cpack_artifacts/Sunshine.deb /artifacts/sunshine-${BASE}-${TAG}-${TARGETARCH}.deb
 
 # copy deb from builder
-COPY --link --from=artifacts /sunshine*.deb /sunshine.deb
+COPY --link --from=sunshine-build /build/sunshine/build/cpack_artifacts/Sunshine.deb /sunshine.deb
 
 # install sunshine
 RUN <<_INSTALL_SUNSHINE

docker/ubuntu-22.04.dockerfile

@@ -59,8 +59,15 @@ COPY --link --from=sunshine-build /build/sunshine/build/cpack_artifacts/Sunshine
 
 FROM sunshine-base AS sunshine
 
+ARG BASE
+ARG TAG
+ARG TARGETARCH
+
+# artifacts to be extracted in CI
+COPY --link --from=sunshine-build /build/sunshine/build/cpack_artifacts/Sunshine.deb /artifacts/sunshine-${BASE}-${TAG}-${TARGETARCH}.deb
+
 # copy deb from builder
-COPY --link --from=artifacts /sunshine*.deb /sunshine.deb
+COPY --link --from=sunshine-build /build/sunshine/build/cpack_artifacts/Sunshine.deb /sunshine.deb
 
 # install sunshine
 RUN <<_INSTALL_SUNSHINE

docker/ubuntu-24.04.dockerfile

@@ -59,8 +59,15 @@ COPY --link --from=sunshine-build /build/sunshine/build/cpack_artifacts/Sunshine
 
 FROM sunshine-base AS sunshine
 
+ARG BASE
+ARG TAG
+ARG TARGETARCH
+
+# artifacts to be extracted in CI
+COPY --link --from=sunshine-build /build/sunshine/build/cpack_artifacts/Sunshine.deb /artifacts/sunshine-${BASE}-${TAG}-${TARGETARCH}.deb
+
 # copy deb from builder
-COPY --link --from=artifacts /sunshine*.deb /sunshine.deb
+COPY --link --from=sunshine-build /build/sunshine/build/cpack_artifacts/Sunshine.deb /sunshine.deb
 
 # install sunshine
 RUN <<_INSTALL_SUNSHINE