Commit 987c449
committed
review: address Copilot feedback on ProRes encoder integration
video.h:
is_known_video_format() now uses `< SUNSHINE_FORMAT_COUNT` instead of
the hardcoded `<= SUNSHINE_FORMAT_PRORES` upper bound. Future codecs
are now a one-enum-bump change.
video.cpp:
require_prores binds to the immutable config::video.prores_mode rather
than the mutable active_prores_mode. adjust_encoder_constraints() may
demote active_prores_mode to 0; reading the immutable source keeps the
"user explicitly asked for forced ProRes" intent intact so we fail
loudly instead of silently picking a non-ProRes encoder.
cmake/dependencies/macos.cmake:
Pull in the SCREEN_CAPTURE_KIT_LIBRARY REQUIRED change too — this PR
stacks on the SCK backend PR and needs the same SDK enforcement.
Addresses Copilot inline feedback from the closed upstream PR cycle.1 parent f6ebe21 commit 987c449
2 files changed
Lines changed: 12 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2968 | 2968 | | |
2969 | 2969 | | |
2970 | 2970 | | |
2971 | | - | |
| 2971 | + | |
| 2972 | + | |
| 2973 | + | |
| 2974 | + | |
| 2975 | + | |
| 2976 | + | |
| 2977 | + | |
| 2978 | + | |
2972 | 2979 | | |
2973 | 2980 | | |
2974 | 2981 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
35 | 38 | | |
36 | 39 | | |
37 | 40 | | |
| |||
0 commit comments