Skip to content

Commit ab3f788

Browse files
committed
ui(prores): move prores_mode toggle next to prores_profile on VideoToolbox tab
The experimental ProRes mode selector landed in the generic Advanced tab while prores_profile (its inseparable companion — the mode toggle only makes sense if you also pick a profile) lived on the VideoToolbox Encoder tab. Splitting the two knobs across tabs hurts discoverability: users configuring VideoToolbox don't realise ProRes exists, and users on the Advanced tab can't see the profile that controls bit depth and chroma subsampling. Move prores_mode into VideoToolboxEncoder.vue directly above prores_profile so both controls sit together in their codec-relevant section. The macOS-only platform guard previously around prores_mode in Advanced.vue is implicit on the VideoToolbox tab (which is itself macOS-only), so it can be dropped. No backend or config change; pure UI relocation.
1 parent 81a6928 commit ab3f788

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

src_assets/common/assets/web/configs/tabs/Advanced.vue

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -58,17 +58,6 @@ const config = ref(props.config)
5858
<div class="form-text">{{ $t('config.av1_mode_desc') }}</div>
5959
</div>
6060

61-
<!-- Experimental ProRes Support -->
62-
<div class="mb-3" v-if="platform === 'macos'">
63-
<label for="prores_mode" class="form-label">{{ $t('config.prores_mode') }}</label>
64-
<select id="prores_mode" class="form-select" v-model="config.prores_mode">
65-
<option value="0">{{ $t('config.prores_mode_0') }}</option>
66-
<option value="1">{{ $t('config.prores_mode_1') }}</option>
67-
<option value="2">{{ $t('config.prores_mode_2') }}</option>
68-
</select>
69-
<div class="form-text">{{ $t('config.prores_mode_desc') }}</div>
70-
</div>
71-
7261
<!-- Capture -->
7362
<div class="mb-3" v-if="platform !== 'macos'">
7463
<label for="capture" class="form-label">{{ $t('config.capture') }}</label>

src_assets/common/assets/web/configs/tabs/encoders/VideotoolboxEncoder.vue

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,17 @@ const config = ref(props.config)
3737
v-model="config.vt_realtime"
3838
default="true"
3939
></Checkbox>
40+
41+
<!-- Experimental ProRes Support -->
42+
<div class="mb-3">
43+
<label for="prores_mode" class="form-label">{{ $t('config.prores_mode') }}</label>
44+
<select id="prores_mode" class="form-select" v-model="config.prores_mode">
45+
<option value="0">{{ $t('config.prores_mode_0') }}</option>
46+
<option value="1">{{ $t('config.prores_mode_1') }}</option>
47+
<option value="2">{{ $t('config.prores_mode_2') }}</option>
48+
</select>
49+
<div class="form-text">{{ $t('config.prores_mode_desc') }}</div>
50+
</div>
4051
<div class="mb-3">
4152
<label for="prores_profile" class="form-label">{{ $t('config.prores_profile') }}</label>
4253
<select id="prores_profile" class="form-select" v-model="config.prores_profile">

0 commit comments

Comments
 (0)