fix: improve exception for issue comments (#6796)

Author: ReenigneArcher

.github/workflows/ci-tests.yml

@@ -3,6 +3,7 @@ name: CI Tests
 permissions: {}
 
 env:
+  NODE_VERSION: '24'
   PYTHON_VERSION: '3.14'
 
 on:
@@ -28,7 +29,7 @@ jobs:
       - name: Setup Node
         uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e  # v6.4.0
         with:
-          node-version: latest
+          node-version: ${{ env.NODE_VERSION }}
 
       - name: Install uv
         uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b  # v8.1.0

src/updater.py

@@ -1029,6 +1029,13 @@ def _load_tmdb_item_data(item_type: str, item_id: Union[int, str]) -> tuple[str,
 
     if response.status_code == 404:
         _remove_stale_tmdb_file(database_path=database_path, item_type=item_type, item_id=item_id)
+        if getattr(args, 'issue_update', False):
+            exception_writer(
+                error=Exception(
+                    f'Error processing TMDB url: {item_type} id {item_id} not found or unavailable',
+                ),
+                name='tmdb',
+            )
         return database_path, item_id, {}
 
     if response.status_code != 200:
@@ -1410,15 +1417,18 @@ def update_contributor_info(original: bool, base_dir: str) -> None:
 def _load_issue_submission_values(database_url: Optional[str],
                                   youtube_url: Optional[str]) -> tuple[Optional[str], Optional[str], dict]:
     """Load missing issue-update values from the submission file."""
-    if database_url and youtube_url:
-        return database_url, youtube_url, {}
+    issue_submission = {}
+    if not database_url or not youtube_url:
+        issue_submission = process_submission()
 
-    issue_submission = process_submission()
     if not database_url:
         database_url = issue_submission['database_url'].strip()
 
     if not youtube_url:
-        youtube_url = check_youtube(data=issue_submission)
+        youtube_url = issue_submission['youtube_theme_url']
+
+    if youtube_url:
+        youtube_url = check_youtube(data={'youtube_theme_url': youtube_url})
 
     return database_url, youtube_url, issue_submission
 
@@ -1454,13 +1464,13 @@ def process_issue_update(database_url: Optional[str] = None, youtube_url: Option
 
     item_type, item_id, exceptions = _match_database_url(database_url=database_url)
     if item_type:
-        process_item_id(
+        data = process_item_id(
             item_type=item_type,
             item_id=item_id,
             youtube_url=youtube_url,
             issue_submission=issue_submission,
         )
-        return item_type
+        return item_type if data else False
 
     # if we get here, we didn't find a match
     for exception in exceptions:

tests/unit/test_issue_updater.py

@@ -500,16 +500,17 @@ def test_write_item_files_writes_primary_and_imdb_copy(tmp_path, monkeypatch):
 
 
 def test_load_issue_submission_values_uses_supplied_values(monkeypatch):
-    """Test fully supplied issue-update values bypass submission processing."""
+    """Test fully supplied issue-update values bypass submission loading but still validate YouTube."""
     monkeypatch.setattr(
         updater,
         'process_submission',
         lambda: pytest.fail('submission file should not be read'),
     )
+    monkeypatch.setattr(updater, 'check_youtube', lambda data: f"canonical-{data['youtube_theme_url']}")
 
     assert updater._load_issue_submission_values(database_url='database-url', youtube_url='youtube-url') == (
         'database-url',
-        'youtube-url',
+        'canonical-youtube-url',
         {},
     )
 
@@ -564,6 +565,7 @@ def test_process_issue_update(
         issue_update_args,
         mock_igdb_api,
         mock_tmdb_api,
+        mock_youtube_api,
         youtube_url,
         tmp_path,
         monkeypatch,
@@ -1273,7 +1275,7 @@ def test_update_contributor_info_increments_existing_edit(tmp_path, monkeypatch)
     }
 
 
-def test_process_issue_update_reports_unsupported_database_url(tmp_path, monkeypatch, youtube_url):
+def test_process_issue_update_reports_unsupported_database_url(tmp_path, monkeypatch, mock_youtube_api, youtube_url):
     """Test that unsupported database URLs report every regex miss."""
     monkeypatch.chdir(tmp_path)
 
@@ -1284,10 +1286,12 @@ def test_process_issue_update_reports_unsupported_database_url(tmp_path, monkeyp
 
     assert result is False
     exceptions = (tmp_path / 'exceptions.md').read_text()
+    comment = (tmp_path / 'comment.md').read_text(encoding='utf-8')
     assert exceptions.count('Exception Occurred') == 6
+    assert comment.count('Exception Occurred') == 6
 
 
-def test_process_issue_update_writes_author_badges_first(tmp_path, monkeypatch, youtube_url):
+def test_process_issue_update_writes_author_badges_first(tmp_path, monkeypatch, mock_youtube_api, youtube_url):
     """Test issue update comments start with the author badges."""
     monkeypatch.chdir(tmp_path)
     monkeypatch.setenv('GITHUB_REPOSITORY', 'LizardByte/ThemerrDB')
@@ -1315,6 +1319,50 @@ def test_process_issue_update_writes_author_badges_first(tmp_path, monkeypatch,
     assert 'Exception Occurred' in comment
 
 
+def test_process_issue_update_reports_invalid_supplied_youtube_url(tmp_path, monkeypatch):
+    """Test supplied invalid YouTube URLs are written to the issue comment."""
+    monkeypatch.chdir(tmp_path)
+
+    result = updater.process_issue_update(
+        database_url='https://www.igdb.com/games/goldeneye-007',
+        youtube_url='https://www.youtube.com/watch?v=invalid',
+    )
+
+    comment = (tmp_path / 'comment.md').read_text(encoding='utf-8')
+    assert result is False
+    assert 'Could not extract video ID from URL' in comment
+
+
+def test_process_issue_update_reports_tmdb_not_found_in_comment(
+        tmp_path,
+        monkeypatch,
+        issue_update_args,
+        mock_youtube_api,
+        youtube_url,
+):
+    """Test issue-update TMDB 404 responses are written to the issue comment."""
+    monkeypatch.chdir(tmp_path)
+    monkeypatch.setenv('TMDB_API_KEY_V3', 'test-key')
+    monkeypatch.setitem(
+        updater.databases['movie'],
+        'path',
+        str(tmp_path / 'database' / 'movies' / 'themoviedb'),
+    )
+
+    response = MagicMock()
+    response.status_code = 404
+    monkeypatch.setattr(updater, 'requests_loop', lambda **kwargs: response)
+
+    result = updater.process_issue_update(
+        database_url='https://www.themoviedb.org/movie/42903-missing',
+        youtube_url=youtube_url,
+    )
+
+    comment = (tmp_path / 'comment.md').read_text(encoding='utf-8')
+    assert result is False
+    assert 'Error processing TMDB url: movie id 42903 not found or unavailable' in comment
+
+
 def mock_youtube_build(monkeypatch, response=None, exception=None):
     """Patch googleapiclient discovery build with a fake YouTube service."""
     class Request: