feat(issues): add rejection count badge (#6735)

Author: ReenigneArcher

src/updater.py

@@ -110,8 +110,18 @@
 JSON_EXTENSION = '.json'
 PNG_CONTENT_TYPE = 'image/png'
 APPROVE_THEME_LABEL = 'approve-theme'
-CONTRIBUTION_BADGE_LABEL = 'contributions'
-CONTRIBUTION_BADGE_STYLE = 'for-the-badge'
+ISSUE_AUTHOR_BADGE_STYLE = 'for-the-badge'
+ISSUE_AUTHOR_BADGES = {
+    'contributions': {
+        'label': 'contributions',
+        'query_filters': (f'label:{APPROVE_THEME_LABEL}',),
+    },
+    'rejections': {
+        'label': 'rejections',
+        'query_filters': ('reason:not-planned',),
+        'color': 'red',
+    },
+}
 DEFAULT_GITHUB_REPOSITORY = 'LizardByte/ThemerrDB'
 REPLACEMENT_REQUEST_OPTION = 'This is a replacement request. If checked, please provide a reason below.'
 SAME_YOUTUBE_URL_CLOSE_MESSAGE = 'The YouTube url provided is the same as the current one.'
@@ -1053,11 +1063,15 @@ def _load_existing_item_data(item_file: str) -> dict:
         return json.load(fp=og_f)
 
 
-def _build_contribution_badge(author: Optional[str] = None, repository: Optional[str] = None) -> str:
-    """Build a contribution-count badge for the issue author.
+def _build_issue_author_badge(badge_type: str,
+                              author: Optional[str] = None,
+                              repository: Optional[str] = None) -> str:
+    """Build an author-scoped issue-count badge.
 
     Parameters
     ----------
+    badge_type : str
+        Badge config key from ISSUE_AUTHOR_BADGES.
     author : str, optional
         GitHub username to search for. Defaults to the issue author login.
     repository : str, optional
@@ -1068,19 +1082,45 @@ def _build_contribution_badge(author: Optional[str] = None, repository: Optional
     str
         Markdown badge link, or an empty string when no author is available.
     """
+    badge_config = ISSUE_AUTHOR_BADGES[badge_type]
     author = author or os.environ.get('ISSUE_AUTHOR_LOGIN', '')
     if not author:
         return ''
 
     repository = repository or os.environ.get('GITHUB_REPOSITORY', DEFAULT_GITHUB_REPOSITORY)
-    query = f'repo:{repository} is:closed label:{APPROVE_THEME_LABEL} author:{author}'
+    label = badge_config['label']
+    query = ' '.join([
+        f'repo:{repository}',
+        'is:closed',
+        *badge_config['query_filters'],
+        f'author:{author}',
+    ])
     encoded_query = quote(query, safe='')
-    badge_url = (
-        'https://img.shields.io/github/issues-search?'
-        f'query={encoded_query}&style={CONTRIBUTION_BADGE_STYLE}&label={CONTRIBUTION_BADGE_LABEL}'
-    )
+    badge_options = [
+        f'query={encoded_query}',
+        f'style={ISSUE_AUTHOR_BADGE_STYLE}',
+        f'label={label}',
+    ]
+    if badge_config.get('color'):
+        badge_options.append(f'color={badge_config["color"]}')
+
+    badge_query = '&'.join(badge_options)
+    badge_url = f'https://img.shields.io/github/issues-search?{badge_query}'
     issues_url = f'https://github.com/{repository}/issues?q={encoded_query}'
-    return f'[![{CONTRIBUTION_BADGE_LABEL}]({badge_url})]({issues_url})'
+    return f'[![{label}]({badge_url})]({issues_url})'
+
+
+def _build_issue_comment_badges(author: Optional[str] = None, repository: Optional[str] = None) -> str:
+    """Build the leading issue comment badges for an author."""
+    badges = [
+        _build_issue_author_badge(
+            badge_type=badge_type,
+            author=author,
+            repository=repository,
+        )
+        for badge_type in ISSUE_AUTHOR_BADGES
+    ]
+    return ' '.join(badge for badge in badges if badge)
 
 
 def _write_issue_comment_header() -> None:
@@ -1089,14 +1129,14 @@ def _write_issue_comment_header() -> None:
     Returns
     -------
     None
-        The comment file is initialized only when a contribution badge can be built.
+        The comment file is initialized only when author badges can be built.
     """
-    badge = _build_contribution_badge()
-    if not badge:
+    badges = _build_issue_comment_badges()
+    if not badges:
         return
 
     with open("comment.md", "w", encoding='utf-8') as comment_f:
-        comment_f.write(f'{badge}\n\n')
+        comment_f.write(f'{badges}\n\n')
 
 
 def _html_line_breaks(value: str) -> str:

tests/unit/test_issue_updater.py

@@ -277,14 +277,15 @@ def test_load_existing_item_data_writes_duplicate_marker(tmp_path, monkeypatch):
     assert (tmp_path / 'duplicate.md').read_text(encoding='utf-8') == 'This item already exists in the database.'
 
 
-def test_build_contribution_badge_links_to_approved_author_issues():
+def test_build_issue_author_badge_links_to_approved_author_issues():
     """Test contribution badge generation for an issue author."""
     encoded_query = (
         'repo%3ALizardByte%2FThemerrDB%20is%3Aclosed%20'
         'label%3Aapprove-theme%20author%3Aoctocat'
     )
 
-    badge = updater._build_contribution_badge(
+    badge = updater._build_issue_author_badge(
+        badge_type='contributions',
         author='octocat',
         repository='LizardByte/ThemerrDB',
     )
@@ -296,6 +297,26 @@ def test_build_contribution_badge_links_to_approved_author_issues():
     )
 
 
+def test_build_issue_author_badge_links_to_rejected_author_issues():
+    """Test rejection badge generation for an issue author."""
+    encoded_query = (
+        'repo%3ALizardByte%2FThemerrDB%20is%3Aclosed%20'
+        'reason%3Anot-planned%20author%3Aoctocat'
+    )
+
+    badge = updater._build_issue_author_badge(
+        badge_type='rejections',
+        author='octocat',
+        repository='LizardByte/ThemerrDB',
+    )
+
+    assert badge == (
+        '[![rejections](https://img.shields.io/github/issues-search?'
+        f'query={encoded_query}&style=for-the-badge&label=rejections&color=red)]'
+        f'(https://github.com/LizardByte/ThemerrDB/issues?q={encoded_query})'
+    )
+
+
 def test_write_issue_comment_header_skips_without_author(tmp_path, monkeypatch):
     """Test issue comment header is omitted when the author login is unavailable."""
     monkeypatch.chdir(tmp_path)
@@ -1266,8 +1287,8 @@ def test_process_issue_update_reports_unsupported_database_url(tmp_path, monkeyp
     assert exceptions.count('Exception Occurred') == 6
 
 
-def test_process_issue_update_writes_contribution_badge_first(tmp_path, monkeypatch, youtube_url):
-    """Test issue update comments start with the contributor badge."""
+def test_process_issue_update_writes_author_badges_first(tmp_path, monkeypatch, youtube_url):
+    """Test issue update comments start with the author badges."""
     monkeypatch.chdir(tmp_path)
     monkeypatch.setenv('GITHUB_REPOSITORY', 'LizardByte/ThemerrDB')
     monkeypatch.setenv('ISSUE_AUTHOR_LOGIN', 'octocat')
@@ -1277,13 +1298,20 @@ def test_process_issue_update_writes_contribution_badge_first(tmp_path, monkeypa
         youtube_url=youtube_url,
     )
 
-    expected_badge = updater._build_contribution_badge(
+    expected_contribution_badge = updater._build_issue_author_badge(
+        badge_type='contributions',
+        author='octocat',
+        repository='LizardByte/ThemerrDB',
+    )
+    expected_rejection_badge = updater._build_issue_author_badge(
+        badge_type='rejections',
         author='octocat',
         repository='LizardByte/ThemerrDB',
     )
+    expected_badges = f'{expected_contribution_badge} {expected_rejection_badge}'
     comment = (tmp_path / 'comment.md').read_text(encoding='utf-8')
     assert result is False
-    assert comment.startswith(f'{expected_badge}\n\n')
+    assert comment.startswith(f'{expected_badges}\n\n')
     assert 'Exception Occurred' in comment