Skip to content

fix: Use auto-approved users allowlist for queue eligibility#7156

Merged
ReenigneArcher merged 1 commit into
masterfrom
fix/auto-approve
Jun 12, 2026
Merged

fix: Use auto-approved users allowlist for queue eligibility#7156
ReenigneArcher merged 1 commit into
masterfrom
fix/auto-approve

Conversation

@ReenigneArcher

@ReenigneArcher ReenigneArcher commented Jun 12, 2026

Copy link
Copy Markdown
Member

Description

Refactor queue eligibility to use an allowlist of auto-approved GitHub user IDs instead of per-category contribution thresholds and URL-based category resolution. Add auto_approved_users.json and implement normalize_user_id and load_auto_approved_user_ids; simplify evaluate_queue_eligibility to check the allowlist and emit user_id in outputs. Update CLI args, GitHub Actions workflow invocation, and tests to match the new behavior and remove the old contributors/threshold logic.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

Refactor queue eligibility to use an allowlist of auto-approved GitHub user IDs instead of per-category contribution thresholds and URL-based category resolution. Add auto_approved_users.json and implement normalize_user_id and load_auto_approved_user_ids; simplify evaluate_queue_eligibility to check the allowlist and emit user_id in outputs. Update CLI args, GitHub Actions workflow invocation, and tests to match the new behavior and remove the old contributors/threshold logic.
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (35c2d3d) to head (78952c9).
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #7156   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1433      1402   -31     
  Branches        85        85           
=========================================
- Hits          1433      1402   -31     
Files with missing lines Coverage Δ
src/queue_eligibility.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35c2d3d...78952c9. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ReenigneArcher
ReenigneArcher merged commit e4a7a01 into master Jun 12, 2026
17 checks passed
@ReenigneArcher
ReenigneArcher deleted the fix/auto-approve branch June 12, 2026 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant