feat: allow external approvers and new comment commands#7514
Merged
Conversation
Extend the update-labels workflow and script so approve-theme can trigger auto-close behavior. When auto-close is active, the approval label is removed and the workflow skips the approval push/comment steps. Added coverage for the new auto-close path.
Introduce `@LizardByte-bot check` as a recognized moderator command in the comment script. The command now re-triggers validation by removing and re-adding the `request-theme` label (with a short delay), and is wired into command dispatch/export paths. Documentation was updated to point approvers to the new command, and tests were expanded to cover permissions and end-to-end check command behavior.
Reorganize documentation by moving bot_commands.md to docs/botCommands.md. Update all references in workflows and documentation to point to the new location. Consolidate bot command references in approverGuide.md to reduce duplication and point to the centralized Bot Commands reference.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7514 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 13 13
Lines 1414 1516 +102
Branches 85 109 +24
==========================================
+ Hits 1414 1516 +102
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Guard normalizeUserId and normalizeCommandName against non-primitive inputs (objects, null, undefined) to prevent unintended '[object Object]' strings. Introduce NORMALIZABLE_PRIMITIVE_TYPES set and export normalizeCommandName for testing.
Export the `getActor` function from comment-command.js and add tests covering all supported actor sources: context, comment payload, environment variable, and fallback to empty string.
Include the youtube_theme_url in issue comment tables and generated JSON files. This ensures approvers use the canonical URL from the LizardByte-Bot comment (as documented in the updated guidelines) rather than the original issue body, maintaining consistency across all generated database files.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage