Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions auto_approved_users.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,12 @@
],
"user_id": 88998541,
"username": "jjnether"
},
{
"commands": [
"*"
],
"user_id": 170429187,
"username": "weatherluvr"
}
]
27 changes: 24 additions & 3 deletions tests/unit/test_queue_eligibility.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,33 @@ def test_load_auto_approved_user_ids_loads_user_ids(tmp_path):
assert auto_approved_user_ids == frozenset({'42013603', '88998541'})


def test_root_auto_approved_users_file_contains_expected_user_ids():
def test_root_auto_approved_users_file_is_valid_allowlist():
auto_approved_users_file = REPOSITORY_ROOT / queue_eligibility.AUTO_APPROVED_USERS_FILE
auto_approved_users = json.loads(auto_approved_users_file.read_text(encoding='utf-8'))

assert isinstance(auto_approved_users, list)
assert auto_approved_users

expected_user_ids = set()
for auto_approved_user in auto_approved_users:
assert isinstance(auto_approved_user, dict)

username = auto_approved_user.get('username')
assert isinstance(username, str)
assert username.strip()

user_id = queue_eligibility.normalize_user_id(auto_approved_user.get('user_id'))
assert user_id
assert user_id.isdecimal()
assert user_id not in expected_user_ids
expected_user_ids.add(user_id)

auto_approved_user_ids = queue_eligibility.load_auto_approved_user_ids(
auto_approved_users_file=REPOSITORY_ROOT / queue_eligibility.AUTO_APPROVED_USERS_FILE,
auto_approved_users_file=auto_approved_users_file,
base_dir=REPOSITORY_ROOT,
)

assert auto_approved_user_ids == frozenset({'42013603', '88998541', '30657709'})
assert auto_approved_user_ids == frozenset(expected_user_ids)


def test_load_auto_approved_user_ids_ignores_malformed_entries(tmp_path):
Expand Down