Add Sonar config, remove NOSONAR thread tags

Add sonar-project.properties to set the Sonar project key and force C++17 for analysis. Remove inline NOSONAR suppressions on std::thread lambda usages in src/tray_qt.cpp and tests/unit/test_tray.cpp; the thread behavior is unchanged, only the comment-based suppressions were removed.

Author: ReenigneArcher

sonar-project.properties

@@ -0,0 +1,3 @@
+# Sonar project analysis properties overrides
+sonar.projectKey=LizardByte_tray
+sonar.cfamily.reportingCppStandardOverride=c++17

src/tray_qt.cpp

@@ -100,7 +100,7 @@ namespace tray_qt {
    * @param timeout optional timeout for async run in ms
    */
   void async_tray_notification_acknowledge_(const std::shared_ptr<notification_data> &notification, int timeout = 1000) {
-    std::thread t([notification]() {  // NOSONAR(cpp:S6168) - jthread is only available on C++20 onwards
+    std::thread t([notification]() {
       std::scoped_lock lock(notification->mutex);
       if (notification->shown && notification->obj != nullptr && NOTIFY_IS_NOTIFICATION(notification->obj) && notify_notification_close(notification->obj, nullptr)) {
         notification->shown = false;
@@ -126,7 +126,7 @@ namespace tray_qt {
    * @param timeout optional timeout for async run in ms
    */
   void async_tray_notification_show_(const std::shared_ptr<notification_data> &notification, int timeout = 1000) {
-    std::thread t([notification]() {  // NOSONAR(cpp:S6168) - jthread is only available on C++20 onwards
+    std::thread t([notification]() {
       std::scoped_lock lock(notification->mutex);
       if (notification->obj != nullptr && NOTIFY_IS_NOTIFICATION(notification->obj) && notify_notification_show(notification->obj, nullptr)) {
         notification->shown = true;

tests/unit/test_tray.cpp

@@ -86,7 +86,7 @@ class TrayTest: public BaseTest {  // NOSONAR(cpp:S3656) - fixture members must
   // Capture a screenshot while the tray menu is open, then dismiss and exit.
   void captureMenuStateAndExit(const char *screenshotName) {
     std::atomic_bool exitRequested {false};
-    std::thread capture_thread([this, screenshotName, &exitRequested]() {  // NOSONAR(cpp:S6168) - std::jthread is unavailable on AppleClang 17/libc++ used in CI
+    std::thread capture_thread([this, screenshotName, &exitRequested]() {
       EXPECT_TRUE(captureScreenshot(screenshotName));
       closeMenu();
       exitRequested.store(true, std::memory_order_release);