Add isGitHubActions helper and use in tests

Introduce a cross-platform isGitHubActions() helper (uses _dupenv_s on Windows and getenv elsewhere) and declare it in tests/utils.h. Replace direct getenv usage in tests/unit/test_tray.cpp with the new helper and guard the Windows notification timeout to avoid unnecessary sleeps outside GitHub Actions. Also remove an unused <cstdlib> include.

Author: ReenigneArcher

tests/unit/test_tray.cpp

@@ -5,7 +5,6 @@
 #include <array>
 #include <atomic>
 #include <chrono>
-#include <cstdlib>
 #include <ostream>
 #include <string>
 #include <thread>
@@ -251,7 +250,7 @@ class TrayTest: public BaseTest {  // NOSONAR(cpp:S3656) - fixture members must
   void WaitForNotificationReady() {
     WaitForTrayReady();
 #if defined(_WIN32)
-    if (std::getenv("GITHUB_ACTIONS") != nullptr) {
+    if (isGitHubActions()) {
       for (int i = 0; i < 40; i++) {
         tray_loop(0);
         std::this_thread::sleep_for(std::chrono::milliseconds(50));

tests/utils.cpp

@@ -41,6 +41,18 @@ int setEnv(const std::string &name, const std::string &value) {
 #endif
 }
 
+bool isGitHubActions() {
+#ifdef _WIN32
+  char *value = nullptr;
+  size_t value_size = 0;
+  const bool result = _dupenv_s(&value, &value_size, "GITHUB_ACTIONS") == 0 && value != nullptr && value_size > 0;
+  std::free(value);
+  return result;
+#else
+  return std::getenv("GITHUB_ACTIONS") != nullptr;
+#endif
+}
+
 void dismissNativeNotifications() {
 #ifdef __linux__
   closeFreedesktopNotifications();
@@ -51,6 +63,9 @@ void dismissNativeNotifications() {
 
 void waitForNativeNotificationTimeout() {
 #ifdef _WIN32
+  if (!isGitHubActions()) {
+    return;
+  }
   constexpr auto wait_timeout = std::chrono::milliseconds(6000);
   std::this_thread::sleep_for(wait_timeout);
 #elif defined(__linux__)

tests/utils.h

@@ -9,6 +9,8 @@
 
 int setEnv(const std::string &name, const std::string &value);
 
+bool isGitHubActions();
+
 void dismissNativeNotifications();
 
 void waitForNativeNotificationTimeout();