fix(linux): run notify and acknowledge in async in event loop

Author: Kishi85

src/tray_linux.cpp

@@ -57,16 +57,26 @@ namespace tray_linux {
   /**
    * @brief Acknowledge/click current notification
    * @param run_callback - Run notification callback when acknowledging
+   * @param async - Acknowledge asynchronously in the event loop (default: true)
    */
-  void acknowledge_notification(const bool run_callback = false) {
+  void acknowledge_notification(const bool run_callback = false, const bool async = true) {
     if (notify_is_initted()) {
       std::scoped_lock lock(notification_mutex);
       if (notification_current != nullptr && NOTIFY_IS_NOTIFICATION(notification_current)) {
         if (run_callback && notification_current_callback != nullptr) {
           notification_current_callback();
         }
-        notify_notification_close(notification_current, nullptr);
-        g_object_unref(G_OBJECT(notification_current));
+        GSourceFunc f = [](gpointer data) -> gboolean {
+          auto n = static_cast<NotifyNotification *>(data);
+          notify_notification_close(n, nullptr);
+          g_object_unref(G_OBJECT(n));
+          return false;  // Run once then remove from queue
+        };
+        if (async) {
+          g_idle_add(f, notification_current);
+        } else {
+          f(notification_current);
+        }
         notification_current = nullptr;
         notification_current_callback = nullptr;
       }
@@ -75,6 +85,36 @@ namespace tray_linux {
     }
   }
 
+  /**
+   * @brief Show tray notification via desktop-independent interface async via g_idle_add
+   * @param data Tray structure containing notification information as a gpointer
+   * @return false to run just once
+   */
+  gboolean async_notify_(const gpointer data) {
+    auto tray = static_cast<struct tray *>(data);
+    if (notification_current != nullptr) {
+      acknowledge_notification(false, false);
+    }
+    std::scoped_lock lock(notification_mutex);
+    std::filesystem::path notification_icon = tray->notification_icon != nullptr ? tray->notification_icon : tray->icon;
+    if (std::filesystem::exists(notification_icon)) {
+      // Use absolute path for filesystem icon files, not a relative one
+      notification_icon = std::filesystem::absolute(notification_icon);
+    }
+    notification_current = notify_notification_new(tray->notification_title, tray->notification_text, notification_icon.c_str());
+    if (notification_current != nullptr && NOTIFY_IS_NOTIFICATION(notification_current)) {
+      if (tray->notification_cb != nullptr) {
+        notification_current_callback = tray->notification_cb;
+        notify_notification_add_action(notification_current, "default", "Default", NOTIFY_ACTION_CALLBACK(tray->notification_cb), nullptr, nullptr);
+      }
+      // Fallback to QtTrayMenu notification if notificaton_show fails
+      if (!notify_notification_show(notification_current, nullptr) && qt_tray_menu != nullptr && QtTrayMenu::supportsMessages()) {
+        qt_tray_menu->showMessage(tray->notification_title, tray->notification_text, tray->notification_icon, tray->notification_cb);
+      }
+    }
+    return false;  // Run once then remove from queue
+  }
+
   /**
    * @brief Show tray notification via desktop-independent interface
    * @param tray Tray structure containing notification information
@@ -85,25 +125,10 @@ namespace tray_linux {
     }
     // Try to notify using libnotify
     if (notify_is_initted()) {
-      if (notification_current != nullptr) {
-        acknowledge_notification();
-      }
-      std::scoped_lock lock(notification_mutex);
-      std::filesystem::path notification_icon = tray->notification_icon != nullptr ? tray->notification_icon : tray->icon;
-      if (std::filesystem::exists(notification_icon)) {
-        // Use absolute path for filesystem icon files, not a relative one
-        notification_icon = std::filesystem::absolute(notification_icon);
-      }
-      notification_current = notify_notification_new(tray->notification_title, tray->notification_text, notification_icon.c_str());
-      if (notification_current != nullptr && NOTIFY_IS_NOTIFICATION(notification_current)) {
-        if (tray->notification_cb != nullptr) {
-          notification_current_callback = tray->notification_cb;
-          notify_notification_add_action(notification_current, "default", "Default", NOTIFY_ACTION_CALLBACK(tray->notification_cb), nullptr, nullptr);
-        }
-        if (notify_notification_show(notification_current, nullptr)) {
-          return;
-        }
-      }
+      // Fix tray icon path
+
+      // Show tray icon aync via event loop
+      g_idle_add(async_notify_, tray);
     }
     // Fallback to QtTrayMenu notification
     if (qt_tray_menu != nullptr && QtTrayMenu::supportsMessages()) {