From 6ca0079cca6c008ecbac45506303bb12c09ad6e2 Mon Sep 17 00:00:00 2001
From: ReenigneArcher <42013603+ReenigneArcher@users.noreply.github.com>
Date: Mon, 11 May 2026 21:30:11 -0400
Subject: [PATCH] ci: consolidate macOS deps, bump Python to 3.14

Refactor macOS dependency installation to use a dependencies array when calling brew install. Update setup-python to request Python 3.14 instead of 3.11. Expand the Codecov upload condition to run on test success or failure (so coverage artifacts are uploaded even when tests fail).
---
 .github/workflows/ci.yml | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index f29cfc7..f372c35 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -107,14 +107,15 @@ jobs:
       - name: Setup Dependencies macOS
         if: runner.os == 'macOS'
         run: |
-          brew update
-          brew install \
-            cmake \
-            doxygen \
-            graphviz \
-            imagemagick \
-            ninja \
-            node
+          dependencies=(
+            "cmake"
+            "doxygen"
+            "graphviz"
+            "imagemagick"
+            "ninja"
+            "node"
+          )
+          brew install "${dependencies[@]}"
 
       - name: Fix macOS screen recording permissions
         if: runner.os == 'macOS'
@@ -171,7 +172,7 @@ jobs:
         id: setup-python
         uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405  # v6.2.0
         with:
-          python-version: '3.11'
+          python-version: '3.14'
 
       - name: Python Path
         id: python-path
@@ -292,7 +293,7 @@ jobs:
         # any except canceled or skipped
         if: >-
           always() &&
-          steps.test_report.outcome == 'success' &&
+          (steps.test.outcome == 'success' || steps.test.outcome == 'failure') &&
           startsWith(github.repository, 'LizardByte/')
         uses: codecov/codecov-action@57e3a136b779b570ffcdbf80b3bdc90e7fab3de2  # v6.0.0
         with: