Skip to content

Fix: Handle grayscale image matching with RGB templates matching #5700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ycnliu wants to merge 4 commits into from
+15 −2
Closed

Fix: Handle grayscale image matching with RGB templates matching #5700

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4dd4be
Merge pull request #5677 from LmeSzinc/dev
LmeSzinc May 20, 2026
5efbd5e
Merge pull request #5683 from LmeSzinc/dev
LmeSzinc May 21, 2026
7e6fa47
Merge pull request #5691 from LmeSzinc/dev
LmeSzinc May 29, 2026
c5ac323
Fix: Handle grayscale image matching with RGB templates
Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions module/base/template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,13 +262,26 @@ def match_multi(self, image, scaling=1.0, similarity=0.85, threshold=3, name=Non
raw = image
if self.is_gif:
result = []
# Check if image is grayscale
is_gray = len(image.shape) == 2
for template in self.image:
res = cv2.matchTemplate(image, template, cv2.TM_CCOEFF_NORMED)
# Convert template to grayscale if image is grayscale
if is_gray and len(template.shape) == 3:
template_gray = cv2.cvtColor(template, cv2.COLOR_BGR2GRAY)
res = cv2.matchTemplate(image, template_gray, cv2.TM_CCOEFF_NORMED)
else:
res = cv2.matchTemplate(image, template, cv2.TM_CCOEFF_NORMED)
res = np.array(np.where(res > similarity)).T[:, ::-1].tolist()
result += res
result = np.array(result)
else:
result = cv2.matchTemplate(image, self.image, cv2.TM_CCOEFF_NORMED)
# Check if image is grayscale and template is RGB
is_gray = len(image.shape) == 2
if is_gray and len(self.image.shape) == 3:
template_gray = cv2.cvtColor(self.image, cv2.COLOR_BGR2GRAY)
result = cv2.matchTemplate(image, template_gray, cv2.TM_CCOEFF_NORMED)
else:
result = cv2.matchTemplate(image, self.image, cv2.TM_CCOEFF_NORMED)
result = np.array(np.where(result > similarity)).T[:, ::-1]

# result: np.array([[x0, y0], [x1, y1], ...)
Expand Down