Fix lint_and_format.sh compatibility issues for MacOS (UBC-Thunderbots#3679)

* Remove unused chmod

* Upgrade ansible-lint version

* Link clang-format in mac setup script

* Fix commands in lint_and_format for compatibility

Author: nycrat

environment_setup/macos_requirements.txt

@@ -1,4 +1,4 @@
-ansible-lint==24.12.2
+ansible-lint==26.4.0
 pyqtgraph==0.13.7
 thefuzz==0.19.0
 iterfzf==0.5.0.20.0
@@ -10,4 +10,3 @@ pyqt-toast-notification==1.3.2
 grpcio-tools==1.71.0
 platformio==6.1.18
 pyqt6==6.9.1
-

environment_setup/setup_software_mac.sh

@@ -51,7 +51,6 @@ print_status_msg "Setting Up Python Environment"
 
 # Create virtual environment
 sudo python3.12 -m venv /opt/tbotspython
-chmod
 source /opt/tbotspython/bin/activate
 
 # Install Python dependencies
@@ -69,6 +68,10 @@ sudo chmod +x "$CURR_DIR/../src/software/autoref/run_autoref.sh"
 sudo cp "$CURR_DIR/../src/software/autoref/DIV_B.txt" "/opt/tbotspython/autoReferee/config/geometry/DIV_B.txt"
 print_status_msg "Finished setting up AutoRef"
 
+print_status_msg "Install clang-format"
+install_clang_format $sys
+print_status_msg "Done installing clang-format"
+
 print_status_msg "Setting up cross compiler for robot software"
 install_cross_compiler $sys
 print_status_msg "Done setting up cross compiler for robot software"

environment_setup/ubuntu24_requirements.txt

@@ -1,4 +1,4 @@
-ansible-lint==25.8.1
+ansible-lint==26.4.0
 pyqtgraph==0.13.7
 thefuzz==0.19.0
 iterfzf==0.5.0.20.0

environment_setup/util.sh

@@ -29,7 +29,11 @@ install_bazel() {
 }
 
 install_clang_format() {
-    ln -s /usr/bin/clang-format-14 /opt/tbotspython/bin/clang-format
+    if is_darwin $1; then
+        ln -s /opt/homebrew/bin/clang-format /opt/tbotspython/bin/clang-format
+    else
+        ln -s /usr/bin/clang-format-14 /opt/tbotspython/bin/clang-format
+    fi
 }
 
 install_cross_compiler() {

scripts/lint_and_format.sh

@@ -25,7 +25,7 @@ function run_clang_format () {
     cd $BAZEL_ROOT_DIR
 
     # Generate extension string
-    # Formatted as -iname *.EXTENSION -o
+    # Formatted as -name *.EXTENSION -o
     EXTENSION_STRING=""
     for value in "${CLANG_FORMAT_EXTENSIONS[@]}"
     do
@@ -35,8 +35,8 @@ function run_clang_format () {
     # Find all the files that we want to format, and pass them to
     # clang-format as arguments
     # We remove the last -o flag from the extension string
-    find $CURR_DIR/../src/ ${EXTENSION_STRING::-2}  \
-        | xargs -I{} -n1000 $CLANG_BIN -i -style=file:$CURR_DIR/../.clang-format
+    find $CURR_DIR/../src ${EXTENSION_STRING% -o} \
+        | xargs $CLANG_BIN -i -style=file:$CURR_DIR/../.clang-format
 
     if [[ "$?" != 0 ]]; then
         printf "\n***Failed to run clang-format over all files!***\n\n"