Remove all instances of MessageToDict (UBC-Thunderbots#3405)

* Removed all instances of messagetodict

* [pre-commit.ci lite] apply automatic fixes

* Changes made before updated branch

* applied suggestions

* [pre-commit.ci lite] apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: williamckha <williamha@outlook.com>

Author: 3 people

src/software/thunderscope/common/proto_parameter_tree_util.py

@@ -1,7 +1,7 @@
 from pyqtgraph.Qt.QtWidgets import *
 from pyqtgraph import parametertree
-from google.protobuf.json_format import MessageToDict
 from thefuzz import fuzz
+from proto.import_all_protos import *
 import netifaces
 
 
@@ -33,10 +33,13 @@ def __create_int_parameter_writable(key, value, descriptor):
     """
     # Extract the options from the descriptor, and store it
     # in the dictionary.
-    options = MessageToDict(descriptor.GetOptions(), preserving_proto_field_name=True)
+    options = descriptor.GetOptions()
 
     try:
-        min_max = options["[TbotsProto.bounds]"]
+        minimum, maximum = (
+            options.Extensions[bounds].min_double_value,
+            options.Extensions[bounds].max_double_value,
+        )
     except KeyError:
         raise KeyError("{} missing ParameterRangeOptions".format(key))
 
@@ -45,7 +48,7 @@ def __create_int_parameter_writable(key, value, descriptor):
         "type": "int",
         "value": value,
         "default": value,
-        "limits": (int(min_max["min_int_value"]), int(min_max["max_int_value"])),
+        "limits": (int(minimum), int(maximum)),
         "step": 1,
     }
 
@@ -61,10 +64,13 @@ def __create_double_parameter_writable(key, value, descriptor):
     """
     # Extract the options from the descriptor, and store it
     # in the dictionary.
-    options = MessageToDict(descriptor.GetOptions(), preserving_proto_field_name=True)
+    options = descriptor.GetOptions()
 
     try:
-        min_max = options["[TbotsProto.bounds]"]
+        minimum, maximum = (
+            options.Extensions[bounds].min_double_value,
+            options.Extensions[bounds].max_double_value,
+        )
     except KeyError:
         raise KeyError("{} missing ParameterRangeOptions".format(key))
 
@@ -74,8 +80,8 @@ def __create_double_parameter_writable(key, value, descriptor):
         "value": value,
         "default": value,
         "limits": (
-            min_max["min_double_value"],
-            min_max["max_double_value"],
+            minimum,
+            maximum,
         ),
         "step": 0.01,
     }

src/software/thunderscope/gl/layers/gl_tactic_layer.py

@@ -3,8 +3,6 @@
 
 import textwrap
 
-from google.protobuf.json_format import MessageToDict
-
 from proto.import_all_protos import *
 from software.py_constants import *
 from software.thunderscope.constants import (
@@ -42,20 +40,17 @@ def __init__(self, name: str, buffer_size: int = 5) -> None:
     def refresh_graphics(self) -> None:
         """Update graphics in this layer"""
         self.cached_world = self.world_buffer.get(block=False)
-        play_info = self.play_info_buffer.get(block=False)
-        play_info_dict = MessageToDict(play_info)
+        play_info = self.play_info_buffer.get(block=False).bounds()
 
-        self.__update_tactic_name_graphics(
-            self.cached_world.friendly_team, play_info_dict
-        )
+        self.__update_tactic_name_graphics(self.cached_world.friendly_team, play_info)
 
-    def __update_tactic_name_graphics(self, team: Team, play_info_dict) -> None:
+    def __update_tactic_name_graphics(self, team: Team, play_info) -> None:
         """Update the GLGraphicsItems that display tactic data
 
         :param team: The team proto
-        :param play_info_dict: The dictionary containing play/tactic info
+        :param play_info: The dictionary containing play/tactic info
         """
-        tactic_assignments = play_info_dict["robotTacticAssignment"]
+        tactic_assignments = play_info.robot_tactic_assignment()
 
         # Ensure we have the same number of graphics as robots
         self.tactic_fsm_info_graphics.resize(

src/software/thunderscope/play/playinfo_widget.py

@@ -1,5 +1,4 @@
 from proto.play_info_msg_pb2 import PlayInfo
-from google.protobuf.json_format import MessageToDict
 from pyqtgraph.Qt.QtWidgets import *
 from proto.import_all_protos import *
 from software.thunderscope.common.common_widgets import set_table_data
@@ -43,36 +42,32 @@ def refresh(self) -> None:
 
         self.last_playinfo = playinfo
 
-        play_info_dict = MessageToDict(playinfo)
-
         robot_ids = []
         tactic_fsm_states = []
         tactic_names = []
         play_name = []
 
-        if "robotTacticAssignment" not in play_info_dict:
+        if not playinfo.robot_tactic_assignment:
             return
 
         num_rows = max(
-            len(play_info_dict["robotTacticAssignment"]),
-            len(play_info_dict["play"]["playState"]),
+            len(playinfo.robot_tactic_assignment),
+            len(playinfo.play.play_state),
         )
 
         # setting table size dynamically
         self.play_table.setRowCount(num_rows)
 
-        for state in play_info_dict["play"]["playState"]:
+        for state in playinfo.play.play_state:
             play_name.append(state)
 
-        for robot_id in sorted(play_info_dict["robotTacticAssignment"]):
+        for robot_id in sorted(playinfo.robot_tactic_assignment):
             robot_ids.append(robot_id)
             tactic_fsm_states.append(
-                play_info_dict["robotTacticAssignment"][robot_id]["tacticFsmState"]
-            )
-            tactic_names.append(
-                play_info_dict["robotTacticAssignment"][robot_id]["tacticName"]
+                playinfo.robot_tactic_assignment[robot_id].tactic_fsm_state
             )
 
+            tactic_names.append(playinfo.robot_tactic_assignment[robot_id].tactic_name)
         set_table_data(
             {
                 "Play": play_name,

src/software/thunderscope/play/refereeinfo_widget.py

@@ -1,9 +1,9 @@
-from google.protobuf.json_format import MessageToDict
 from pyqtgraph.Qt.QtWidgets import *
 from proto.import_all_protos import *
 from software.py_constants import SECONDS_PER_MICROSECOND, SECONDS_PER_MINUTE
 from software.thunderscope.common.common_widgets import set_table_data
 from software.thunderscope.thread_safe_buffer import ThreadSafeBuffer
+from google.protobuf.json_format import MessageToDict
 
 
 class RefereeInfoWidget(QWidget):