Enable pedantic mode for Clippy

Author: BrenekH

src/lib.rs

@@ -1,5 +1,7 @@
 //! Create markdown tables for [Locatarr](https://github.com/Locatarr/Locatarr)
 
+#![warn(clippy::pedantic)]
+
 use itertools::Itertools;
 
 use models::{Application, Applications};
@@ -10,26 +12,27 @@ pub mod models;
 ///
 /// The resulting table is the minimum viable table and is not formatted in any way.
 pub fn generate_md_table(apps: &Applications) -> String {
-    "| **Application** | **Description** | **Github** | **Reddit** |\n|-|-|-|-|\n".to_owned() +
-    &apps.applications
-        .iter()
-        .sorted()
-        .map(generate_md_row)
-        .join("\n")
+    "| **Application** | **Description** | **Github** | **Reddit** |\n|-|-|-|-|\n".to_owned()
+        + &apps
+            .applications
+            .iter()
+            .sorted()
+            .map(generate_md_row)
+            .join("\n")
 }
 
 /// Create one markdown table row from a single [Application]
 ///
-/// Copies the [Application::name] and [Application::description] fields in, and transforms [Application::github_slug] and
-/// [Application::subreddit] into proper markdown links.
+/// Copies the [`Application::name`] and [`Application::description`] fields in, and transforms [`Application::github_slug`] and
+/// [`Application::subreddit`] into proper markdown links.
 fn generate_md_row(app: &Application) -> String {
     let github_link = match &app.github_slug {
-        Some(slug) => format!("[{}](https://github.com/{})", slug, slug),
+        Some(slug) => format!("[{slug}](https://github.com/{slug})"),
         None => String::new(),
     };
 
     let subreddit_link = match &app.subreddit {
-        Some(sub) => format!("[{}](https://reddit.com/{})", sub, sub),
+        Some(sub) => format!("[{sub}](https://reddit.com/{sub})"),
         None => String::new(),
     };
 

src/main.rs

@@ -1,3 +1,5 @@
+#![warn(clippy::pedantic)]
+
 use clap::Parser;
 use std::{path::PathBuf, process::ExitCode};
 
@@ -51,5 +53,5 @@ fn main() -> ExitCode {
 
     println!("{markdown_table}");
 
-    return 0.into();
+    0.into()
 }

src/models.rs

@@ -1,5 +1,7 @@
 //! The models sub-crate holds all of the general purpose structs used throughout the library.
 
+use std::borrow::ToOwned;
+
 use serde::{Deserialize, Serialize};
 
 /// Struct for the collection of a list of applications so that [serde] can deserialize a JSON
@@ -25,6 +27,7 @@ pub struct Application {
 impl Application {
     /// Create a new [Application] from various string references instead of owned strings
     #[allow(dead_code)] // Because I like this function here, but we aren't currently using it anywhere
+    #[must_use]
     pub fn new_from_strs(
         name: &str,
         description: &str,
@@ -34,8 +37,8 @@ impl Application {
         Self {
             name: name.to_owned(),
             description: description.to_owned(),
-            github_slug: github_slug.map(|s| s.to_owned()),
-            subreddit: subreddit.map(|s| s.to_owned()),
+            github_slug: github_slug.map(ToOwned::to_owned),
+            subreddit: subreddit.map(ToOwned::to_owned),
         }
     }
 }