Skip to content

update macro events real-time#294

Open
hanmindev wants to merge 15 commits intodevfrom
macro-event
Open

update macro events real-time#294
hanmindev wants to merge 15 commits intodevfrom
macro-event

Conversation

@hanmindev
Copy link
Copy Markdown
Contributor

@hanmindev hanmindev commented Jul 12, 2023

Blocked by #318

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 12, 2023

Deploy Preview for lodestone-dashboard ready!

Name Link
🔨 Latest commit 2381c17
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-dashboard/deploys/64efef2beedd800008fc269a
😎 Deploy Preview https://deploy-preview-294--lodestone-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hanmindev hanmindev changed the base branch from main to dev July 12, 2023 05:20
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 12, 2023

Deploy Preview for lodestone-storybook ready!

Name Link
🔨 Latest commit 2381c17
🔍 Latest deploy log https://app.netlify.com/sites/lodestone-storybook/deploys/64efef2bcf79e2000813700c
😎 Deploy Preview https://deploy-preview-294--lodestone-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment thread src/pages/macros.tsx Outdated
@Ynng
Copy link
Copy Markdown
Member

Ynng commented Jul 19, 2023

It would be nice if you can get your auto formatting to follow our https://github.com/Lodestone-Team/lodestone/blob/main/dashboard/prettier.config.js
The formatting changes is making the git diff quite hard to read

Comment thread dashboard/src/data/EventStream.ts Outdated
Comment thread dashboard/src/data/EventStream.ts Outdated
Comment thread dashboard/src/data/EventStream.ts
Comment thread dashboard/src/data/EventStream.ts Outdated
Comment thread dashboard/src/data/EventStream.ts Outdated
Comment thread dashboard/src/data/EventStream.ts Outdated
Comment thread dashboard/src/pages/macros.tsx
Comment thread dashboard/src/pages/macros.tsx Outdated
Comment thread dashboard/src/pages/macros.tsx Outdated
@Ynng Ynng linked an issue Jul 24, 2023 that may be closed by this pull request
@Ynng
Copy link
Copy Markdown
Member

Ynng commented Jul 27, 2023

This is blocked by #318

Comment thread dashboard/src/pages/macros.tsx Outdated
Comment thread dashboard/src/pages/macros.tsx
Comment thread dashboard/src/pages/macros.tsx
Comment thread dashboard/src/pages/macros.tsx
@hanmindev hanmindev requested a review from Ynng August 1, 2023 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hook up macro event to macro page

3 participants