Add Multi-Folder Backups#428
Draft
musselmandev wants to merge 2 commits into
Draft
Conversation
musselmandev
marked this pull request as draft
November 5, 2024 22:30
✅ Deploy Preview for lodestone-dashboard canceled.
|
✅ Deploy Preview for lodestone-storybook canceled.
|
musselmandev
commented
Nov 6, 2024
Comment on lines
+61
to
69
| if (config.compressBackup) { | ||
| try { | ||
| await eventStream.emitConsoleOut(`[Backup Macro] Compressing backup...`); | ||
| await compress(`${combinedBackupFolder}`, `${instancePath}/${config.backupFolderRelative}/${combinedBackupFolder}.zip`); | ||
| await eventStream.emitConsoleOut(`[Backup Macro] Compression completed.`); | ||
| } catch (e) { | ||
| console.log(`[Backup Macro] Error compressing backup folder:`, e); | ||
| } | ||
| } |
Author
There was a problem hiding this comment.
@CheatCod this part is my attempt at adding compression
Author
|
Compression of backups on instances with spaces in their name does not work because that same space is showing up in the path. If you are ok with it, @CheatCod I would like to create a pr to change that behavior to create instance folders with hyphens. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added the ability to specify a list of folders to back up, as I wanted to back up the end and nether as well, and large servers may want to back up lobbies or assorted worlds. I also tried setting up compression using the zip module, but I am unsure of why it is not working, any pointers?.
Type of change