Got rid of a few warnings #149
Annotations
10 warnings
|
build:
src/SftpFileSystemx64/SftpLogFileInfo.cs#L89
'success == false' is always 'false'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
|
|
build:
src/SftpFileSystemx64/SftpLogFileInfo.cs#L83
'_sftp != null' is always 'true'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
|
|
build:
src/SftpFileSystemx64/SftpLogFileInfo.cs#L63
'privateKeyFile != null' is always 'true'. Remove or refactor the condition(s) to avoid dead code. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1508)
|
|
build:
src/SftpFileSystemx64/SftpLogFileInfo.cs#L177
Modify 'get_FileExists' to catch a more specific allowed exception type, or rethrow the exception (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1031)
|
|
build:
src/FlashIconHighlighter/Win32Stuff.cs#L25
The method FlashWindowEx didn't use DefaultDllImportSearchPaths attribute for P/Invokes. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca5392)
|
|
build:
src/FlashIconHighlighter/Win32Stuff.cs#L20
Type 'Win32Stuff' is a static holder type but is neither static nor NotInheritable (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1052)
|
|
build:
src/FlashIconHighlighter/Win32Stuff.cs#L11
FLASHWINFO should override the equality (==) and inequality (!=) operators (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1815)
|
|
build:
src/FlashIconHighlighter/Win32Stuff.cs#L11
FLASHWINFO should override Equals (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1815)
|
|
build:
src/ColumnizerLib/IFileSystemPlugin.cs#L42
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.GetLogfileInfo(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.GetLogfileInfo(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|
|
build:
src/ColumnizerLib/IFileSystemPlugin.cs#L34
Change the type of parameter 'uriString' of method 'IFileSystemPlugin.CanHandleUri(string)' from 'string' to 'System.Uri', or provide an overload to 'IFileSystemPlugin.CanHandleUri(string)' that allows 'uriString' to be passed as a 'System.Uri' object (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1054)
|