Fixed some warnings and improved the tests

Fixed warnings

Author: Randall Flagg

src/ColumnizerLib.UnitTests/ColumnTests.cs

@@ -1,5 +1,7 @@
-using LogExpert;
+using LogExpert;
+
 using NUnit.Framework;
+
 using System;
 using System.Text;
 
@@ -9,44 +11,30 @@ namespace ColumnizerLib.UnitTests;
 public class ColumnTests
 {
     [Test]
-    public void Column_LineCutOf()
+    public void Column_LineCutOff ()
     {
-        Column column = new();
-
-        StringBuilder builder = new();
+        var expectedFullValue = new StringBuilder().Append('6', 4675).Append("1234").ToString();
+        var expectedDisplayValue = expectedFullValue[..4675] + "..."; // Using substring shorthand
 
-        for (var i = 0; i < 4675; i++)
+        Column column = new()
         {
-            builder.Append("6");
-        }
-
-        var expected = builder + "...";
-        builder.Append("1234");
-
-        column.FullValue = builder.ToString();
+            FullValue = expectedFullValue
+        };
 
-        Assert.That(column.DisplayValue, Is.EqualTo(expected));
-        Assert.That(column.FullValue, Is.EqualTo(builder.ToString()));
+        Assert.That(column.DisplayValue, Is.EqualTo(expectedDisplayValue));
+        Assert.That(column.FullValue, Is.EqualTo(expectedFullValue));
     }
 
     [Test]
-    public void Column_NoLineCutOf()
+    public void Column_NoLineCutOff ()
     {
-        Column column = new();
-
-        StringBuilder builder = new();
-
-        for (var i = 0; i < 4675; i++)
+        var expected = new StringBuilder().Append('6', 4675).ToString();
+        Column column = new()
         {
-            builder.Append("6");
-        }
-
-        var expected = builder.ToString();
-
-        column.FullValue = expected;
+            FullValue = expected
+        };
 
-        Assert.That(column.DisplayValue, Is.EqualTo(expected));
-        Assert.That(column.FullValue, Is.EqualTo(expected));
+        Assert.That(column.DisplayValue, Is.EqualTo(column.FullValue));
     }
 
     [Test]

src/LogExpert.Core/Classes/Bookmark/BookmarkExporter.cs

@@ -17,11 +17,12 @@ public static void ExportBookmarkList (SortedList<int, Entities.Bookmark> bookma
         FileStream fs = new(fileName, FileMode.Create, FileAccess.Write);
         StreamWriter writer = new(fs);
         writer.WriteLine("Log file name;Line number;Comment");
-        foreach (Entities.Bookmark bookmark in bookmarkList.Values)
+        foreach (var bookmark in bookmarkList.Values)
         {
             var line = $"{logfileName};{bookmark.LineNum};{bookmark.Text.Replace(replacementForNewLine, @"\" + replacementForNewLine, StringComparison.OrdinalIgnoreCase).Replace("\r\n", replacementForNewLine, StringComparison.OrdinalIgnoreCase)}";
             writer.WriteLine(line);
         }
+
         writer.Close();
         fs.Close();
     }