review comments

Author: BRUNER Patrick

src/LogExpert.Tests/Services/ProjectFileHandlerTests.cs

@@ -75,8 +75,7 @@ public void TearDown ()
     public void LoadProject_ValidProjectFile_ReturnsSuccess ()
     {
         // Arrange: create a real log file so validation passes
-        var logFile = Path.Combine(Path.GetTempPath(), Guid.NewGuid() + ".log");
-        File.WriteAllText(logFile, "test log line");
+        var logFile = CreateTempLogFile();
         var tempFile = CreateTempProjectFile([logFile], layoutXml: null);
 
         try
@@ -93,17 +92,16 @@ public void LoadProject_ValidProjectFile_ReturnsSuccess ()
         }
         finally
         {
-            File.Delete(tempFile);
             File.Delete(logFile);
+            File.Delete(tempFile);
         }
     }
 
     [Test]
     public void LoadProject_ValidProjectWithLayoutXml_HasLayoutDataIsTrue ()
     {
         // Arrange: create a real log file so validation passes
-        var logFile = Path.Combine(Path.GetTempPath(), Guid.NewGuid() + ".log");
-        File.WriteAllText(logFile, "test log line");
+        var logFile = CreateTempLogFile();
         var tempFile = CreateTempProjectFile([logFile], layoutXml: "<DockPanel><Content/></DockPanel>");
 
         try
@@ -610,6 +608,16 @@ private static ProjectLoadOutcome CreateOutcome (ProjectLoadOutcome.LoadStatus s
         };
     }
 
+    private static string CreateTempLogFile ()
+    {
+        var tempPathFile = Path.GetTempFileName();
+        var logFile = Path.ChangeExtension(tempPathFile, ".log")!;
+        File.WriteAllText(logFile, "test log line");
+        File.Delete(tempPathFile);
+
+        return logFile;
+    }
+
     /// <summary>
     /// Creates a temporary .lxj project file with the given file names and optional layout XML. Returns the path to the
     /// temp file.

src/LogExpert.UI/Services/ProjectFileHandlerService/ProjectFileHandler.cs

@@ -76,7 +76,10 @@ public ProjectLoadOutcome LoadProject (string projectFileName)
                     LayoutXml = layoutXml
                 };
         }
-        catch (Exception ex)
+        catch (Exception ex) when (ex is IOException or
+                                         UnauthorizedAccessException or
+                                         InvalidOperationException or
+                                         Newtonsoft.Json.JsonException)
         {
             _logger.Error(ex, "LoadProject: Exception loading {FileName}", projectFileName);
 
@@ -116,7 +119,10 @@ public ContinueLoadResult ContinueLoad (ProjectLoadOutcome loadOutcome, MissingF
                 ProjectPersister.SaveProjectData(projectData.ProjectFilePath, projectData);
                 _logger.Info("ContinueLoad: Updated session file {FileName}", projectData.ProjectFilePath);
             }
-            catch (Exception ex)
+            catch (Exception ex) when (ex is IOException or
+                                             UnauthorizedAccessException or
+                                             InvalidOperationException or
+                                             ArgumentException)
             {
                 _logger.Error(ex, "ContinueLoad: Failed to update session file {FileName}", projectData.ProjectFilePath);
             }
@@ -154,7 +160,14 @@ public ContinueLoadResult ContinueLoad (ProjectLoadOutcome loadOutcome, MissingF
                 _ = addFileTab(request);
                 openedCount++;
             }
-            catch (Exception ex)
+            catch (Exception ex) when (ex is not OutOfMemoryException
+                                         and not StackOverflowException
+                                         and not AccessViolationException
+                                         and not AppDomainUnloadedException
+                                         and not BadImageFormatException
+                                         and not CannotUnloadAppDomainException
+                                         and not InvalidProgramException
+                                         and not ThreadAbortException)
             {
                 _logger.Error(ex, "ContinueLoad: Failed to open tab for {FileName}", fileName);
             }
@@ -176,7 +189,10 @@ public bool SaveProject (string projectFileName, ProjectData projectData, out st
             errorMessage = null;
             return true;
         }
-        catch (Exception ex)
+        catch (Exception ex) when (ex is IOException or
+                                         UnauthorizedAccessException or
+                                         InvalidOperationException or
+                                         ArgumentException)
         {
             _logger.Error(ex, "SaveProject: Failed to save {FileName}", projectFileName);
             errorMessage = $"Error saving project: {ex.Message}";