fixed not showing any lines... now all is shown

Author: Hirogen

src/ColumnizerLib.UnitTests/ColumnTests.cs

@@ -44,7 +44,7 @@ public void Column_TruncatesAtConfiguredDisplayLength ()
         Column.SetMaxDisplayLength(10_000);
 
         // Create a line longer than the display max length
-        var longValue = new StringBuilder().Append('X', 15_000).ToString();
+        var longValue = new StringBuilder().Append('X', 15_000).ToString().AsMemory();
 
         Column column = new()
         {
@@ -57,8 +57,8 @@ public void Column_TruncatesAtConfiguredDisplayLength ()
 
         // DisplayValue should be truncated at 10,000 with "..." appended
         Assert.That(column.DisplayValue.Length, Is.EqualTo(10_003)); // 10000 + "..."
-        Assert.That(column.DisplayValue.EndsWith("...", StringComparison.OrdinalIgnoreCase), Is.True);
-        Assert.That(column.DisplayValue.StartsWith("XXX", StringComparison.OrdinalIgnoreCase), Is.True);
+        Assert.That(column.DisplayValue.ToString().EndsWith("...", StringComparison.OrdinalIgnoreCase), Is.True);
+        Assert.That(column.DisplayValue.ToString().StartsWith("XXX", StringComparison.OrdinalIgnoreCase), Is.True);
 
         // Reset for other tests
         Column.SetMaxDisplayLength(20_000);
@@ -69,7 +69,7 @@ public void Column_NoTruncationWhenBelowLimit ()
     {
         Column.SetMaxDisplayLength(20_000);
 
-        var normalValue = new StringBuilder().Append('Y', 5_000).ToString();
+        var normalValue = new StringBuilder().Append('Y', 5_000).ToString().AsMemory();
         Column column = new()
         {
             FullValue = normalValue
@@ -80,11 +80,12 @@ public void Column_NoTruncationWhenBelowLimit ()
     }
 
     [Test]
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1303:Do not pass literals as localized parameters", Justification = "Unit Test")]
     public void Column_NullCharReplacement ()
     {
         Column column = new()
         {
-            FullValue = "asdf\0"
+            FullValue = "asdf\0".AsMemory()
         };
 
         //Switch between the different implementation for the windows versions
@@ -103,11 +104,12 @@ public void Column_NullCharReplacement ()
     }
 
     [Test]
+    [System.Diagnostics.CodeAnalysis.SuppressMessage("Globalization", "CA1303:Do not pass literals as localized parameters", Justification = "Unit Test")]
     public void Column_TabReplacement ()
     {
         Column column = new()
         {
-            FullValue = "asdf\t"
+            FullValue = "asdf\t".AsMemory()
         };
 
         Assert.That(column.DisplayValue, Is.EqualTo("asdf  "));

src/ColumnizerLib/ILogLineColumnizer.cs

@@ -60,8 +60,8 @@ public interface ILogLineColumnizer
     /// add the offset and convert the timestamp back to string value(s).
     /// </remarks>
     /// <param name="callback">Callback interface with functions which can be used by the columnizer</param>
-    /// <param name="line">The line content to be splitted</param>
-    IColumnizedLogLine SplitLine (ILogLineColumnizerCallback callback, ILogLine line);
+    /// <param name="logLine">The line content to be splitted</param>
+    IColumnizedLogLine SplitLine (ILogLineColumnizerCallback callback, ILogLine logLine);
 
     /// <summary>
     /// Returns true, if the columnizer supports timeshift handling.

src/ColumnizerLib/ILogLineMemoryColumnizer.cs

@@ -16,19 +16,19 @@ public interface ILogLineMemoryColumnizer : ILogLineColumnizer
     /// Splits a log line into columns using the specified callback for columnization.
     /// </summary>
     /// <param name="callback">The callback used to determine how the log line is split into columns. Cannot be null.</param>
-    /// <param name="line">The log line to be split into columns. Cannot be null.</param>
+    /// <param name="logLine">The log line to be split into columns. Cannot be null.</param>
     /// <returns>An object representing the columnized log line. The returned object contains the extracted columns from the
     /// input line.</returns>
-    IColumnizedLogLineMemory SplitLine (ILogLineMemoryColumnizerCallback callback, ILogLineMemory line);
+    IColumnizedLogLineMemory SplitLine (ILogLineMemoryColumnizerCallback callback, ILogLineMemory logLine);
 
     /// <summary>
     /// Retrieves the timestamp associated with the specified log line.
     /// </summary>
     /// <param name="callback">An object that provides access to columnizer services for the log line. Used to obtain additional context or
     /// data required for timestamp extraction.</param>
-    /// <param name="line">The log line from which to extract the timestamp.</param>
+    /// <param name="logLine">The log line from which to extract the timestamp.</param>
     /// <returns>A DateTime value representing the timestamp of the specified log line.</returns>
-    DateTime GetTimestamp (ILogLineMemoryColumnizerCallback callback, ILogLineMemory line);
+    DateTime GetTimestamp (ILogLineMemoryColumnizerCallback callback, ILogLineMemory logLine);
 
     /// <summary>
     /// Notifies the callback of a new value for the specified column, providing both the current and previous values.

src/CsvColumnizer/CsvColumnizer.cs

@@ -39,34 +39,7 @@ public string PreProcessLine (string logLine, int lineNum, int realLineNum)
     {
         ArgumentNullException.ThrowIfNull(logLine, nameof(logLine));
 
-        if (realLineNum == 0)
-        {
-            // store for later field names and field count retrieval
-            _firstLine = new CsvLogLine(logLine, 0);
-
-            if (_config.MinColumns > 0)
-            {
-                using CsvReader csv = new(new StringReader(logLine), _config.ReaderConfiguration);
-                if (csv.Parser.Count < _config.MinColumns)
-                {
-                    // on invalid CSV don't hide the first line from LogExpert, since the file will be displayed in plain mode
-                    _isValidCsv = false;
-                    return logLine;
-                }
-            }
-
-            _isValidCsv = true;
-        }
-
-        if (_config.HasFieldNames && realLineNum == 0)
-        {
-            return null; // hide from LogExpert
-        }
-
-        return _config.CommentChar != ' ' &&
-               logLine.StartsWith("" + _config.CommentChar, StringComparison.OrdinalIgnoreCase)
-                    ? null
-                    : logLine;
+        return PreProcessLine(logLine.AsMemory(), lineNum, realLineNum).ToString();
     }
 
     public ReadOnlyMemory<char> PreProcessLine (ReadOnlyMemory<char> logLine, int lineNum, int realLineNum)
@@ -140,18 +113,18 @@ public string[] GetColumnNames ()
         return names;
     }
 
-    public IColumnizedLogLineMemory SplitLine (ILogLineMemoryColumnizerCallback callback, ILogLineMemory line)
+    public IColumnizedLogLineMemory SplitLine (ILogLineMemoryColumnizerCallback callback, ILogLineMemory logLine)
     {
-        ArgumentNullException.ThrowIfNull(line, nameof(line));
+        ArgumentNullException.ThrowIfNull(logLine, nameof(logLine));
 
         return _isValidCsv
-            ? SplitCsvLine(line)
-            : CreateColumnizedLogLine(line);
+            ? SplitCsvLine(logLine)
+            : CreateColumnizedLogLine(logLine);
     }
 
-    public IColumnizedLogLine SplitLine (ILogLineColumnizerCallback callback, ILogLine line)
+    public IColumnizedLogLine SplitLine (ILogLineColumnizerCallback callback, ILogLine logLine)
     {
-        return SplitLine(callback as ILogLineMemoryColumnizerCallback, line as ILogLineMemory);
+        return SplitLine(callback as ILogLineMemoryColumnizerCallback, logLine as ILogLineMemory);
     }
 
     private static ColumnizedLogLine CreateColumnizedLogLine (ILogLineMemory line)
@@ -180,12 +153,12 @@ public int GetTimeOffset ()
         throw new NotImplementedException();
     }
 
-    public DateTime GetTimestamp (ILogLineColumnizerCallback callback, ILogLine line)
+    public DateTime GetTimestamp (ILogLineColumnizerCallback callback, ILogLine logLine)
     {
         throw new NotImplementedException();
     }
 
-    public DateTime GetTimestamp (ILogLineMemoryColumnizerCallback callback, ILogLineMemory line)
+    public DateTime GetTimestamp (ILogLineMemoryColumnizerCallback callback, ILogLineMemory logLine)
     {
         throw new NotImplementedException();
     }