Got rid of a few warnings

Author: Randall Flagg

src/ColumnizerLib/ILogLineColumnizerCallback.cs

@@ -1,3 +1,5 @@
+#pragma warning disable IDE0040
+
 namespace LogExpert;
 
 ///<summary>

src/LogExpert.Core/Classes/Bookmark/BookmarkDataProvider.cs

@@ -27,21 +27,11 @@ public BookmarkDataProvider (SortedList<int, Entities.Bookmark> bookmarkList)
 
     #endregion
 
-    #region Delegates
-
-    public delegate void AllBookmarksRemovedEventHandler (object sender, EventArgs e);
-
-    public delegate void BookmarkAddedEventHandler (object sender, EventArgs e);
-
-    public delegate void BookmarkRemovedEventHandler (object sender, EventArgs e);
-
-    #endregion
-
     #region Events
 
-    public event BookmarkAddedEventHandler BookmarkAdded;
-    public event BookmarkRemovedEventHandler BookmarkRemoved;
-    public event AllBookmarksRemovedEventHandler AllBookmarksRemoved;
+    public event EventHandler<EventArgs> BookmarkAdded;
+    public event EventHandler<EventArgs> BookmarkRemoved;
+    public event EventHandler<EventArgs> AllBookmarksRemoved;
 
     #endregion
 
@@ -141,8 +131,10 @@ public void RemoveBookmarkForLine (int lineNum)
         OnBookmarkRemoved();
     }
 
-    public void RemoveBookmarksForLines (List<int> lineNumList)
+    public void RemoveBookmarksForLines (IEnumerable<int> lineNumList)
     {
+        ArgumentNullException.ThrowIfNull(lineNumList);
+
         foreach (var lineNum in lineNumList)
         {
             _ = BookmarkList.Remove(lineNum);
@@ -155,6 +147,8 @@ public void RemoveBookmarksForLines (List<int> lineNumList)
 
     public void AddBookmark (Entities.Bookmark bookmark)
     {
+        ArgumentNullException.ThrowIfNull(bookmark);
+
         BookmarkList.Add(bookmark.LineNum, bookmark);
         OnBookmarkAdded();
     }

src/LogExpert.Core/Classes/Bookmark/BookmarkExporter.cs

@@ -13,6 +13,7 @@ public static class BookmarkExporter
     public static void ExportBookmarkList (SortedList<int, Entities.Bookmark> bookmarkList, string logfileName,
         string fileName)
     {
+        ArgumentNullException.ThrowIfNull(bookmarkList);
         FileStream fs = new(fileName, FileMode.Create, FileAccess.Write);
         StreamWriter writer = new(fs);
         writer.WriteLine("Log file name;Line number;Comment");

src/LogExpert.Core/Classes/Columnizer/ColumnizerPicker.cs

@@ -93,13 +93,15 @@ public static ILogLineColumnizer FindBetterColumnizer (string fileName,
     /// <param name="fileName"></param>
     /// <param name="logFileReader"></param>
     /// <returns></returns>
-    public static ILogLineColumnizer FindColumnizer (string fileName, IAutoLogLineColumnizerCallback logFileReader, IList<ILogLineColumnizer> list)
+    public static ILogLineColumnizer FindColumnizer (string fileName, IAutoLogLineColumnizerCallback logFileReader, IList<ILogLineColumnizer> registeredColumnizer)
     {
         if (string.IsNullOrEmpty(fileName))
         {
             return new DefaultLogfileColumnizer();
         }
 
+        ArgumentNullException.ThrowIfNull(registeredColumnizer);
+
         List<ILogLine> loglines = [];
 
         if (logFileReader != null)
@@ -120,8 +122,6 @@ public static ILogLineColumnizer FindColumnizer (string fileName, IAutoLogLineCo
             ];
         }
 
-        var registeredColumnizer = list;
-
         List<Tuple<Priority, ILogLineColumnizer>> priorityListOfColumnizers = [];
 
         foreach (ILogLineColumnizer logLineColumnizer in registeredColumnizer)

src/LogExpert.Core/Classes/Columnizer/SquareBracketColumnizer.cs

@@ -1,3 +1,4 @@
+using System.Globalization;
 using System.Text.RegularExpressions;
 
 using static LogExpert.Core.Classes.Columnizer.TimeFormatDeterminer;
@@ -142,13 +143,13 @@ public string[] GetColumnNames ()
         var i = 1;
         while (columnNames.Count < GetColumnCount())
         {
-            columnNames.Insert(columnNames.Count - 1, "Source" + i++.ToString());
+            columnNames.Insert(columnNames.Count - 1, $"Source{i++.ToString(CultureInfo.InvariantCulture)}");
         }
 
         return columnNames.ToArray();
     }
 
-    public IColumnizedLogLine SplitLine (LogExpert.ILogLineColumnizerCallback callback, ILogLine line)
+    public IColumnizedLogLine SplitLine (ILogLineColumnizerCallback callback, ILogLine line)
     {
         // 0         1         2         3         4         5         6         7         8         9         10        11        12        13        14        15        16
         // 012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789012345678901234567890123456789

src/LogExpert.Core/Classes/Filter/FilterPipe.cs

@@ -1,31 +1,31 @@
 using System.Text;
-
 using LogExpert.Core.Interface;
-
 using NLog;
 
 namespace LogExpert.Core.Classes.Filter;
 
-public class FilterPipe
+public class FilterPipe : IDisposable
 {
     #region Fields
 
     private static readonly Logger _logger = LogManager.GetCurrentClassLogger();
 
-    private IList<int> _lineMappingList = [];
+    private List<int> _lineMappingList = [];
     private StreamWriter _writer;
     private readonly object _fileNameLock = new();
+    private bool _disposed;
 
     #endregion
 
     #region cTor
 
-    public FilterPipe (FilterParams filterParams, ILogWindow logWindow)
+    public FilterPipe(FilterParams filterParams, ILogWindow logWindow)
     {
         FilterParams = filterParams;
         LogWindow = logWindow;
         IsStopped = false;
         FileName = Path.GetTempFileName();
+        _disposed = false;
 
         _logger.Info($"Created temp file: {FileName}");
     }
@@ -191,5 +191,29 @@ private void OnClosed ()
         Closed?.Invoke(this, EventArgs.Empty);
     }
 
+    public void Dispose ()
+    {
+        Dispose(true);
+        GC.SuppressFinalize(this);
+    }
+
+    protected virtual void Dispose (bool disposing)
+    {
+        if (!_disposed)
+        {
+            if (disposing)
+            {
+                _writer?.Dispose();
+            }
+            _disposed = true;
+        }
+    }
+
+    ~FilterPipe ()
+    {
+        Dispose(false);
+    }
+
+
     #endregion
 }

src/LogExpert.Core/Interface/IBookmarkData.cs

@@ -2,6 +2,7 @@
 
 namespace LogExpert.Core.Interface;
 
+#pragma warning disable IDE0040
 public interface IBookmarkData
 {
     #region Properties