Merge pull request #548 from LogExperts/545-display-issues-with-csv-columnizer

545 display issues with csv columnizer

Author: Hirogen

build/_build.csproj

@@ -1,11 +1,11 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
     <TargetFramework>net10.0</TargetFramework>
     <RootNamespace></RootNamespace>
     <IsPackable>False</IsPackable>
-    <NoWarn>CS0649;CS0169</NoWarn>
+    <NoWarn>CS0649;CS0169;CS9107</NoWarn>
     <NukeTelemetryVersion>1</NukeTelemetryVersion>
   </PropertyGroup>
 

src/AutoColumnizer/AutoColumnizer.cs

@@ -2,7 +2,7 @@
 
 namespace AutoColumnizer;
 
-public class AutoColumnizer : ILogLineColumnizer
+public class AutoColumnizer : ILogLineMemoryColumnizer
 {
     #region ILogLineColumnizer implementation
 
@@ -28,7 +28,6 @@ public string GetDescription ()
         return "Automatically find the right columnizer for any file";
     }
 
-
     public int GetColumnCount ()
     {
         throw new NotImplementedException();
@@ -39,7 +38,7 @@ public string[] GetColumnNames ()
         throw new NotImplementedException();
     }
 
-    public IColumnizedLogLine SplitLine (ILogLineColumnizerCallback callback, ILogLine line)
+    public IColumnizedLogLineMemory SplitLine (ILogLineMemoryColumnizerCallback callback, ILogLineMemory logLine)
     {
         throw new NotImplementedException();
     }
@@ -54,12 +53,12 @@ public int GetTimeOffset ()
         throw new NotImplementedException();
     }
 
-    public DateTime GetTimestamp (ILogLineColumnizerCallback callback, ILogLine line)
+    public DateTime GetTimestamp (ILogLineMemoryColumnizerCallback callback, ILogLineMemory logLine)
     {
         throw new NotImplementedException();
     }
 
-    public void PushValue (ILogLineColumnizerCallback callback, int column, string value, string oldValue)
+    public void PushValue (ILogLineMemoryColumnizerCallback callback, int column, string value, string oldValue)
     {
     }
 

src/AutoColumnizer/AutoColumnizer.csproj

@@ -4,6 +4,7 @@
 
     <AssemblyTitle>AutoColumnizer</AssemblyTitle>
     <OutputPath>$(SolutionDir)..\bin\$(Configuration)\plugins</OutputPath>
+    <RootNamespace>AutoColumnizer</RootNamespace>
   </PropertyGroup>
 
   <ItemGroup>

src/ColumnizerLib.UnitTests/Extensions/LogLineExtensionsTests.cs

@@ -41,34 +41,6 @@ static Column ()
 
     public static IColumnMemory EmptyColumn { get; }
 
-    [Obsolete]
-    IColumnizedLogLine IColumn.Parent { get; }
-
-    [Obsolete]
-    string IColumn.FullValue
-    {
-        get;
-        //set
-        //{
-        //    field = value;
-
-        //    var temp = FullValue.ToString();
-
-        //    foreach (var replacement in _replacements)
-        //    {
-        //        temp = replacement(temp);
-        //    }
-
-        //    DisplayValue = temp.AsMemory();
-        //}
-    }
-
-    [Obsolete("Use the DisplayValue property of IColumnMemory")]
-    string IColumn.DisplayValue { get; }
-
-    [Obsolete("Use Text property of ITextValueMemory")]
-    string ITextValue.Text => DisplayValue.ToString();
-
     public IColumnizedLogLineMemory Parent
     {
         get; set => field = value;

src/ColumnizerLib/Column.cs

@@ -4,12 +4,6 @@ public class ColumnizedLogLine : IColumnizedLogLineMemory
 {
     #region Properties
 
-    [Obsolete("Use the Property of IColumnizedLogLineMemory")]
-    ILogLine IColumnizedLogLine.LogLine { get; }
-
-    [Obsolete("Use the Property of IColumnizedLogLineMemory")]
-    IColumn[] IColumnizedLogLine.ColumnValues { get; }
-
     public ILogLineMemory LogLine { get; set; }
 
     public IColumnMemory[] ColumnValues { get; set; }

src/ColumnizerLib/ColumnizedLogLine.cs

@@ -1,14 +1,8 @@
 namespace ColumnizerLib.Extensions;
 
-[System.Diagnostics.CodeAnalysis.SuppressMessage("Naming", "CA1708:Identifiers should differ by more than case", Justification = "Intentionally")]
 [System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1034:Nested types should not be visible", Justification = "Intentionally")]
 public static class Extensions
 {
-    extension(ILogLine logLine)
-    {
-        public string ToClipBoardText () => logLine == null ? string.Empty : $"\t{logLine.LineNumber + 1}\t{logLine.FullLine}";
-    }
-
     extension(ILogLineMemory logLine)
     {
         public string ToClipBoardText () => logLine == null ? string.Empty : $"\t{logLine.LineNumber + 1}\t{logLine.FullLine}";

src/ColumnizerLib/Extensions/Extensions.cs

@@ -1,5 +1,6 @@
 namespace ColumnizerLib;
 
+[Obsolete("This interface is deprecated. Use IAutoLogLineMemoryColumnizerCallback for a memory-based implementation instead.")]
 public interface IAutoLogLineColumnizerCallback
 {
     /// <summary>

src/ColumnizerLib/IAutoLogLineColumnizerCallback.cs

@@ -1,6 +1,6 @@
 namespace ColumnizerLib;
 
-public interface IAutoLogLineMemoryColumnizerCallback : IAutoLogLineColumnizerCallback
+public interface IAutoLogLineMemoryColumnizerCallback
 {
     /// <summary>
     /// Returns the log line with the given index (zero-based).

src/ColumnizerLib/IAutoLogLineMemoryColumnizerCallback.cs

@@ -1,5 +1,6 @@
 namespace ColumnizerLib;
 
+[Obsolete("This interface is deprecated. Use IColumnMemory for a memory-based implementation instead.")]
 public interface IColumn : ITextValue
 {
     #region Properties