csv bugfixes and benchmarks

Author: BRUNER Patrick

src/LogExpert.Benchmarks/CsvColumnizerBenchmarks.cs

@@ -0,0 +1,113 @@
+using System.Text;
+
+using BenchmarkDotNet.Attributes;
+
+using ColumnizerLib;
+
+using CsvColumnizer;
+
+using Moq;
+
+namespace LogExpert.Benchmarks;
+
+/// <summary>
+/// Benchmarks for CsvColumnizer covering PreProcessLine, Selected, and SplitLine operations
+/// across varying line counts and column widths.
+/// </summary>
+[MemoryDiagnoser]
+[RankColumn]
+public class CsvColumnizerBenchmarks
+{
+    private ILogLineMemory[] _dataLines = null!;
+    private CsvColumnizer.CsvColumnizer _columnizer = null!;
+
+    [Params(100, 1_000, 10_000)]
+    public int LineCount { get; set; }
+
+    [Params(5, 15)]
+    public int ColumnCount { get; set; }
+
+    [GlobalSetup]
+    public void Setup ()
+    {
+        // Build header and data lines
+        var headerParts = new string[ColumnCount];
+        for (var i = 0; i < ColumnCount; i++)
+        {
+            headerParts[i] = $"Column{i}";
+        }
+
+        var header = string.Join(";", headerParts);
+
+        // Initialize columnizer with header
+        _columnizer = new CsvColumnizer.CsvColumnizer();
+        _columnizer.PreProcessLine(header.AsMemory(), 0, 0);
+
+        var mockCallback = new Mock<ILogLineMemoryColumnizerCallback>();
+        _columnizer.Selected(mockCallback.Object);
+
+        // Generate data lines
+        _dataLines = new ILogLineMemory[LineCount];
+        var random = new Random(42);
+
+        for (var i = 0; i < LineCount; i++)
+        {
+            var parts = new string[ColumnCount];
+            for (var j = 0; j < ColumnCount; j++)
+            {
+                parts[j] = GenerateFieldValue(random, j);
+            }
+
+            _dataLines[i] = new CsvLogLine(string.Join(";", parts), i + 1);
+        }
+    }
+
+    [Benchmark(Description = "SplitLine: parse all lines")]
+    public int SplitAllLines ()
+    {
+        var totalColumns = 0;
+        for (var i = 0; i < _dataLines.Length; i++)
+        {
+            var result = _columnizer.SplitLine(null, _dataLines[i]);
+            totalColumns += result.ColumnValues.Length;
+        }
+
+        return totalColumns;
+    }
+
+    [Benchmark(Description = "PreProcessLine: preprocess all lines")]
+    public int PreProcessAllLines ()
+    {
+        var processed = 0;
+        for (var i = 0; i < _dataLines.Length; i++)
+        {
+            var result = _columnizer.PreProcessLine(_dataLines[i].FullLine, i + 1, i + 1);
+            if (!result.IsEmpty)
+            {
+                processed++;
+            }
+        }
+
+        return processed;
+    }
+
+    [Benchmark(Description = "Selected: re-detect columns from header")]
+    public int RedetectColumns ()
+    {
+        var mockCallback = new Mock<ILogLineMemoryColumnizerCallback>();
+        _columnizer.Selected(mockCallback.Object);
+        return _columnizer.GetColumnCount();
+    }
+
+    private static string GenerateFieldValue (Random random, int columnIndex)
+    {
+        // Mix of value types: numbers, short text, quoted text with commas
+        return (columnIndex % 4) switch
+        {
+            0 => random.Next(1, 100000).ToString(),
+            1 => $"text_{random.Next(1, 9999)}",
+            2 => $"\"Value, with quotes {random.Next(1, 999)}\"",
+            _ => new string((char)('A' + random.Next(0, 26)), random.Next(5, 20)),
+        };
+    }
+}

src/LogExpert.Benchmarks/LogExpert.Benchmarks.csproj

@@ -2,7 +2,9 @@
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
-    <TargetFramework>net10.0</TargetFramework>
+    <TargetFramework>net10.0-windows</TargetFramework>
+    <EnableWindowsTargeting>true</EnableWindowsTargeting>
+    <UseWindowsForms>true</UseWindowsForms>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <!-- Override Directory.Build.props settings for BenchmarkDotNet compatibility -->
@@ -12,11 +14,14 @@
 
   <ItemGroup>
     <PackageReference Include="BenchmarkDotNet" />
+    <PackageReference Include="Moq" />
   </ItemGroup>
 
   <ItemGroup>
     <ProjectReference Include="..\LogExpert.Core\LogExpert.Core.csproj" />
     <ProjectReference Include="..\PluginRegistry\LogExpert.PluginRegistry.csproj" />
+    <ProjectReference Include="..\CsvColumnizer\CsvColumnizer.csproj" />
+    <ProjectReference Include="..\ColumnizerLib\ColumnizerLib.csproj" />
   </ItemGroup>
 
   <!-- Exclude the shared AssemblyInfo.cs that Directory.Build.props tries to add -->

src/LogExpert.Benchmarks/Program.cs

@@ -16,6 +16,7 @@ public static void Main (string[] args)
             _ = BenchmarkRunner.Run<BufferIndexBenchmarks>();
             _ = BenchmarkRunner.Run<ReadThroughputBenchmarks>();
             _ = BenchmarkRunner.Run<BufferIndexContentionBenchmarks>();
+            _ = BenchmarkRunner.Run<CsvColumnizerBenchmarks>();
         }
         else
         {
@@ -28,6 +29,7 @@ public static void Main (string[] args)
         Console.WriteLine("ReadThroughputBenchmarks: Benchmarks for read throughput");
         Console.WriteLine("BufferIndexBenchmarks: Benchmarks for buffer index");
         Console.WriteLine("BufferIndexContentionBenchmarks: Benchmarks for buffer index contention");
+        Console.WriteLine("CsvColumnizerBenchmarks: Benchmarks for CSV columnizer (SplitLine, PreProcess, Selected)");
         Console.WriteLine("Dry run:");
         Console.WriteLine("dotnet run -c Release -- --filter \"*<benchmarkname>*\" --job Dry --noOverwrite");
         Console.WriteLine("Short run:");

src/LogExpert.Tests/TestData/comma.csv

@@ -0,0 +1,2 @@
+"Date","Level","Message"
+"2021-01-01","Error","comma file"

src/LogExpert.Tests/TestData/semicolon.csv

@@ -0,0 +1,2 @@
+"Date";"Level";"Message"
+"2021-12-12";"TRACE";"semicolon file "

src/LogExpert.UI/Controls/LogWindow/LogWindow.cs

@@ -3430,7 +3430,10 @@ private void SetColumnizerInternal (ILogLineMemoryColumnizer columnizer)
             _ = columnComboBox.Items.Add(columnName);
         }
 
-        columnComboBox.SelectedIndex = 0;
+        if (columnComboBox.Items.Count > 0)
+        {
+            columnComboBox.SelectedIndex = 0;
+        }
 
         OnColumnizerChanged(CurrentColumnizer);
     }