Add second parameter for better message when throwing ArgumentNullException

Author: Randall Flagg

src/LogExpert.Core/Classes/Bookmark/BookmarkDataProvider.cs

@@ -134,7 +134,7 @@ public void RemoveBookmarkForLine (int lineNum)
     //TOOD: check if the callers are checking for null before calling
     public void RemoveBookmarksForLines (IEnumerable<int> lineNumList)
     {
-        ArgumentNullException.ThrowIfNull(lineNumList);
+        ArgumentNullException.ThrowIfNull(lineNumList, nameof(lineNumList));
 
         foreach (var lineNum in lineNumList)
         {
@@ -148,7 +148,7 @@ public void RemoveBookmarksForLines (IEnumerable<int> lineNumList)
     //TOOD: check if the callers are checking for null before calling
     public void AddBookmark (Entities.Bookmark bookmark)
     {
-        ArgumentNullException.ThrowIfNull(bookmark);
+        ArgumentNullException.ThrowIfNull(bookmark, nameof(bookmark));
 
         BookmarkList.Add(bookmark.LineNum, bookmark);
         OnBookmarkAdded();

src/LogExpert.Core/Classes/Bookmark/BookmarkExporter.cs

@@ -13,7 +13,7 @@ public static class BookmarkExporter
     //TOOD: check if the callers are checking for null before calling
     public static void ExportBookmarkList (SortedList<int, Entities.Bookmark> bookmarkList, string logfileName, string fileName)
     {
-        ArgumentNullException.ThrowIfNull(bookmarkList);
+        ArgumentNullException.ThrowIfNull(bookmarkList, nameof(bookmarkList));
         FileStream fs = new(fileName, FileMode.Create, FileAccess.Write);
         StreamWriter writer = new(fs);
         writer.WriteLine("Log file name;Line number;Comment");

src/LogExpert.Core/Classes/Columnizer/ColumnizerPicker.cs

@@ -101,7 +101,7 @@ public static ILogLineColumnizer FindColumnizer (string fileName, IAutoLogLineCo
             return new DefaultLogfileColumnizer();
         }
 
-        ArgumentNullException.ThrowIfNull(registeredColumnizer);
+        ArgumentNullException.ThrowIfNull(registeredColumnizer, nameof(registeredColumnizer));
 
         List<ILogLine> loglines = [];
 

src/LogExpert.Core/Classes/DateTimeParser/DateFormatPartAdjuster.cs

@@ -3,6 +3,7 @@
 
 namespace LogExpert.Core.Classes.DateTimeParser;
 
+//TODO: This should be moved into LogExpert.UI and changed to internal
 // Ensures we have constant width (number of characters) date formats
 public static class DateFormatPartAdjuster
 {
@@ -18,6 +19,8 @@ public static class DateFormatPartAdjuster
 
     public static string AdjustDateTimeFormatPart(string part)
     {
+        ArgumentNullException.ThrowIfNull(part, nameof(part));
+
         if (!_dateTimePartReplacements.TryGetValue(part, out var adjustedPart))
         {
             return part;

src/LogExpert.Core/Classes/DateTimeParser/Token.cs

@@ -7,7 +7,7 @@ public static class Token
     //TOOD: check if the callers are checking for null before calling
     public static bool IsDatePart(string token)
     {
-        ArgumentNullException.ThrowIfNull(token);
+        ArgumentNullException.ThrowIfNull(token, nameof(token));
         return
             token.StartsWith("y", StringComparison.OrdinalIgnoreCase) ||
             token.StartsWith("m", StringComparison.OrdinalIgnoreCase) ||

src/LogExpert.UI/Controls/DateTimeDragControl.cs

@@ -234,16 +234,15 @@ private void InitCustomRects (Section dateSection)
             .Select(DateFormatPartAdjuster.AdjustDateTimeFormatPart)
             .ToArray();
 
-        Rectangle rect = ClientRectangle;
-        var oneCharWidth = rect.Width / _dateParts.Sum(s => s.Length);
-        var left = rect.Left;
+        var oneCharWidth = ClientRectangle.Width / _dateParts.Sum(s => s.Length);
+        var left = ClientRectangle.Left;
 
         _digitRects.Clear();
 
         foreach (var datePart in _dateParts)
         {
             var s = datePart.Length * oneCharWidth;
-            _digitRects.Add(new Rectangle(left, rect.Top, s, rect.Height));
+            _digitRects.Add(new Rectangle(left, ClientRectangle.Top, s, ClientRectangle.Height));
             left += s;
         }
 

src/LogExpert/Classes/CommandLine/CmdLine.cs

@@ -17,7 +17,7 @@ public class CmdLineString (string name, bool required, string helpMessage) : Cm
 
     public static implicit operator string (CmdLineString s)
     {
-        ArgumentNullException.ThrowIfNull(s);
+        ArgumentNullException.ThrowIfNull(s, nameof(s));
         return s.Value;
     }