Skip to content

Commit acfc75e

Browse files
TheTomclaude
authored andcommitted
fix(turbo-quant): add forward declaration for turbo_cpu_fwht_inverse
CI failure (every -Werror build job — ubuntu-latest-cuda, ggml-ci-x64-cpu-*, arm64-cpu-*, macOS-latest-{x64,arm64,arm64-webgpu}, ubuntu-22-{hip-quality-check,musa}, android-arm64, ubuntu-cpu x64-22.04): ggml/src/ggml-turbo-quant.c:247:15: error: no previous prototype for 'turbo_cpu_fwht_inverse' [-Werror=missing-prototypes] Pre-existing issue on the TQ branch — the function is defined GGML_API but has no prototype declaration. M5 Max + M2 mini builds don't use -Werror so it slid through local validation. Upstream CI does. Fix: forward-declare the function near the top of the .c file. Matches the extern declaration already used by tests/test-turbo-quant.c. No semantic change. The other GGML_API symbol in this file (turbo3_cpu_wht_group_size) is a variable, not a function — -Wmissing-prototypes does not apply. Flagged by @pacak on PR TheTom#146 (ubuntu-latest-cuda CI). Restores green CI on all -Werror build jobs without affecting any runtime path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-Authored-By: tturney@psyguard.ai
1 parent 2187457 commit acfc75e

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

ggml/src/ggml-turbo-quant.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@
2020
#define M_PI 3.14159265358979323846
2121
#endif
2222

23+
/* Forward declarations for GGML_API symbols defined in this file (satisfies
24+
* -Wmissing-prototypes under upstream CI's -Werror policy). */
25+
GGML_API void turbo_cpu_fwht_inverse(float * x, int group_size);
26+
2327
/* Global: WHT group size for CPU quantize path (set by CPU SET_ROWS handler) */
2428
GGML_API int turbo3_cpu_wht_group_size = 0;
2529

0 commit comments

Comments
 (0)