fix: missing path separator for non-ASCII IMAP folder names#360
Open
waffen29 wants to merge 1 commit into
Open
fix: missing path separator for non-ASCII IMAP folder names#360waffen29 wants to merge 1 commit into
waffen29 wants to merge 1 commit into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
waffen29
force-pushed
the
fix/arabic-folders-download
branch
2 times, most recently
from
8cf7574 to
ff59a2a
Compare
Author
|
I have read the CLA Document and I hereby sign the CLA |
waffen29
force-pushed
the
fix/arabic-folders-download
branch
5 times, most recently
from
56e8e23 to
8a65077
Compare
Without the separator, emails in folder 'مجلد' were stored as 'مجلدID.eml' instead of 'مجلد/ID.eml'.
waffen29
force-pushed
the
fix/arabic-folders-download
branch
from
8a65077 to
f8994ae
Compare
waffen29
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emails in non-ASCII folders were stored as
folder_nameID.emlinstead offolder_name/ID.eml— folder name and message ID got merged together.Fixed by adding a trailing slash to
sanitizedPathinIngestionService.