Show tests as needing re-run when the tests file is modified

Author: pmoura

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## [0.83.0]
+
+* Show tests as needing re-run when the tests file is modified
+* Fix the "Problems" pane not being cleared when the tests file is modified
+* Fix the "Problems" pane not updating when re-running tests when the test files were not modified
+
 ## [0.82.0]
 
 * Changed file system calls to use the VSCode API instead of the Node API

package.json

@@ -2,7 +2,7 @@
     "name": "logtalk-for-vscode",
     "displayName": "Logtalk for VSCode",
     "description": "Logtalk programming support",
-    "version": "0.82.0",
+    "version": "0.83.0",
     "publisher": "LogtalkDotOrg",
     "icon": "images/logtalk.png",
     "license": "MIT",
@@ -1328,7 +1328,7 @@
         "compile": "tsc -watch -p ./",
         "test": "tsc ./tests/runTest.ts",
         "vsix:make": "vsce package --baseImagesUrl https://raw.githubusercontent.com/llvm/llvm-project/master/clang-tools-extra/clangd/clients/clangd-vscode/",
-        "vsix:install": "code --install-extension logtalk-for-vscode-0.82.0.vsix"
+        "vsix:install": "code --install-extension logtalk-for-vscode-0.83.0.vsix"
     },
     "devDependencies": {
         "@types/bluebird": "^3.5.38",

src/features/terminal.ts

@@ -997,6 +997,9 @@ export default class LogtalkTerminal {
       uri = window.activeTextEditor.document.uri;
     }
 
+    // Clear all existing test diagnostics before running tests
+    testsReporter.clearAll();
+
     // Declare Variables
     // Check if URI is a directory or file
     let dir0: string;
@@ -1088,6 +1091,9 @@ export default class LogtalkTerminal {
       uri = window.activeTextEditor.document.uri;
     }
 
+    // Clear all existing test diagnostics before running tests
+    testsReporter.clearAll();
+
     // Declare Variables
     const dir0 = path.dirname(uri.fsPath);
 
@@ -1163,6 +1169,9 @@ export default class LogtalkTerminal {
       uri = window.activeTextEditor.document.uri;
     }
 
+    // Clear all existing test diagnostics before running tests
+    testsReporter.clearAll();
+
     // Declare Variables
     const dir0 = path.dirname(uri.fsPath);
 
@@ -1239,6 +1248,9 @@ export default class LogtalkTerminal {
       uri = window.activeTextEditor.document.uri;
     }
 
+    // Clear all existing test diagnostics before running tests
+    testsReporter.clearAll();
+
     // Declare Variables
     const dir0 = path.dirname(uri.fsPath);
 
@@ -1654,6 +1666,11 @@ export default class LogtalkTerminal {
     LogtalkTerminal.createLogtalkTerm();
     LogtalkTerminal._outputChannel.clear();
 
+    // Clear all existing test diagnostics before running tests
+    if (testsReporter) {
+      testsReporter.clearAll();
+    }
+
     const dir = LogtalkTerminal.getWorkspaceFolderForUri(uri);
     if (!dir) {
       vscode.window.showErrorMessage('No workspace folder open');
@@ -1710,6 +1727,9 @@ export default class LogtalkTerminal {
     LogtalkTerminal.createLogtalkTerm();
     LogtalkTerminal._outputChannel.clear();
 
+    // Clear all existing test diagnostics before running tests
+    testsReporter.clearAll();
+
     const dir = LogtalkTerminal.getWorkspaceFolderForUri(uri);
     if (!dir) {
       vscode.window.showErrorMessage('No workspace folder open');

src/features/testsCodeActionProvider.ts

@@ -274,6 +274,12 @@ export default class LogtalkTestsReporter implements CodeActionProvider {
     DiagnosticsUtils.updateDiagnostics(this.diagnosticCollection, uri, diagnosticToRemove);
   }
 
+  public clearAll() {
+    this.diagnosticCollection.clear();
+    this.diagnostics = {};
+    this.diagnosticHash = [];
+  }
+
   private removeDuplicateDiagnostics(diagnostics: Diagnostic[]): Diagnostic[] {
     return DiagnosticsUtils.removeDuplicateDiagnostics(diagnostics);
   }
@@ -314,6 +320,21 @@ export default class LogtalkTestsReporter implements CodeActionProvider {
       subscriptions
     );
 
+    // Clear diagnostics when a test file is modified
+    workspace.onDidChangeTextDocument(
+      textDocumentChangeEvent => {
+        if (textDocumentChangeEvent.contentChanges.length > 0) {
+          const filePath = textDocumentChangeEvent.document.uri.fsPath;
+          if (filePath in this.diagnostics) {
+            this.diagnosticCollection.delete(textDocumentChangeEvent.document.uri);
+            this.diagnostics[filePath] = [];
+          }
+        }
+      },
+      this,
+      subscriptions
+    );
+
     this.loadConfiguration();
 
     workspace.onDidCloseTextDocument(

src/features/testsExplorer.ts

@@ -290,6 +290,16 @@ export class LogtalkTestsExplorerProvider implements Disposable {
       }
     });
     this.disposables.push(saveDocumentListener);
+
+    // Watch for source file modifications to invalidate test results
+    // This marks tests as needing re-run when the file is edited
+    const changeDocumentListener = workspace.onDidChangeTextDocument(event => {
+      // Only process Logtalk files with actual content changes
+      if (event.document.languageId === 'logtalk' && event.contentChanges.length > 0) {
+        this.invalidateTestResultsForFile(event.document.uri);
+      }
+    });
+    this.disposables.push(changeDocumentListener);
   }
 
   /**
@@ -1744,7 +1754,8 @@ export class LogtalkTestsExplorerProvider implements Disposable {
 
   /**
    * Invalidate test results for a specific source file
-   * This marks all test items associated with the file as outdated
+   * This marks all test items associated with the file as needing re-run
+   * while preserving the counter for tests in other files
    */
   private invalidateTestResultsForFile(uri: Uri): void {
     const normalizedPath = Utils.normalizeFilePath(uri.fsPath);
@@ -1761,23 +1772,23 @@ export class LogtalkTestsExplorerProvider implements Disposable {
       return;
     }
 
-    // Collect all test items for this file (file, objects, and individual tests)
-    const testItemsToInvalidate: TestItem[] = [fileItem];
+    // Collect individual test items for this file
+    const individualTestItems: TestItem[] = [];
 
-    // Add all object-level items
+    // Add all individual test items from each object
     fileItem.children.forEach(objectItem => {
-      testItemsToInvalidate.push(objectItem);
-
-      // Add all individual test items
       objectItem.children.forEach(testItem => {
-        testItemsToInvalidate.push(testItem);
+        individualTestItems.push(testItem);
       });
     });
 
-    // Invalidate all collected test items
-    this.controller.invalidateTestResults(testItemsToInvalidate);
+    // Mark individual tests as needing re-run (shows enqueued icon)
+    // Use individual test runs to avoid resetting the counter for other files
+    for (const testItem of individualTestItems) {
+      this.markTestAsNeedsRerun(testItem);
+    }
 
-    this.logger.debug(`Invalidated ${testItemsToInvalidate.length} test item(s) for file: ${fileUri.fsPath}`);
+    this.logger.debug(`Marked ${individualTestItems.length} test(s) as needing re-run for file: ${fileUri.fsPath}`);
   }
 
   /**