Skip to content

Commit b4dde41

Browse files
committed
Fix performance regression updating the Testing pane when editing test files
1 parent 562f545 commit b4dde41

3 files changed

Lines changed: 9 additions & 15 deletions

File tree

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
## [0.85.2]
4+
5+
* Fix performance regression updating the Testing pane when editing test files
6+
37
## [0.85.1]
48

59
* Fix updating the `loader.lgt` and `tester.lgt` files when moving a file to a subdirectory

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "logtalk-for-vscode",
33
"displayName": "Logtalk for VSCode",
44
"description": "Logtalk programming support",
5-
"version": "0.85.1",
5+
"version": "0.85.2",
66
"publisher": "LogtalkDotOrg",
77
"icon": "images/logtalk.png",
88
"license": "MIT",
@@ -1338,7 +1338,7 @@
13381338
"compile": "tsc -watch -p ./",
13391339
"test": "tsc ./tests/runTest.ts",
13401340
"vsix:make": "vsce package --baseImagesUrl https://raw.githubusercontent.com/llvm/llvm-project/master/clang-tools-extra/clangd/clients/clangd-vscode/",
1341-
"vsix:install": "code --install-extension logtalk-for-vscode-0.85.1.vsix"
1341+
"vsix:install": "code --install-extension logtalk-for-vscode-0.85.2.vsix"
13421342
},
13431343
"devDependencies": {
13441344
"@types/bluebird": "^3.5.38",

src/features/testsExplorer.ts

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -282,24 +282,14 @@ export class LogtalkTestsExplorerProvider implements Disposable {
282282
this.disposables.push(workspaceFoldersListener);
283283

284284
// Watch for source file saves to invalidate test results
285-
// Use onWillSaveTextDocument to check if document is dirty before save
285+
// Use onWillSaveTextDocument to invalidate tests when a file is saved
286286
const saveDocumentListener = workspace.onWillSaveTextDocument(event => {
287-
// Only process Logtalk files that have unsaved changes
288-
if (event.document.languageId === 'logtalk' && event.document.isDirty) {
287+
// Only process Logtalk files
288+
if (event.document.languageId === 'logtalk') {
289289
this.invalidateTestResultsForFile(event.document.uri);
290290
}
291291
});
292292
this.disposables.push(saveDocumentListener);
293-
294-
// Watch for source file modifications to invalidate test results
295-
// This marks tests as needing re-run when the file is edited
296-
const changeDocumentListener = workspace.onDidChangeTextDocument(event => {
297-
// Only process Logtalk files with actual content changes
298-
if (event.document.languageId === 'logtalk' && event.contentChanges.length > 0) {
299-
this.invalidateTestResultsForFile(event.document.uri);
300-
}
301-
});
302-
this.disposables.push(changeDocumentListener);
303293
}
304294

305295
/**

0 commit comments

Comments
 (0)