fix: Allow admin component to define acl_resource for added security

Author: jissereitsma

Component/Form/FormViewModel.php

@@ -17,6 +17,7 @@
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Framework\ObjectManagerInterface;
 use Magento\Framework\UrlFactory;
+use Magento\Tests\NamingConvention\true\string;
 
 /**
  * @method FormRepository getRepository()
@@ -48,6 +49,7 @@ public function getJsData(): array
     {
         return [
             ...parent::getJsData(),
+            'aclResource' => $this->getAclResource(),
             'item' => $this->getItemData(),
             'indexUrl' => $this->getIndexUrl(),
         ];
@@ -103,6 +105,16 @@ public function getFields(): array
         );
     }
 
+    public function getAclResource(): string
+    {
+        $aclResource = (string) $this->getBlock()->getAclResource();
+        if (!empty($aclResource)) {
+            return $aclResource;
+        }
+
+        return 'Magento_Backend::admin';
+    }
+
     private function getIndexUri(): string
     {
         $indexUrl = $this->getBlock()->getIndexUrl();

Component/Grid/GridViewModel.php

@@ -55,6 +55,16 @@ public function getNamespace(): string
         return $this->getBlock()->getNameInLayout();
     }
 
+    public function getAclResource(): string
+    {
+        $aclResource = (string) $this->getBlock()->getAclResource();
+        if (!empty($aclResource)) {
+            return $aclResource;
+        }
+
+        return 'Magento_Backend::admin';
+    }
+
     public function getCurrentUrl(): string
     {
         return (string)$this->urlFactory->create()->getUrl('*/*/*');
@@ -170,6 +180,7 @@ public function getJsData(): array
             ...parent::getJsData(),
             ...$stateData,
             'namespace' => $this->getNamespace(),
+            'aclResource' => $this->getAclResource(),
             'gridFilters' => $this->getGridFilterStateValues(),
             'columns' => $columns,
             'columnPositions' => $this->getColumnPositions(),

view/adminhtml/templates/script/component-partial/columns-selector-component-partial.phtml

@@ -26,7 +26,7 @@ use Magento\Framework\View\Element\Template;
                 this.activeColumns.push(columnName);
             }
 
-            this.post({activeColumns: this.activeColumns});
+            this.submit({activeColumns: this.activeColumns});
         }
     }
 </script>

view/adminhtml/templates/script/component-partial/filters-component-partial.phtml

@@ -18,7 +18,7 @@ use Magento\Framework\View\Element\Template;
             return this.showFilters ? '_active' : '';
         },
         applyFilters() {
-            this.post({filters: this.filters});
+            this.submit({filters: this.filters});
         }
     }
 </script>

view/adminhtml/templates/script/component-partial/inline-edit-component-partial.phtml

@@ -25,7 +25,7 @@ use Magento\Framework\View\Element\Template;
                 }
             };
 
-            this.post(postData);
+            this.submit(postData);
         },
     }
 </script>

view/adminhtml/templates/script/component-partial/limit-component-partial.phtml

@@ -18,10 +18,10 @@ use Magento\Framework\View\Element\Template;
                 return;
             }
 
-            this.post({limit: event.target.value});
+            this.submit({limit: event.target.value});
         },
         setLimitFromElement(event) {
-            this.post({limit: event.target.getAttribute('data-limit')});
+            this.submit({limit: event.target.getAttribute('data-limit')});
         },
     }
 </script>

view/adminhtml/templates/script/component-partial/pagination-component-partial.phtml

@@ -14,13 +14,13 @@ use Magento\Framework\View\Element\Template;
                 return;
             }
 
-            this.post({page: event.target.value});
+            this.submit({page: event.target.value});
         },
         nextPage() {
-            this.post({page: this.page + 1});
+            this.submit({page: this.page + 1});
         },
         previousPage(event) {
-            this.post({page: this.page - 1});
+            this.submit({page: this.page - 1});
         }
     }
 </script>

view/adminhtml/templates/script/component-type/form-component-type.phtml

@@ -10,37 +10,41 @@ use Magento\Framework\View\Element\Template;
 <script>
     const LokiAdminFormComponentType = {
         ...LokiComponentType,
+        aclResource: '',
         showOtherActions: false,
+        submit(data) {
+            this.post({...data, aclResource: this.aclResource});
+        },
         toggleOtherActions() {
             this.showOtherActions = !this.showOtherActions;
         },
         closeAction() {
             window.location.href = this.indexUrl;
         },
         saveAndContinueAction() {
-            this.post({
+            this.submit({
                 actions: ['save'],
                 item: this.item,
             });
         },
         saveAndDuplicateAction() {
-            this.post({
+            this.submit({
                 actions: ['save', 'duplicate'],
                 item: this.item,
             });
 
             this.closeAction();
         },
         saveAndCloseAction() {
-            this.post({
+            this.submit({
                 actions: ['save'],
                 item: this.item,
             });
 
             this.closeAction();
         },
         deleteAction() {
-            this.post({
+            this.submit({
                 actions: ['delete'],
                 item: this.item,
             });

view/adminhtml/templates/script/component-type/grid-component-type.phtml

@@ -17,10 +17,15 @@ use Magento\Framework\View\Element\Template;
         ...LokiAdminFiltersComponentPartial,
         ...LokiAdminMassActionsComponentPartial,
         ...LokiComponentType,
+        namespace: '',
+        aclResource: '',
         columns: [],
         columnPositions: {},
         showOtherActions: false,
         gridFilters: {},
+        submit(data) {
+            this.post({...data, aclResource: this.aclResource});
+        },
         toggleOtherActions() {
             this.showOtherActions = !this.showOtherActions;
         },
@@ -34,10 +39,10 @@ use Magento\Framework\View\Element\Template;
             }
         },
         applyFilters() {
-            this.post({filters: this.gridFilters});
+            this.submit({filters: this.gridFilters});
         },
         clearFilters() { // @todo: Rename to clearGridFilters
-            this.post({
+            this.submit({
                 clearFilters: true
             });
         },
@@ -47,7 +52,7 @@ use Magento\Framework\View\Element\Template;
                 return;
             }
 
-            this.post({
+            this.submit({
                 removeFilter: targetFilter
             });
         },
@@ -56,7 +61,7 @@ use Magento\Framework\View\Element\Template;
                 return;
             }
 
-            this.post({
+            this.submit({
                 sort: {
                     sortBy: this.$el.getAttribute('data-column'),
                     sortDirection: this.sortDirection === 'ASC' ? 'DESC' : 'ASC',
@@ -75,8 +80,7 @@ use Magento\Framework\View\Element\Template;
                 return;
             }
 
-            this.post({search: this.$el.value});
+            this.submit({search: this.$el.value});
         },
-
     }
 </script>

view/adminhtml/templates/script/component/grid-component.phtml

@@ -17,7 +17,7 @@ use Magento\Framework\View\Element\Template;
                 const componentName = itemParts[0];
                 const propertyName = itemParts[1];
                 const component = Alpine.store('LokiComponents').get(componentName);
-                component.post({reposition: {property: propertyName, position: position}});
+                component.submit({reposition: {property: propertyName, position: position}});
             }
         }));
     });