Skip to content

Commit 1d03cb0

Browse files
committed
Fix PHPStan issue and PHP unit test
1 parent ac48d7f commit 1d03cb0

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

Location/AddressFactory.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace Loki\Components\Location;
44

55
use Magento\Framework\ObjectManagerInterface;
6-
use Magento\Quote\Api\Data\AddressInterface;
6+
use Magento\Quote\Model\Quote\Address as QuoteAddress;
77

88
class AddressFactory
99
{
@@ -61,7 +61,7 @@ public function create(
6161
return $this->addressParserComposite->parse($address);
6262
}
6363

64-
public function createFromQuoteAddress(AddressInterface $quoteAddress): Address
64+
public function createFromQuoteAddress(QuoteAddress $quoteAddress): Address
6565
{
6666
return $this->create(
6767
street: (string)$quoteAddress->getStreetLine(1),

Test/Unit/Validator/RequiredValidatorTest.php

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use Loki\Components\Component\ComponentInterface;
66
use Loki\Components\Util\Ajax;
77
use Loki\Components\Util\IsEmpty;
8+
use Magento\Framework\App\RequestInterface;
89
use PHPUnit\Framework\TestCase;
910
use Loki\Components\Validator\RequiredValidator;
1011

@@ -16,7 +17,8 @@ public function testWithNoSimpleValues(): void
1617
$ajax = $this->createMock(Ajax::class);
1718
$ajax->method('isAjax')->willReturn(true);
1819

19-
$validator = new RequiredValidator(new IsEmpty(), $ajax);
20+
$request = $this->createMock(RequestInterface::class);
21+
$validator = new RequiredValidator(new IsEmpty(), $request, $ajax);
2022
$this->assertTrue($validator->validate(1, $component));
2123
$this->assertIsArray($validator->validate(0, $component));
2224
$this->assertIsArray($validator->validate('', $component));

0 commit comments

Comments
 (0)