Skip to content

Commit cb933c0

Browse files
committed
Do not escape $css() with escapeHtmlAttr() but escapeHtml()
1 parent 89bfd77 commit cb933c0

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

view/base/templates/component/modal/close-button.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ $label = $block->getLabel();
1616
?>
1717
<button
1818
@click="toggleModal"
19-
class="<?= $escaper->escapeHtmlAttr($css('btn btn-primary mt-4', '')) ?>"
19+
class="<?= $escaper->escapeHtml($css('btn btn-primary mt-4', '')) ?>"
2020
>
2121
<span><?= $escaper->escapeHtml($label) ?></span>
2222
</button>

view/base/templates/component/modal/close.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,5 +18,5 @@ use Magento\Framework\View\Element\Template;
1818
<button
1919
aria-label="<?= $escaper->escapeHtml(__('Close')) ?>"
2020
@click.prevent="toggleModal"
21-
class="<?= $escaper->escapeHtmlAttr($css('float-right cursor-pointer')) ?>"
21+
class="<?= $escaper->escapeHtml($css('float-right cursor-pointer')) ?>"
2222
><?= /* @noEscape */ $imageRenderer->icon($block, 'xmark') ?></button>

view/base/templates/utils/local-messages.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ use Loki\CssUtils\Util\CssClass;
1212
?>
1313
<template x-if="hasLocalMessages">
1414
<ul
15-
class="loki-components-messages <?= $escaper->escapeHtmlAttr($css('')) ?>"
15+
class="loki-components-messages <?= $escaper->escapeHtml($css('')) ?>"
1616
id="<?= $escaper->escapeHtml($block->getDomId()) ?>">
1717
<template x-for="message in messages">
1818
<li :class="message.type" x-html="message.text"></li>

0 commit comments

Comments
 (0)