Skip to content

Commit 9620557

Browse files
committed
Move JSON directive into separate template
1 parent 4281b14 commit 9620557

4 files changed

Lines changed: 24 additions & 12 deletions

File tree

view/frontend/layout/loki_components.xml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,15 @@
22
<page xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/page_configuration.xsd">
33
<body>
44
<referenceContainer name="loki-components">
5-
<block name="loki-components.script.component.debugger" template="Loki_Debugger::script/component/debugger-component.phtml"/>
5+
<block name="loki-debugger.script.component.debugger" template="Loki_Debugger::script/component/debugger-component.phtml"/>
66
</referenceContainer>
77

88
<referenceContainer name="loki-scripts">
9-
<block name="loki-components.debugger" template="Loki_Debugger::component/debugger.phtml" before="-"/>
9+
<block name="loki-debugger.json-directive" template="Loki_Debugger::script/json-directive.phtml" />
10+
</referenceContainer>
11+
12+
<referenceContainer name="before.body.end">
13+
<block name="loki-debugger.debugger" template="Loki_Debugger::component/debugger.phtml" />
1014
</referenceContainer>
1115
</body>
1216
</page>

view/frontend/templates/component/debugger.phtml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ declare(strict_types=1);
33

44
/** @version 1.0.2 */
55

6+
use Loki\CssUtils\Util\CssClass;
67
use Magento\Framework\View\Element\Template;
78
use Loki\Components\Util\IdConvertor;
89
use Loki\Debugger\Component\Debugger\DebuggerViewModel;
@@ -12,6 +13,7 @@ use Loki\Components\Factory\ViewModelFactory;
1213
/** @var ViewModelFactory $viewModelFactory */
1314
/** @var DebuggerViewModel $viewModel */
1415
/** @var IdConvertor $idConvertor */
16+
/** @var CssClass $css */
1517

1618
$idConvertor = $viewModelFactory->create(IdConvertor::class);
1719
$htmlId = $idConvertor->toElementId($block->getNameInLayout());

view/frontend/templates/script/component/debugger-component.phtml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,6 @@ use Magento\Framework\View\Element\Template;
55

66
/** @var Template $block */
77
?>
8-
<script>
9-
document.addEventListener('alpine:init', () => {
10-
Alpine.directive('json', (el, { value, expression }, { evaluate }) => {
11-
if (expression) {
12-
el.textContent = JSON.stringify(evaluate(expression));
13-
}
14-
});
15-
});
16-
</script>
17-
188
<script>
199
document.addEventListener('alpine:init', () => {
2010
Alpine.data('LokiComponentsDebugger', () => ({
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<?php
2+
declare(strict_types=1);
3+
4+
use Magento\Framework\View\Element\Template;
5+
6+
/** @var Template $block */
7+
?>
8+
<script>
9+
document.addEventListener('alpine:init', () => {
10+
Alpine.directive('json', (el, { value, expression }, { evaluate }) => {
11+
if (expression) {
12+
el.textContent = JSON.stringify(evaluate(expression));
13+
}
14+
});
15+
});
16+
</script>

0 commit comments

Comments
 (0)