Skip to content

Commit 477a5cc

Browse files
committed
Fix integration tests
1 parent 17b8722 commit 477a5cc

3 files changed

Lines changed: 6 additions & 5 deletions

File tree

.github/workflows/integration-tests/etc/mysql-client-config.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
<?php
1+
<?php // phpcs:ignoreFile
2+
23
return [
34
'client-mariadb' => [
45
'disable-ssl',

.github/workflows/static-tests.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ jobs:
1313

1414
- name: Run Magento 2 PHPCS Tests
1515
run: |
16-
export PHPCS_LEVEL=$(jq -r '.phpcs_severity // 10' MODULE.json)
16+
PHPCS_LEVEL=${{ env.PHPCS_LEVEL }}
17+
test -z "$PHPCS_LEVEL" && PHPCS_LEVEL=$(jq -r '.phpcs_severity // 10' MODULE.json)
1718
test -z "$PHPCS_LEVEL" && PHPCS_LEVEL=10
1819
echo "Testing for PHPCS severity $PHPCS_LEVEL"
1920
cd /tmp/magento

Test/Integration/Validator/EmailValidatorTest.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ public function testWithNoValue(): void
1515
{
1616
$validator = ObjectManager::getInstance()->get(EmailValidator::class);
1717
$actualResult = $validator->validate(null);
18-
$error = array_pop($actualResult);
19-
$this->assertStringContainsString('is not valid', $error, var_export($actualResult, true));
18+
$this->assertTrue($actualResult);
2019
}
2120

2221
/**
@@ -42,7 +41,7 @@ public function testWithVariousValues(string $email, true|string $expectedResult
4241
public static function getValues(): array
4342
{
4443
return [
45-
['jane@example.com', true],
44+
['jane@yireo.com', true],
4645
['jane@example.comcom', 'is not reachable for mail'],
4746
];
4847
}

0 commit comments

Comments
 (0)