fix: startup registry, menu events, click behavior

- startup: switch from Task Scheduler/PowerShell to HKCU Run
  registry key via winreg — simpler and more reliable
- tray: remove with_menu_on_left_click(false) which was breaking
  menu event delivery in tray_icon 0.17; add Clone to TrayMenuIds
- main: double-click now toggles icons; remove single-click toggle
  (menu is the primary interface); reduce loop sleep 50ms -> 16ms;
  add dlog! to every menu event for diagnostics
- startup_tab: update UI text to reflect registry approach

Author: Londopy

src/main.rs

@@ -150,7 +150,7 @@ fn main_loop(
             }
         }
 
-        std::thread::sleep(Duration::from_millis(50));
+        std::thread::sleep(Duration::from_millis(16));
 
         // ── Poll hotkey events ────────────────────────────────────────────
         while let Some(event) = hotkeys::poll_hotkey_event() {
@@ -179,6 +179,7 @@ fn main_loop(
 
         // ── Poll tray menu events ─────────────────────────────────────────
         while let Some(event) = tray::poll_menu_event() {
+            dlog!("menu event: id={:?}", event.id);
             let id = &event.id;
             if id == &tray_handle.ids.toggle_icons {
                 let _ = cmd_tx.send(Cmd::ToggleIcons);
@@ -205,23 +206,16 @@ fn main_loop(
             }
         }
 
-        // ── Poll tray icon events (double-click opens settings) ───────────
+        // ── Poll tray icon events (double-click toggles icons) ───────────
         while let Some(event) = tray::poll_tray_event() {
-            use tray_icon::{MouseButton, MouseButtonState, TrayIconEvent};
-            if let TrayIconEvent::Click {
-                button: MouseButton::Left,
-                button_state: MouseButtonState::Up,
-                ..
-            } = event
-            {
-                let _ = cmd_tx.send(Cmd::ToggleIcons);
-            }
+            use tray_icon::{MouseButton, TrayIconEvent};
             if let TrayIconEvent::DoubleClick {
                 button: MouseButton::Left,
                 ..
             } = event
             {
-                let _ = cmd_tx.send(Cmd::OpenSettings);
+                dlog!("tray double-click: ToggleIcons");
+                let _ = cmd_tx.send(Cmd::ToggleIcons);
             }
         }
 

src/startup.rs

@@ -1,89 +1,44 @@
 use anyhow::Result;
+use winreg::enums::*;
+use winreg::RegKey;
 
-/// Register a Task Scheduler ONLOGON task via PowerShell.
-pub fn register(exe_path: &str, delay_s: u32) -> Result<()> {
-    let delay_iso = format!("PT{}S", delay_s);
-    let script = format!(
-        r#"
-$action = New-ScheduledTaskAction -Execute '{exe}'
-$trigger = New-ScheduledTaskTrigger -AtLogOn
-$trigger.Delay = '{delay}'
-$settings = New-ScheduledTaskSettingsSet -StartWhenAvailable -ExecutionTimeLimit 0
-$principal = New-ScheduledTaskPrincipal -UserId ([System.Security.Principal.WindowsIdentity]::GetCurrent().Name) -RunLevel Limited
-Register-ScheduledTask -TaskName 'HideDesktopApps' -Action $action -Trigger $trigger -Settings $settings -Principal $principal -Force | Out-Null
-"#,
-        exe = exe_path,
-        delay = delay_iso
-    );
-
-    let output = std::process::Command::new("powershell")
-        .args([
-            "-ExecutionPolicy",
-            "Bypass",
-            "-WindowStyle",
-            "Hidden",
-            "-NonInteractive",
-            "-Command",
-            &script,
-        ])
-        .output()?;
-
-    if !output.status.success() {
-        let stderr = String::from_utf8_lossy(&output.stderr);
-        eprintln!("Startup register warning: {stderr}");
-    }
+const RUN_KEY: &str = r"Software\Microsoft\Windows\CurrentVersion\Run";
+const APP_NAME: &str = "HideDesktopApps";
 
+/// Add the app to HKCU\...\Run so it starts at login.
+pub fn register(exe_path: &str, _delay_s: u32) -> Result<()> {
+    let hkcu = RegKey::predef(HKEY_CURRENT_USER);
+    let (run_key, _) = hkcu.create_subkey(RUN_KEY)?;
+    run_key.set_value(APP_NAME, &exe_path.to_string())?;
     Ok(())
 }
 
-/// Unregister the Task Scheduler task.
+/// Remove the app from HKCU\...\Run.
 pub fn unregister() -> Result<()> {
-    let output = std::process::Command::new("powershell")
-        .args([
-            "-ExecutionPolicy",
-            "Bypass",
-            "-WindowStyle",
-            "Hidden",
-            "-NonInteractive",
-            "-Command",
-            "Unregister-ScheduledTask -TaskName 'HideDesktopApps' -Confirm:$false 2>$null",
-        ])
-        .output()?;
-
-    if !output.status.success() {
-        let stderr = String::from_utf8_lossy(&output.stderr);
-        eprintln!("Startup unregister warning: {stderr}");
+    let hkcu = RegKey::predef(HKEY_CURRENT_USER);
+    if let Ok(run_key) = hkcu.open_subkey_with_flags(RUN_KEY, KEY_WRITE) {
+        run_key.delete_value(APP_NAME).ok();
     }
-
     Ok(())
 }
 
-/// Check whether the task is currently registered.
+/// Returns true if the app is registered in HKCU\...\Run.
 pub fn is_registered() -> bool {
-    let out = std::process::Command::new("powershell")
-        .args([
-            "-ExecutionPolicy",
-            "Bypass",
-            "-WindowStyle",
-            "Hidden",
-            "-NonInteractive",
-            "-Command",
-            "Get-ScheduledTask -TaskName 'HideDesktopApps' -ErrorAction SilentlyContinue",
-        ])
-        .output();
-
-    out.map(|o| !o.stdout.is_empty()).unwrap_or(false)
+    let hkcu = RegKey::predef(HKEY_CURRENT_USER);
+    hkcu.open_subkey(RUN_KEY)
+        .and_then(|k| k.get_value::<String, _>(APP_NAME))
+        .is_ok()
 }
 
-/// Sync the startup task to match the config: register if enabled, unregister if disabled.
+/// Sync the startup entry to match the config: register if enabled, remove if disabled.
 pub fn sync_startup(config: &crate::config::StartupConfig, exe_path: &str) {
     if config.enabled {
         if let Err(e) = register(exe_path, config.delay_s) {
-            eprintln!("Failed to register startup task: {e}");
+            eprintln!("Failed to register startup: {e}");
         }
     } else if is_registered() {
         if let Err(e) = unregister() {
-            eprintln!("Failed to unregister startup task: {e}");
+            eprintln!("Failed to unregister startup: {e}");
         }
     }
 }

src/tray.rs

@@ -6,6 +6,7 @@ use crate::config::ProfileConfig;
 use crate::state::AppState;
 
 /// IDs for tray menu items, including one entry per profile.
+#[derive(Clone)]
 pub struct TrayMenuIds {
     pub toggle_icons: tray_icon::menu::MenuId,
     pub toggle_taskbar: tray_icon::menu::MenuId,
@@ -259,7 +260,6 @@ pub fn build_tray(state: &AppState, profiles: &[ProfileConfig]) -> Result<TrayHa
         .with_menu(Box::new(menu))
         .with_icon(icon)
         .with_tooltip(tooltip)
-        .with_menu_on_left_click(false) // left click fires the click event; right click shows menu
         .build()?;
 
     Ok(TrayHandle { tray, ids })

src/ui/startup_tab.rs

@@ -10,29 +10,23 @@ impl SettingsApp {
             &mut self.config.startup.enabled,
             "Start HideDesktopApps at Windows logon",
         );
-        ui.label("Uses Windows Task Scheduler (runs without UAC prompt).");
-
-        ui.add_space(8.0);
-        ui.horizontal(|ui| {
-            ui.label("Startup delay:");
-            ui.add(egui::Slider::new(&mut self.config.startup.delay_s, 0..=60).suffix(" seconds"));
-        });
+        ui.label("Adds the app to the Windows registry Run key (HKCU).");
 
         ui.add_space(8.0);
         ui.separator();
 
         let registered = self.startup_registered;
         ui.label(if registered {
-            "Status: Task Scheduler task is registered."
+            "Status: Registered in startup."
         } else {
-            "Status: Not registered in Task Scheduler."
+            "Status: Not registered in startup."
         });
 
         ui.add_space(4.0);
         ui.horizontal(|ui| {
             if ui.button("Register Now").clicked() {
                 let exe = crate::win_ops::current_exe_path();
-                if let Err(e) = crate::startup::register(&exe, self.config.startup.delay_s) {
+                if let Err(e) = crate::startup::register(&exe, 0) {
                     eprintln!("Startup register error: {e}");
                 } else {
                     self.startup_registered = true;