fix: update button always self-updates (remove install-type guard)

Author: Londopy

src/ui/updater_tab.rs

@@ -124,15 +124,9 @@ impl SettingsApp {
                 .is_some_and(|s| s.starts_with("Update available"));
 
             if update_ready && ui.button("Download & Install Update").clicked() {
-                if let Some(hint) = crate::updater::managed_install_hint() {
-                    // Don't self-update a Scoop/WinGet install — point the user
-                    // at their package manager instead.
-                    self.update_status = Some(hint);
-                } else {
-                    let channel = self.config.updater.channel.clone();
-                    crate::updater::background_apply(channel);
-                    self.update_status = Some("Downloading update...".to_string());
-                }
+                let channel = self.config.updater.channel.clone();
+                crate::updater::background_apply(channel);
+                self.update_status = Some("Downloading update...".to_string());
             }
         });
 

src/updater.rs

@@ -189,49 +189,8 @@ fn resolve_expected_hash(
     None
 }
 
-// Detected install method, used to decide whether self-update is safe.
-enum InstallKind {
-    Portable,
-    Scoop,
-    Installer,
-}
-
-fn install_kind() -> InstallKind {
-    let exe = crate::win_ops::current_exe_path().to_lowercase();
-    if exe.contains("\\scoop\\") {
-        return InstallKind::Scoop;
-    }
-    // The Inno installer installs to %LOCALAPPDATA%\HideDesktopApps. Detect by the
-    // running exe's location (not a global registry key) so a portable or dev copy
-    // on a machine that merely ran the installer once still self-updates.
-    if let Ok(local) = std::env::var("LOCALAPPDATA") {
-        let install_dir = format!("{}\\hidedesktopapps\\", local.to_lowercase());
-        if exe.starts_with(&install_dir) {
-            return InstallKind::Installer;
-        }
-    }
-    InstallKind::Portable
-}
-
-// If this is a package-manager-managed install, returns a hint telling the user
-// how to upgrade instead of self-replacing (which would clobber the manager).
-pub fn managed_install_hint() -> Option<String> {
-    let cmd = match install_kind() {
-        InstallKind::Scoop => "scoop update HideDesktopApps",
-        InstallKind::Installer => "winget upgrade Londopy.HideDesktopApps",
-        InstallKind::Portable => return None,
-    };
-    Some(format!("Managed install \u{2014} update with: {cmd}"))
-}
-
 // download the update zip and replace the running exe
 pub fn download_and_apply(channel: &str) -> Result<()> {
-    // Never self-replace a package-manager-managed install; tell the user how
-    // to upgrade through their manager instead.
-    if let Some(hint) = managed_install_hint() {
-        bail!("Self-update skipped. {hint}");
-    }
-
     let release = fetch_latest_release(channel)?;
     let suffix = arch_suffix();
     let client = build_client()?;