Generalized belief sources code for pantheon effects#13198
Draft
Hokath wants to merge 14 commits into
Draft
Conversation
because we have to evaluate it for when the religion changes, we need to pass the new religion before the city has it
we got up to UpdateReligion when we realized the argument needed to be passed
when it calls eNewMajority for no_religion the struc will just not evaluate secondary pantheon, so i think the refactor is fine? Note the check for city connection was actually missing in the perma pantheon code before
Contributor
Author
|
I should remove these obsolete era checks because they aren't used and the way they're used for the wonder modifier is on the building era, not the player era. Edit: done, will rebase later |
this one didn't make use of the bIsHolyCity flag in the belief call, instead using a hardcoded holy city check. Therefore this effect actually didn't work for, e.g., follower beliefs. I've dropped this check for the pantheon part, it could go either way but isn't used in VP at the moment. I checked vanilla and it doesn't seem to be used there either.
Collaborator
|
Maybe the struct and the new function fit more in CvCityReligions. |
Contributor
Author
|
yes good point I realize we will also need this in DoInstantYield player level function |
now have to find belief calculations that did not consider secondary pantheons
religion guard was outside the pantheon stuff
have to ditch the ones measuring following cities and followers, etc. First because pantheons dont do that but Second because we don't know the source religion (or no religion) of the extra belief sources
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting the implementation of cleaner pantheon effect code blocks as discussed in PR #13185
For player level effects we'd need another struc, but I think that only appears once in pantheons iirc?