sync back some stuff

Author: LoneWandererProductions

CommonLibraryGuiTests/Image/example Polaris.png

@@ -125,18 +125,21 @@ IEnumerator IEnumerable.GetEnumerator()
         /// <exception cref="KeyNotFoundException">The key {key} was not found in the lookup map.</exception>
         public TValue Get(TKey key)
         {
-            var capacity = _keys.Length;
-            var baseHash = GetHash(key, capacity);
+            var hash = GetHash(key, _keys.Length);
+            var originalHash = hash;
 
-            for (int i = 0; i < capacity; i++)
+            while (_keyPresence[hash])
             {
-                var hash = (baseHash + i * i) % capacity;
-
-                if (!_keyPresence[hash])
-                    break; // Key not found
-
                 if (_keys[hash].Equals(key))
+                {
                     return _values[hash];
+                }
+
+                hash = (hash + 1) % _keys.Length; // Linear probing
+                if (hash == originalHash)
+                {
+                    break; // Full cycle, key not found
+                }
             }
 
             throw new KeyNotFoundException(ExtendedSystemObjectsResources.ErrorValueNotFound);
@@ -150,21 +153,22 @@ public TValue Get(TKey key)
         /// <returns>The value amd bool check if it exists.</returns>
         public bool TryGetValue(TKey key, out TValue value)
         {
-            var capacity = _keys.Length;
-            var baseHash = GetHash(key, capacity);
+            var hash = GetHash(key, _keys.Length);
+            var originalHash = hash;
 
-            for (int i = 0; i < capacity; i++)
+            while (_keyPresence[hash])
             {
-                var hash = (baseHash + i * i) % capacity;
-
-                if (!_keyPresence[hash])
-                    break; // Key not found
-
                 if (_keys[hash].Equals(key))
                 {
                     value = _values[hash];
                     return true;
                 }
+
+                hash = (hash + 1) % _keys.Length; // Linear probing
+                if (hash == originalHash)
+                {
+                    break; // Full cycle, key not found
+                }
             }
 
             value = default;
@@ -182,8 +186,7 @@ public bool TryGetValue(TKey key, out TValue value)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         private static int GetHash(TKey key, int capacity)
         {
-            // Mask sign bit to avoid negative numbers
-            return (key.GetHashCode() & 0x7FFFFFFF) % capacity;
+            return Math.Abs(key.GetHashCode() % capacity);
         }
 
         /// <summary>

CommonLibraryGuiTests/Image/example.png

@@ -6,19 +6,24 @@
  * PROGRAMMER:  Peter Geinitz (Wayfarer)
  */
 
+// ReSharper disable UnusedMember.Global
+// ReSharper disable UnusedType.Global
+// ReSharper disable MemberCanBeInternal
+
 using System;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 
 namespace ExtendedSystemObjects
 {
+    /// <inheritdoc />
     /// <summary>
     /// Represents a high-performance, low-overhead array of integers
     /// backed by unmanaged memory. Designed for performance-critical
     /// scenarios where garbage collection overhead must be avoided.
     /// </summary>
-    /// <seealso cref="System.IDisposable" />
-    public unsafe class IntArray : IDisposable
+    /// <seealso cref="T:System.IDisposable" />
+    public sealed unsafe class IntArray : IDisposable
     {
         /// <summary>
         /// The buffer
@@ -87,9 +92,9 @@ public void RemoveAt(int index)
 #if DEBUG
             if (index < 0 || index >= _length) throw new IndexOutOfRangeException();
 #endif
-            int* ptr = (int*)_buffer;
+            var ptr = (int*)_buffer;
 
-            for (int i = index; i < _length - 1; i++)
+            for (var i = index; i < _length - 1; i++)
             {
                 ptr[i] = ptr[i + 1];
             }
@@ -114,8 +119,8 @@ public void Resize(int newSize)
         /// </summary>
         public void Clear()
         {
-            int* ptr = (int*)_buffer;
-            for (int i = 0; i < _length; i++)
+            var ptr = (int*)_buffer;
+            for (var i = 0; i < _length; i++)
             {
                 ptr[i] = 0;
             }
@@ -135,6 +140,7 @@ public void Clear()
             Dispose();
         }
 
+        /// <inheritdoc />
         /// <summary>
         /// Frees the unmanaged memory held by the array.
         /// After disposal, the instance should not be used.

ExtendedSystemObjects/ImmutableLookupMap.cs

@@ -6,29 +6,30 @@
  * PROGRAMMER:  Peter Geinitz (Wayfarer)
  */
 
+// ReSharper disable UnusedMember.Global
+// ReSharper disable UnusedType.Global
+// ReSharper disable MemberCanBePrivate.Global
+// ReSharper disable MemberCanBeInternal
+
 using System;
 using System.Runtime.InteropServices;
 
 namespace ExtendedSystemObjects
 {
+    /// <inheritdoc />
     /// <summary>
     /// A high-performance list of integers backed by unmanaged memory.
     /// Supports fast adding, popping, and random access with minimal overhead.
     /// Designed for scenarios where manual memory management is needed.
     /// </summary>
-    /// <seealso cref="System.IDisposable" />
-    public unsafe class IntList : IDisposable
+    /// <seealso cref="T:System.IDisposable" />
+    public sealed unsafe class IntList : IDisposable
     {
         /// <summary>
         /// The buffer
         /// </summary>
         private IntPtr _buffer;
 
-        /// <summary>
-        /// The count
-        /// </summary>
-        private int _count;
-
         /// <summary>
         /// The capacity
         /// </summary>
@@ -37,7 +38,7 @@ public unsafe class IntList : IDisposable
         /// <summary>
         /// Gets the number of elements contained in the <see cref="IntList"/>.
         /// </summary>
-        public int Count => _count;
+        public int Count { get; private set; }
 
         /// <summary>
         /// Pointer to the unmanaged buffer holding the integer elements.
@@ -70,8 +71,8 @@ public void Push(int value)
         /// <param name="value">The integer value to add.</param>
         public void Add(int value)
         {
-            EnsureCapacity(_count + 1);
-            _ptr[_count++] = value;
+            EnsureCapacity(Count + 1);
+            _ptr[Count++] = value;
         }
 
         /// <summary>
@@ -81,9 +82,10 @@ public void Add(int value)
         /// <exception cref="InvalidOperationException">Thrown when the list is empty.</exception>
         public int Pop()
         {
-            if (_count == 0)
+            if (Count == 0)
                 throw new InvalidOperationException("Stack empty");
-            return _ptr[--_count];
+
+            return _ptr[--Count];
         }
 
         /// <summary>
@@ -93,9 +95,10 @@ public int Pop()
         /// <exception cref="InvalidOperationException">Thrown when the list is empty.</exception>
         public int Peek()
         {
-            if (_count == 0)
+            if (Count == 0)
                 throw new InvalidOperationException("Stack empty");
-            return _ptr[_count - 1];
+
+            return _ptr[Count - 1];
         }
 
         /// <summary>
@@ -109,14 +112,14 @@ public int this[int i]
             get
             {
 #if DEBUG
-                if (i < 0 || i >= _count) throw new IndexOutOfRangeException();
+                if (i < 0 || i >= Count) throw new IndexOutOfRangeException();
 #endif
                 return _ptr[i];
             }
             set
             {
 #if DEBUG
-                if (i < 0 || i >= _count) throw new IndexOutOfRangeException();
+                if (i < 0 || i >= Count) throw new IndexOutOfRangeException();
 #endif
                 _ptr[i] = value;
             }
@@ -131,7 +134,7 @@ private void EnsureCapacity(int min)
         {
             if (min <= _capacity) return;
 
-            int newCapacity = _capacity * 2;
+            var newCapacity = _capacity * 2;
             if (newCapacity < min)
                 newCapacity = min;
 
@@ -145,15 +148,15 @@ private void EnsureCapacity(int min)
         /// </summary>
         public void Clear()
         {
-            _count = 0;
+            Count = 0;
         }
 
         /// <summary>
         /// Returns a span over the valid elements of the list.
         /// Allows fast, safe access to the underlying data.
         /// </summary>
         /// <returns>A <see cref="Span{Int32}"/> representing the list's contents.</returns>
-        public Span<int> AsSpan() => new((void*)_buffer, _count);
+        public Span<int> AsSpan() => new((void*)_buffer, Count);
 
         /// <summary>
         /// Finalizes an instance of the <see cref="IntList"/> class, releasing unmanaged resources.
@@ -163,8 +166,9 @@ public void Clear()
             Dispose();
         }
 
+        /// <inheritdoc />
         /// <summary>
-        /// Frees unmanaged resources used by the <see cref="IntList"/>.
+        /// Frees unmanaged resources used by the <see cref="T:ExtendedSystemObjects.IntList" />.
         /// After calling this method, the instance should not be used.
         /// </summary>
         public void Dispose()
@@ -174,7 +178,8 @@ public void Dispose()
                 Marshal.FreeHGlobal(_buffer);
                 _buffer = IntPtr.Zero;
             }
-            _count = 0;
+
+            Count = 0;
             _capacity = 0;
         }
     }

ExtendedSystemObjects/IntArray.cs

@@ -152,9 +152,11 @@ private void HandleInternalCommand(ExtensionCommands extension, int key)
                 irtInternal.ProcessInput(IrtConst.InternalHelpWithParameter, command.Command);
             }
 
+            UserFeedback feedback = null;
+
             //if none is available use the standard one from Internal
             //if not we use the provided one
-            if (_userFeedback?.TryGetValue(extension.FeedBackId, out var feedback) != true)
+            if (_userFeedback?.TryGetValue(extension.FeedBackId, out feedback) != true)
             {
                 feedback = IrtConst.InternalFeedback[-1];
             }