fix some small fry in my interpreter and prepare it to be used in my CoreConsole.

Author: LoneWandererProductions

CommonLibraryGuiTests/Image/example Polaris.png

@@ -84,6 +84,36 @@ internal static class ConResources
             }
         };
 
+        /// <summary>
+        ///     For commands that need your feedback
+        /// </summary>
+        internal static readonly Dictionary<int, UserFeedback> Feedback = new() { { 1, ReplaceFeedback } };
+
+        internal static readonly Dictionary<int, InCommand> ExtensionCommands = new()
+        {
+            {
+                Header, new InCommand
+                {
+                    Command = "dryrun",
+                    ParameterCount = 0,
+                    FeedbackId =1,
+                    Description =
+                        "Show results and optional run commands"
+                }
+            }
+        };
+
+        private static readonly UserFeedback ReplaceFeedback = new()
+        {
+            Before = true,
+            Message = "Do you want to commit the following changes?",
+            Options = new Dictionary<AvailableFeedback, string>
+            {
+                { AvailableFeedback.Yes, "If you want to execute the Command type yes" },
+                { AvailableFeedback.No, " If you want to stop executing the Command type no." }
+            }
+        };
+
         /// <summary>
         /// The resource1
         /// </summary>

CommonLibraryGuiTests/Image/example.png

@@ -29,11 +29,6 @@ public sealed class FeedbackTests
         /// </summary>
         private static OutCommand _outCommand;
 
-        /// <summary>
-        ///     The user feedback
-        /// </summary>
-        private readonly Dictionary<int, UserFeedback> _userFeedback = new();
-
         /// <summary>
         ///     Feedback and extension test.
         /// </summary>

CoreConsole/ConResources.cs

@@ -34,6 +34,14 @@ public sealed class ExtensionCommands
         ///     Gets or sets the parameter.
         /// </summary>
         public List<string> ExtensionParameter { get; internal set; }
+        /// <summary>
+        /// Gets the feedback identifier.
+        /// Define the feedback id
+        /// </summary>
+        /// <value>
+        /// The feedback identifier.
+        /// </value>
+        public int FeedBackId { get; internal set; }
 
         /// <summary>
         ///     Gets or sets the base command.

InterpreteTests/FeedbackTests.cs

@@ -298,7 +298,6 @@ internal static class IrtConst
         /// </summary>
         internal const char AdvancedOpen = '{';
 
-
         /// <summary>
         ///     The close Clause, Standard is')'
         /// </summary>
@@ -394,7 +393,7 @@ internal static class IrtConst
             Options = new Dictionary<AvailableFeedback, string>
             {
                 { AvailableFeedback.Yes, "If you want to execute the Command type yes" },
-                { AvailableFeedback.No, " if you want to stop executing the Command." }
+                { AvailableFeedback.No, " If you want to stop executing the Command type no." }
             }
         };
 
@@ -582,7 +581,6 @@ internal static class IrtConst
             }
         };
 
-
         /// <summary>
         ///     Basic internal Help
         /// </summary>
@@ -627,6 +625,7 @@ private static string HelpInfo()
             );
         }
 
+        //TODO build everthing as a query with goto and if else
         //TODO add repeat as internal replacement for while
         //TODO add while
         //TODO add void Sub Procedure.

Interpreter/ExtensionCommands.cs

@@ -92,6 +92,7 @@ private static (ExtensionCommands Extension, int Status) ProcessExtension(string
                 // Check for parameter overload
                 var overloadCheck = IrtKernel.CheckOverload(extensionCommands[commandKey].Command, parameters.Count,
                     extensionCommands);
+
                 if (overloadCheck == null)
                 {
                     return (null, IrtConst.ParameterMismatch);
@@ -104,6 +105,8 @@ private static (ExtensionCommands Extension, int Status) ProcessExtension(string
             exCommand.ExtensionNameSpace = nameSpace;
             exCommand.ExtensionCommand = commandKey;
             exCommand.ExtensionParameter = parameters;
+            //get the feedback id
+            exCommand.FeedBackId = extensionCommands[commandKey].FeedbackId;
             exCommand.BaseCommand = baseCommand;
 
             return (exCommand, IrtConst.ExtensionFound);

Interpreter/IrtConst.cs

@@ -29,6 +29,11 @@ internal sealed class IrtHandleExtensionInternal : IDisposable
         /// </summary>
         private Dictionary<int, InCommand> _commands;
 
+        /// <summary>
+        /// The user feedback, only for external extensions.
+        /// </summary>
+        private Dictionary<int, UserFeedback> _userFeedback;
+
         /// <summary>
         ///     Indicates whether the object has been disposed.
         /// </summary>
@@ -57,18 +62,20 @@ private IrtHandleExtensionInternal()
         }
 
         /// <summary>
-        ///     Initializes a new instance of the <see cref="IrtHandleExtensionInternal" /> class with specified parameters.
+        /// Initializes a new instance of the <see cref="IrtHandleExtensionInternal" /> class with specified parameters.
         /// </summary>
         /// <param name="irtPrompt">Instance of IrtParser.</param>
         /// <param name="commands">Dictionary of commands.</param>
         /// <param name="prompt">Instance of Prompt.</param>
         /// <param name="irtInternal">Instance of IrtHandleInternal.</param>
+        /// <param name="userFeedback">The user feedback.</param>
         public IrtHandleExtensionInternal(IrtParserInput irtPrompt, Dictionary<int, InCommand> commands, Prompt prompt,
-            IrtHandleInternal irtInternal)
+            IrtHandleInternal irtInternal, Dictionary<int, UserFeedback> userFeedback = null)
         {
             _irtHandlePrompt = irtPrompt;
             _commands = commands;
             _prompt = prompt;
+            _userFeedback = userFeedback;
             _prompt.HandleFeedback += HandleFeedback;
             _myRequestId = Guid.NewGuid().ToString();
             _irtHandleInternal = irtInternal;
@@ -119,13 +126,14 @@ internal void ProcessExtensionInternal(ExtensionCommands extension)
         private void ProcessHelpCommand(ExtensionCommands extension)
         {
             var key = IrtKernel.CheckForKeyWord(extension.BaseCommand, IrtConst.InternCommands);
+
             if (key != IrtConst.Error)
             {
                 HandleInternalCommand(extension, key);
             }
             else
             {
-                HandleExternalCommand(extension);
+                HandleExternalCommand(extension, _userFeedback);
             }
         }
 
@@ -144,28 +152,36 @@ private void HandleInternalCommand(ExtensionCommands extension, int key)
                 irtInternal.ProcessInput(IrtConst.InternalHelpWithParameter, command.Command);
             }
 
-            var feedback = IrtConst.InternalFeedback[-1];
-            var feedbackReceiver = new IrtFeedback
+            //if none is avaiable use the standard one from Internal
+            //if not we use the provided one
+            if (_userFeedback?.TryGetValue(extension.FeedBackId, out var feedback) != true)
             {
-                RequestId = _myRequestId,
-                Feedback = feedback,
-                BranchId = 11,
-                Key = key,
-                Command = extension.BaseCommand
-            };
+                feedback = IrtConst.InternalFeedback[-1];
+            }
+
+            var feedbackReceiver = new IrtFeedback
+                {
+                    RequestId = _myRequestId,
+                    Feedback = feedback,
+                    BranchId = 11,
+                    Key = key,
+                    Command = extension.BaseCommand
+                };
+
             _prompt.RequestFeedback(feedbackReceiver);
         }
 
         /// <summary>
         ///     Handles external commands.
         /// </summary>
         /// <param name="extension">The extension command.</param>
-        private void HandleExternalCommand(ExtensionCommands extension)
+        private void HandleExternalCommand(ExtensionCommands extension, Dictionary<int, UserFeedback> userFeedback)
         {
             var com = _irtHandlePrompt.ProcessInput(extension.BaseCommand);
             var command = _commands[com.Command];
             _irtHandleInternal.ProcessInput(IrtConst.InternalHelpWithParameter, command.Command);
 
+            //TODO completly wrong here
             var feedback = IrtConst.InternalFeedback[-1];
 
             var feedbackReceiver = new IrtFeedback

Interpreter/IrtExtension.cs

@@ -34,7 +34,7 @@ internal sealed class IrtParserInput : IDisposable
         /// <summary>
         ///     Extension Command Register
         /// </summary>
-        private static Dictionary<int, InCommand> _extension;
+        private static Dictionary<int, InCommand>? _extension;
 
         /// <summary>
         ///     My request identifier
@@ -125,7 +125,7 @@ internal void Initiate(UserSpace use)
             _irtExtension = new IrtExtension();
             _irtHandleInternal = new IrtHandleInternal(use.Commands, use.UserSpaceName, _prompt);
             _irtHandleExtensionInternal =
-                new IrtHandleExtensionInternal(this, use.Commands, _prompt, _irtHandleInternal);
+                new IrtHandleExtensionInternal(this, use.Commands, _prompt, _irtHandleInternal, _userFeedback);
 
             // Notify log about loading up
             var log = Logging.SetLastError(IrtConst.InformationStartup, 2);