Fix up the last pieces of Filehandler

Author: LoneWandererProductions

CommonLibraryTests/HelperMethods.cs

@@ -60,25 +60,18 @@ internal static void CreateFile(string path)
     {
         var folder = Path.GetDirectoryName(path);
         if (folder == null)
-        {
-            return;
-        }
+            throw new ArgumentException("Path must contain a directory.", nameof(path));
 
-        if (!Directory.Exists(folder))
-        {
-            _ = Directory.CreateDirectory(folder);
-        }
+        Directory.CreateDirectory(folder); // safe even if exists
 
         if (File.Exists(path))
-        {
-            return;
-        }
+            File.Delete(path);
 
         using var fs = File.Create(path);
         for (byte i = 0; i < 100; i++)
-        {
             fs.WriteByte(i);
-        }
+
+        fs.Flush(true); // ensure fully written to disk
     }
 
     /// <summary>

CommonLibraryTests/IoFileHandlerInternal.cs

@@ -53,7 +53,7 @@ public void CleanUpExtensionListValidInputRemovesDots()
     ///     Gets the sub folder invalid element path throws argument exception.
     /// </summary>
     [TestMethod]
-    [ExpectedException(typeof(ArgumentNullException))]
+    [ExpectedException(typeof(ArgumentException))]
     public void GetSubFolderInvalidElementPathThrowsArgumentException()
     {
         // Arrange
@@ -69,7 +69,7 @@ public void GetSubFolderInvalidElementPathThrowsArgumentException()
     ///     Gets the sub folder invalid root path throws argument exception.
     /// </summary>
     [TestMethod]
-    [ExpectedException(typeof(ArgumentNullException))]
+    [ExpectedException(typeof(ArgumentException))]
     public void GetSubFolderInvalidRootPathThrowsArgumentException()
     {
         // Arrange

FileHandler/FileHandleSort.cs

@@ -38,7 +38,7 @@ public static class FileHandleSort
             return new List<T>();
 
         return values
-            .OrderBy(v => new FilePathStruct(pathSelector(v)))
+            .OrderBy(v => new FilePathWrapper(pathSelector(v)))
             .ToList();
     }
 
@@ -57,9 +57,9 @@ public static List<string> PathSort(this List<string>? value)
             return value ?? new List<string>();
 
         return value
-            .Select(path => new FilePathStruct(path))
+            .Select(path => new FilePathWrapper(path))
             .OrderBy(fps => fps)
-            .Select(fps => fps.Path)
+            .Select(fps => fps.FullPath)
             .ToList();
     }
 }

FileHandler/FileHandlerException.cs

@@ -3,60 +3,77 @@
  * PROJECT:     FileHandler
  * FILE:        FileHandler/FileHandlerException.cs
  * PURPOSE:     Exception Class
- * PROGRAMER:   Peter Geinitz (Wayfarer)
- * SOURCES:     https://msdn.microsoft.com/en-us/library/system.exception.getobjectdata.aspx
+ * PROGRAMMER:  Peter Geinitz (Wayfarer)
  */
 
 using System;
-using System.Runtime.Serialization;
 
-namespace FileHandler;
-
-/// <inheritdoc />
-/// <summary>
-///     The file handler exception class.
-/// </summary>
-/// <seealso cref="T:System.Exception" />
-[Serializable]
-public sealed class FileHandlerException : Exception
+namespace FileHandler
 {
-    /// <inheritdoc />
     /// <summary>
-    ///     Initializes a new instance of the <see cref="T:FileHandler.FileHandlerException" /> class.
+    /// Represents errors that occur within the <c>FileHandler</c> library.
     /// </summary>
-    /// <param name="message">The message.</param>
-    internal FileHandlerException(string message) : base(message)
+    /// <remarks>
+    /// This exception is thrown for library-specific errors, providing a consistent type
+    /// for users to catch and handle separately from standard .NET exceptions.
+    /// </remarks>
+    public sealed class FileHandlerException : Exception
     {
-    }
+        /// <summary>
+        /// Gets the path of the file associated with this exception, if any.
+        /// </summary>
+        public string? FilePath { get; }
 
-    /// <inheritdoc />
-    /// <summary>
-    ///     Initializes a new instance of the <see cref="T:FileHandler.FileHandlerException" /> class.
-    /// </summary>
-    /// <param name="info">The info.</param>
-    /// <param name="context">The context.</param>
-    private FileHandlerException(SerializationInfo info, StreamingContext context) : base(info, context)
-    {
-    }
+        /// <summary>
+        /// Initializes a new instance of the <see cref="FileHandlerException"/> class.
+        /// </summary>
+        public FileHandlerException()
+        {
+        }
 
-    /// <inheritdoc />
-    /// <summary>
-    ///     Initializes a new instance of the <see cref="T:FileHandler.FileHandlerException" /> class.
-    /// </summary>
-    public FileHandlerException()
-    {
-    }
+        /// <summary>
+        /// Initializes a new instance of the <see cref="FileHandlerException"/> class with a specified error message.
+        /// </summary>
+        /// <param name="message">The message describing the error.</param>
+        public FileHandlerException(string message)
+            : base(message)
+        {
+        }
 
-    /// <inheritdoc />
-    /// <summary>
-    ///     Initializes a new instance of the <see cref="T:FileHandler.FileHandlerException" /> class.
-    /// </summary>
-    /// <param name="message">The message we declarte</param>
-    /// <param name="innerException">
-    ///     The Exception that caused the Exception or a null reference <see langword="Nothing" /> in
-    ///     Visual Basic), if there is no inner Exception.
-    /// </param>
-    public FileHandlerException(string message, Exception innerException) : base(message, innerException)
-    {
+        /// <summary>
+        /// Initializes a new instance of the <see cref="FileHandlerException"/> class with a specified 
+        /// error message and a reference to the inner exception that caused this exception.
+        /// </summary>
+        /// <param name="message">The message describing the error.</param>
+        /// <param name="innerException">The exception that caused the current exception.</param>
+        public FileHandlerException(string message, Exception innerException)
+            : base(message, innerException)
+        {
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="FileHandlerException"/> class with a specified 
+        /// error message and an associated file path.
+        /// </summary>
+        /// <param name="message">The message describing the error.</param>
+        /// <param name="filePath">The file path related to the error.</param>
+        public FileHandlerException(string message, string filePath)
+            : base(message)
+        {
+            FilePath = filePath;
+        }
+
+        /// <summary>
+        /// Initializes a new instance of the <see cref="FileHandlerException"/> class with a specified 
+        /// error message, associated file path, and a reference to the inner exception that caused this exception.
+        /// </summary>
+        /// <param name="message">The message describing the error.</param>
+        /// <param name="filePath">The file path related to the error.</param>
+        /// <param name="innerException">The exception that caused the current exception.</param>
+        public FileHandlerException(string message, string filePath, Exception innerException)
+            : base(message, innerException)
+        {
+            FilePath = filePath;
+        }
     }
 }